From: CK Hu <ck.hu@mediatek.com>
To: Bo-Chen Chen <rex-bc.chen@mediatek.com>,
<chunkuang.hu@kernel.org>, <p.zabel@pengutronix.de>,
<daniel@ffwll.ch>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <mripard@kernel.org>,
<tzimmermann@suse.de>, <matthias.bgg@gmail.com>, <deller@gmx.de>,
<airlied@linux.ie>
Cc: devicetree@vger.kernel.org, linux-fbdev@vger.kernel.org,
granquet@baylibre.com, jitao.shi@mediatek.com,
liangxu.xu@mediatek.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, msp@baylibre.com,
Project_Global_Chrome_Upstream_Group@mediatek.com,
linux-mediatek@lists.infradead.org, wenst@chromium.org,
linux-arm-kernel@lists.infradead.org,
angelogioacchino.delregno@collabora.com
Subject: Re: [PATCH v15 05/11] drm/mediatek: Add MT8195 Embedded DisplayPort driver
Date: Tue, 2 Aug 2022 10:56:30 +0800 [thread overview]
Message-ID: <f38757a55a5a5f90099a2b166363b32da44ff3a7.camel@mediatek.com> (raw)
In-Reply-To: <20220727045035.32225-6-rex-bc.chen@mediatek.com>
Hi, Bo-Chen:
On Wed, 2022-07-27 at 12:50 +0800, Bo-Chen Chen wrote:
> From: Markus Schneider-Pargmann <msp@baylibre.com>
>
> This patch adds a embedded displayport driver for the MediaTek mt8195
> SoC.
>
> It supports the MT8195, the embedded DisplayPort units. It offers
> DisplayPort 1.4 with up to 4 lanes.
>
> The driver creates a child device for the phy. The child device will
> never exist without the parent being active. As they are sharing a
> register range, the parent passes a regmap pointer to the child so
> that
> both can work with the same register range. The phy driver sets
> device
> data that is read by the parent to get the phy device that can be
> used
> to control the phy properties.
>
> This driver is based on an initial version by
> Jitao shi <jitao.shi@mediatek.com>
>
> Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
> Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
> Signed-off-by: Bo-Chen Chen <rex-bc.chen@mediatek.com>
> ---
[snip]
> +
> +#define MTK_DP_ENC0_P0_31D0 (ENC0_OFFSET + 0x1D0)
MTK_DP_ENC0_P0_31D0 is uselese, so remove it.
> +#define VSC_EXT_CEA_HB0_DP_ENC0_P0_MASK GENMASK(7, 0)
> +#define VSC_EXT_CEA_HB1_DP_ENC0_P0_MASK GENMASK(15, 8)
> +#define VSC_EXT_CEA_HB1_DP_ENC0_P0_SHIFT BIT(3)
> +
> +#define MTK_DP_ENC0_P0_31D4 (ENC0_OFFSET + 0x1D4)
Ditto.
> +#define VSC_EXT_CEA_HB2_DP_ENC0_P0_MASK GENMASK(7, 0)
> +#define VSC_EXT_CEA_HB2_DP_ENC0_P0_SHIFT 0
> +#define VSC_EXT_CEA_HB3_DP_ENC0_P0_MASK GENMASK(15, 8)
> +
> +#define MTK_DP_ENC0_P0_31D8 (ENC0_OFFSET + 0x1D8)
Ditto.
> +#define VSC_EXT_VESA_NUM_DP_ENC0_P0_MASK GENMASK(5, 0)
> +#define VSC_EXT_VESA_NUM_DP_ENC0_P0_SHIFT 0
> +#define VSC_EXT_CEA_NUM_DP_ENC0_P0_MASK GENMASK(13, 8)
> +#define VSC_EXT_CEA_NUM_DP_ENC0_P0_SHIFT BIT(3)
> +
> +#define MTK_DP_ENC0_P0_31DC (ENC0_OFFSET + 0x1DC)
Ditto.
Regards,
CK
> +#define HDR0_CFG_DP_ENC0_P0_MASK GENMASK(7, 0)
> +#define HDR0_CFG_DP_ENC0_P0_SHIFT 0
> +#define MTK_DP_ENC0_P0_31E8 (ENC0_OFFSET + 0x1E8)
> +#define MTK_DP_ENC0_P0_31EC (ENC0_OFFSET + 0x1EC)
> +#define AUDIO_CH_SRC_SEL_DP_ENC0_P0_MASK BIT(4)
> +#define AUDIO_CH_SRC_SEL_DP_ENC0_P0_SHIFT BIT(2)
> +#define ISRC1_HB3_DP_ENC0_P0_MASK GENMASK(15, 8)
> +#define ISRC1_HB3_DP_ENC0_P0_SHIFT BIT(3)
> +
next prev parent reply other threads:[~2022-08-02 2:56 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 4:50 [PATCH v15 00/11] drm/mediatek: Add MT8195 DisplayPort driver Bo-Chen Chen
2022-07-27 4:50 ` [PATCH v15 01/11] dt-bindings: mediatek,dp: Add Display Port binding Bo-Chen Chen
2022-07-27 7:23 ` Krzysztof Kozlowski
2022-07-28 9:39 ` Rex-BC Chen
2022-07-27 4:50 ` [PATCH v15 02/11] drm/edid: Convert cea_sad helper struct to kernelDoc Bo-Chen Chen
2022-07-27 4:50 ` [PATCH v15 03/11] drm/edid: Add cea_sad helpers for freq/length Bo-Chen Chen
2022-07-27 9:34 ` AngeloGioacchino Del Regno
2022-08-02 14:11 ` Jani Nikula
2022-08-05 6:54 ` Rex-BC Chen
2022-08-05 7:54 ` Jani Nikula
2022-07-27 4:50 ` [PATCH v15 04/11] video/hdmi: Add audio_infoframe packing for DP Bo-Chen Chen
2022-07-27 9:35 ` AngeloGioacchino Del Regno
2022-07-27 4:50 ` [PATCH v15 05/11] drm/mediatek: Add MT8195 Embedded DisplayPort driver Bo-Chen Chen
2022-07-27 9:36 ` AngeloGioacchino Del Regno
2022-08-02 2:56 ` CK Hu [this message]
2022-08-02 5:09 ` CK Hu
2022-08-05 8:22 ` Rex-BC Chen
2022-08-02 7:57 ` CK Hu
2022-07-27 4:50 ` [PATCH v15 06/11] drm/mediatek: Add MT8195 External DisplayPort support Bo-Chen Chen
2022-07-27 9:38 ` AngeloGioacchino Del Regno
2022-08-02 2:37 ` CK Hu
2022-08-03 5:47 ` Rex-BC Chen
2022-07-27 4:50 ` [PATCH v15 07/11] drm/mediatek: Add retry to prevent misjudgment for sink devices Bo-Chen Chen
2022-07-27 9:40 ` AngeloGioacchino Del Regno
2022-07-28 9:40 ` Rex-BC Chen
2022-08-05 7:10 ` Rex-BC Chen
2022-07-27 4:50 ` [PATCH v15 08/11] drm/mediatek: add hpd debounce Bo-Chen Chen
2022-07-27 4:50 ` [PATCH v15 09/11] drm/mediatek: set monitor to DP_SET_POWER_D3 to avoid garbage Bo-Chen Chen
2022-07-27 4:50 ` [PATCH v15 10/11] drm/mediatek: DP audio support for MT8195 Bo-Chen Chen
2022-07-27 4:50 ` [PATCH v15 11/11] drm/mediatek: Use cached audio config when changing resolution Bo-Chen Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f38757a55a5a5f90099a2b166363b32da44ff3a7.camel@mediatek.com \
--to=ck.hu@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=airlied@linux.ie \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=daniel@ffwll.ch \
--cc=deller@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=granquet@baylibre.com \
--cc=jitao.shi@mediatek.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=liangxu.xu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mripard@kernel.org \
--cc=msp@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=rex-bc.chen@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=tzimmermann@suse.de \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).