* [PATCH] drm/drv: Remove invalid assignments
@ 2020-12-11 2:17 Tian Tao
2020-12-11 8:49 ` Simon Ser
0 siblings, 1 reply; 2+ messages in thread
From: Tian Tao @ 2020-12-11 2:17 UTC (permalink / raw)
To: maarten.lankhorst, mripard, tzimmermann, airlied, daniel; +Cc: dri-devel
it's not necessary to assign a value of 0 to ret here, because if
the previous functions were executed correctly, ret would be 0.
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
drivers/gpu/drm/drm_drv.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
index b92f7fd..ddf7eab 100644
--- a/drivers/gpu/drm/drm_drv.c
+++ b/drivers/gpu/drm/drm_drv.c
@@ -894,8 +894,6 @@ int drm_dev_register(struct drm_device *dev, unsigned long flags)
if (drm_core_check_feature(dev, DRIVER_MODESET))
drm_modeset_register_all(dev);
- ret = 0;
-
DRM_INFO("Initialized %s %d.%d.%d %s for %s on minor %d\n",
driver->name, driver->major, driver->minor,
driver->patchlevel, driver->date,
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/drv: Remove invalid assignments
2020-12-11 2:17 [PATCH] drm/drv: Remove invalid assignments Tian Tao
@ 2020-12-11 8:49 ` Simon Ser
0 siblings, 0 replies; 2+ messages in thread
From: Simon Ser @ 2020-12-11 8:49 UTC (permalink / raw)
To: Tian Tao; +Cc: tzimmermann, airlied, dri-devel
On Friday, December 11th, 2020 at 3:17 AM, Tian Tao <tiantao6@hisilicon.com> wrote:
> it's not necessary to assign a value of 0 to ret here, because if
> the previous functions were executed correctly, ret would be 0.
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Reviewed-by: Simon Ser <contact@emersion.fr>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-11 8:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-11 2:17 [PATCH] drm/drv: Remove invalid assignments Tian Tao
2020-12-11 8:49 ` Simon Ser
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).