DriverDev-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: richard@nod.at (Richard Weinberger)
Subject: [PATCH] erofs: move erofs out of staging
Date: Sun, 18 Aug 2019 01:25:58 +0200 (CEST)
Message-ID: <1163995781.68824.1566084358245.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <20190817220706.GA11443@hsiangkao-HP-ZHAN-66-Pro-G1>

----- Urspr?ngliche Mail -----
>> How does erofs compare to squashfs?
>> IIUC it is designed to be faster. Do you have numbers?
>> Feel free to point me older mails if you already showed numbers,
>> I have to admit I didn't follow the development very closely.
> 
> You can see the following related material which has microbenchmark
> tested on my laptop:
> https://static.sched.com/hosted_files/kccncosschn19eng/19/EROFS%20file%20system_OSS2019_Final.pdf
> 
> which was mentioned in the related topic as well:
> https://lore.kernel.org/r/20190815044155.88483-1-gaoxiang25 at huawei.com/

Thanks!
Will read into.

While digging a little into the code I noticed that you have very few
checks of the on-disk data.
For example ->u.i_blkaddr. I gave it a try and created a
malformed filesystem where u.i_blkaddr is 0xdeadbeef, it causes the kernel
to loop forever around erofs_read_raw_page().

Thanks,
//richard

  reply index

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-17  8:23 hsiangkao
2019-08-17 21:19 ` richard
2019-08-17 22:07   ` hsiangkao
2019-08-17 23:25     ` richard [this message]
2019-08-17 23:38       ` hsiangkao
2019-08-18  0:04         ` hsiangkao
2019-08-18  0:52           ` hsiangkao
2019-08-18  8:16         ` richard
2019-08-18  8:45           ` hsiangkao
2019-08-18  9:03             ` richard
2019-08-18  9:09               ` gregkh
2019-08-18  9:21                 ` richard
2019-08-18 10:12                   ` chao
2019-08-18 15:11                   ` tytso
2019-08-18 15:58                     ` hch
2019-08-18 16:16                       ` ebiggers
2019-08-18 16:22                         ` hch
2019-08-18 16:33                           ` hsiangkao
2019-08-18 17:29                           ` ebiggers
2019-08-18 17:47                             ` hch
2019-08-18 18:16                               ` hsiangkao
2019-08-18 20:14                                 ` hsiangkao
2019-08-19  7:35                                   ` richard
2019-08-19  8:02                                     ` gaoxiang25
2019-08-19 10:34                                       ` [PATCH 0/6] staging: erofs: first stage of corrupted compressed images gaoxiang25
2019-08-19 10:34                                         ` [PATCH 1/6] staging: erofs: some compressed cluster should be submitted for corrupted images gaoxiang25
2019-08-19 14:36                                           ` chao
2019-08-19 14:39                                           ` chao
2019-08-19 10:34                                         ` [PATCH 2/6] staging: erofs: cannot set EROFS_V_Z_INITED_BIT if fill_inode_lazy fails gaoxiang25
2019-08-19 14:43                                           ` chao
2019-08-19 10:34                                         ` [PATCH 3/6] staging: erofs: add two missing erofs_workgroup_put for corrupted images gaoxiang25
2019-08-19 14:40                                           ` chao
2019-08-19 10:34                                         ` [PATCH 4/6] staging: erofs: avoid loop in submit chains gaoxiang25
2019-08-19 14:50                                           ` chao
2019-08-19 10:34                                         ` [PATCH 5/6] staging: erofs: detect potential multiref due to corrupted images gaoxiang25
2019-08-19 14:57                                           ` chao
2019-08-21  2:19                                             ` gregkh
2019-08-19 10:34                                         ` [PATCH 6/6] staging: erofs: avoid endless loop of invalid lookback distance 0 gaoxiang25
2019-08-19 14:58                                           ` chao
2019-08-19 16:09                                   ` [PATCH] erofs: move erofs out of staging darrick.wong
2019-08-19 20:30                                     ` hsiangkao
2019-08-20  0:55                                       ` quwenruo.btrfs
2019-08-20  1:55                                         ` gaoxiang25
2019-08-20  2:24                                         ` yuchao0
2019-08-20  2:38                                           ` quwenruo.btrfs
2019-08-20  7:15                                             ` yuchao0
2019-08-20  8:46                                               ` quwenruo.btrfs
2019-08-21  2:12                                                 ` yuchao0
2019-08-20 15:56                                           ` tytso
2019-08-20 16:35                                             ` hsiangkao
2019-08-21  0:51                                               ` tytso
2019-08-21  1:34                                             ` yuchao0
2019-08-21  1:48                                               ` darrick.wong
2019-08-21  1:57                                                 ` yuchao0
2019-08-20  3:33                                         ` miaoxie
2019-08-20  3:46                                           ` gaoxiang25
2019-08-20  6:04                                           ` quwenruo.btrfs
2019-08-20  6:22                                             ` gaoxiang25
2019-08-19  7:37                               ` richard
2019-08-18 17:43                       ` tytso
2019-08-18 16:03                     ` hsiangkao
2019-08-18 17:06                     ` richard
2019-08-18 17:46                       ` tytso
2019-08-18 18:00                         ` richard
2019-08-18 18:31                           ` hsiangkao
2019-08-18  9:28               ` hsiangkao
2019-08-19  5:28                 ` [PATCH] erofs: Use common kernel logging style joe
2019-08-19  5:52                   ` gaoxiang25
2019-08-19  5:47                     ` joe
2019-08-19  6:08                       ` gaoxiang25

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1163995781.68824.1566084358245.JavaMail.zimbra@nod.at \
    --to=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DriverDev-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/driverdev-devel/0 driverdev-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 driverdev-devel driverdev-devel/ https://lore.kernel.org/driverdev-devel \
		driverdev-devel@linuxdriverproject.org devel@driverdev.osuosl.org driverdev-devel@archiver.kernel.org
	public-inbox-index driverdev-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.linuxdriverproject.driverdev-devel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox