From: Christian Gromm <christian.gromm@microchip.com>
To: <gregkh@linuxfoundation.org>
Cc: Christian Gromm <christian.gromm@microchip.com>,
driverdev-devel@linuxdriverproject.org,
linux-usb@vger.kernel.org
Subject: [PATCH v3 6/7] staging: most: usb: use macro ATTRIBUTE_GROUPS
Date: Fri, 15 May 2020 11:21:04 +0200 [thread overview]
Message-ID: <1589534465-7423-7-git-send-email-christian.gromm@microchip.com> (raw)
In-Reply-To: <1589534465-7423-1-git-send-email-christian.gromm@microchip.com>
This patch makes use of the macro ATTRIBUTE_GROUPS to create the groups
instead of defining them manually.
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
v2:
v3:
drivers/staging/most/usb/usb.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/most/usb/usb.c b/drivers/staging/most/usb/usb.c
index 8995ed0..56b75e4 100644
--- a/drivers/staging/most/usb/usb.c
+++ b/drivers/staging/most/usb/usb.c
@@ -905,14 +905,7 @@ static struct attribute *dci_attrs[] = {
NULL,
};
-static struct attribute_group dci_attr_group = {
- .attrs = dci_attrs,
-};
-
-static const struct attribute_group *dci_attr_groups[] = {
- &dci_attr_group,
- NULL,
-};
+ATTRIBUTE_GROUPS(dci);
static void release_dci(struct device *dev)
{
@@ -1065,7 +1058,7 @@ hdm_probe(struct usb_interface *interface, const struct usb_device_id *id)
mdev->dci->dev.init_name = "dci";
mdev->dci->dev.parent = get_device(mdev->iface.dev);
- mdev->dci->dev.groups = dci_attr_groups;
+ mdev->dci->dev.groups = dci_groups;
mdev->dci->dev.release = release_dci;
if (device_register(&mdev->dci->dev)) {
mutex_unlock(&mdev->io_mutex);
--
2.7.4
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-05-15 9:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 9:20 [PATCH v3 0/7] staging: most: usb: fix issues found in code audit Christian Gromm
2020-05-15 9:20 ` [PATCH v3 1/7] staging: most: usb: use dev_*() functions to print messages Christian Gromm
2020-05-15 9:21 ` [PATCH v3 2/7] staging: most: usb: remove reference to USB error codes Christian Gromm
2020-05-15 9:21 ` [PATCH v3 3/7] staging: most: usb: check number of reported endpoints Christian Gromm
2020-05-15 9:21 ` [PATCH v3 4/7] staging: most: usb: use dev_dbg function Christian Gromm
2020-05-15 9:21 ` [PATCH v3 5/7] staging: most: fix typo in Kconfig Christian Gromm
2020-05-15 9:21 ` Christian Gromm [this message]
2020-05-15 9:21 ` [PATCH v3 7/7] Documentation: ABI: correct sysfs attribute description of MOST driver Christian Gromm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1589534465-7423-7-git-send-email-christian.gromm@microchip.com \
--to=christian.gromm@microchip.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).