driverdev-devel.linuxdriverproject.org archive mirror
 help / color / mirror / Atom feed
From: Jerome Pouiller <Jerome.Pouiller@silabs.com>
To: zhengbin <zhengbin13@huawei.com>
Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"dan.carpenter@oracle.com" <dan.carpenter@oracle.com>
Subject: Re: [PATCH v2 3/3] staging: wfx: Make some functions static in sta.c
Date: Wed, 9 Oct 2019 14:05:23 +0000	[thread overview]
Message-ID: <1924991.0e3bHXHc7a@pc-42> (raw)
In-Reply-To: <1570629030-29888-4-git-send-email-zhengbin13@huawei.com>

On Wednesday 9 October 2019 15:43:35 CEST zhengbin wrote:
> Fix sparse warnings:
> 
> drivers/staging/wfx/sta.c:269:6: warning: symbol 'wfx_update_filtering_work' was not declared. Should it be static?
> drivers/staging/wfx/sta.c:475:6: warning: symbol 'wfx_event_handler_work' was not declared. Should it be static?
> drivers/staging/wfx/sta.c:521:6: warning: symbol 'wfx_bss_loss_work' was not declared. Should it be static?
> drivers/staging/wfx/sta.c:528:6: warning: symbol 'wfx_bss_params_work' was not declared. Should it be static?
> drivers/staging/wfx/sta.c:539:6: warning: symbol 'wfx_set_beacon_wakeup_period_work' was not declared. Should it be static?
> drivers/staging/wfx/sta.c:732:6: warning: symbol 'wfx_unjoin_work' was not declared. Should it be static?
> drivers/staging/wfx/sta.c:794:6: warning: symbol 'wfx_set_cts_work' was not declared. Should it be static?
> drivers/staging/wfx/sta.c:1234:6: warning: symbol 'wfx_set_tim_work' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: zhengbin <zhengbin13@huawei.com>
> ---
>  drivers/staging/wfx/sta.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c
> index 2855d14..d19bab6 100644
> --- a/drivers/staging/wfx/sta.c
> +++ b/drivers/staging/wfx/sta.c
> @@ -269,7 +269,7 @@ void wfx_update_filtering(struct wfx_vif *wvif)
>         kfree(bf_tbl);
>  }
> 
> -void wfx_update_filtering_work(struct work_struct *work)
> +static void wfx_update_filtering_work(struct work_struct *work)
>  {
>         struct wfx_vif *wvif = container_of(work, struct wfx_vif, update_filtering_work);
> 
> @@ -475,7 +475,7 @@ static void wfx_event_report_rssi(struct wfx_vif *wvif, uint8_t raw_rcpi_rssi)
>         ieee80211_cqm_rssi_notify(wvif->vif, cqm_evt, rcpi_rssi, GFP_KERNEL);
>  }
> 
> -void wfx_event_handler_work(struct work_struct *work)
> +static void wfx_event_handler_work(struct work_struct *work)
>  {
>         struct wfx_vif *wvif =
>                 container_of(work, struct wfx_vif, event_handler_work);
> @@ -521,14 +521,14 @@ void wfx_event_handler_work(struct work_struct *work)
>         __wfx_free_event_queue(&list);
>  }
> 
> -void wfx_bss_loss_work(struct work_struct *work)
> +static void wfx_bss_loss_work(struct work_struct *work)
>  {
>         struct wfx_vif *wvif = container_of(work, struct wfx_vif, bss_loss_work.work);
> 
>         ieee80211_connection_loss(wvif->vif);
>  }
> 
> -void wfx_bss_params_work(struct work_struct *work)
> +static void wfx_bss_params_work(struct work_struct *work)
>  {
>         struct wfx_vif *wvif = container_of(work, struct wfx_vif, bss_params_work);
> 
> @@ -539,7 +539,7 @@ void wfx_bss_params_work(struct work_struct *work)
>         mutex_unlock(&wvif->wdev->conf_mutex);
>  }
> 
> -void wfx_set_beacon_wakeup_period_work(struct work_struct *work)
> +static void wfx_set_beacon_wakeup_period_work(struct work_struct *work)
>  {
>         struct wfx_vif *wvif = container_of(work, struct wfx_vif, set_beacon_wakeup_period_work);
> 
> @@ -732,7 +732,7 @@ static void wfx_do_join(struct wfx_vif *wvif)
>                 cfg80211_put_bss(wvif->wdev->hw->wiphy, bss);
>  }
> 
> -void wfx_unjoin_work(struct work_struct *work)
> +static void wfx_unjoin_work(struct work_struct *work)
>  {
>         struct wfx_vif *wvif = container_of(work, struct wfx_vif, unjoin_work);
> 
> @@ -794,7 +794,7 @@ int wfx_sta_remove(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
>         return 0;
>  }
> 
> -void wfx_set_cts_work(struct work_struct *work)
> +static void wfx_set_cts_work(struct work_struct *work)
>  {
>         struct wfx_vif *wvif = container_of(work, struct wfx_vif, set_cts_work);
>         u8 erp_ie[3] = { WLAN_EID_ERP_INFO, 1, 0 };
> @@ -1234,7 +1234,7 @@ static int wfx_set_tim_impl(struct wfx_vif *wvif, bool aid0_bit_set)
>         return 0;
>  }
> 
> -void wfx_set_tim_work(struct work_struct *work)
> +static void wfx_set_tim_work(struct work_struct *work)
>  {
>         struct wfx_vif *wvif = container_of(work, struct wfx_vif, set_tim_work);
> 
> --
> 2.7.4
> 

Reviewed-by: Jérôme Pouiller <jerome.pouiller@silabs.com>

-- 
Jérôme Pouiller

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

      reply	other threads:[~2019-10-09 14:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-09 13:50 [PATCH v2 0/3] staging: wfx: Make some functions static zhengbin
2019-10-09 13:47 ` Dan Carpenter
2019-10-09 13:50 ` [PATCH v2 1/3] staging: wfx: Make function 'sram_write_dma_safe', 'load_firmware_secure' static zhengbin
2019-10-09 14:04   ` [PATCH v2 1/3] staging: wfx: Make function 'sram_write_dma_safe','load_firmware_secure' static Jerome Pouiller
2019-10-09 13:50 ` [PATCH v2 2/3] staging: wfx: Make function 'wfx_tx_queue_get' static zhengbin
2019-10-09 14:05   ` Jerome Pouiller
2019-10-09 13:50 ` [PATCH v2 3/3] staging: wfx: Make some functions static in sta.c zhengbin
2019-10-09 14:05   ` Jerome Pouiller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1924991.0e3bHXHc7a@pc-42 \
    --to=jerome.pouiller@silabs.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=zhengbin13@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).