From: Dan Carpenter <dan.carpenter@oracle.com>
To: Gao Xiang <gaoxiang25@huawei.com>
Cc: devel@driverdev.osuosl.org, Chao Yu <chao@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Miao Xie <miaoxie@huawei.com>, Chao Yu <yuchao0@huawei.com>,
LKML <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>,
weidu.du@huawei.com, Fang Wei <fangwei1@huawei.com>,
Joe Perches <joe@perches.com>,
linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH v3 6/7] erofs: remove all likely/unlikely annotations
Date: Sat, 31 Aug 2019 13:57:32 +0300 [thread overview]
Message-ID: <20190831105732.GH8372@kadam> (raw)
In-Reply-To: <20190830160415.GC69026@architecture4>
On Sat, Aug 31, 2019 at 12:04:20AM +0800, Gao Xiang wrote:
> I don't have some benchmark data for each unlikely/likely case (and I have
> no idea "is that worth to take time to benchmark rather than do another more
> useful stuffs"), so..I have to kill them all...
We don't really require benchmarks, just that a reasonable person would
think it might make a difference.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2019-08-31 10:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190830032006.GA20217@architecture4>
[not found] ` <20190830033643.51019-1-gaoxiang25@huawei.com>
2019-08-30 15:25 ` [PATCH v3 1/7] erofs: on-disk format should have explicitly assigned numbers Gao Xiang
[not found] ` <20190830033643.51019-6-gaoxiang25@huawei.com>
2019-08-30 15:46 ` [PATCH v3 6/7] erofs: remove all likely/unlikely annotations Christoph Hellwig
2019-08-30 16:04 ` Gao Xiang
2019-08-31 10:57 ` Dan Carpenter [this message]
[not found] ` <20190830033643.51019-7-gaoxiang25@huawei.com>
2019-08-30 16:28 ` [PATCH v3 7/7] erofs: redundant assignment in __erofs_get_meta_page() Christoph Hellwig
2019-08-30 16:48 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190831105732.GH8372@kadam \
--to=dan.carpenter@oracle.com \
--cc=chao@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=fangwei1@huawei.com \
--cc=gaoxiang25@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=joe@perches.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miaoxie@huawei.com \
--cc=weidu.du@huawei.com \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).