From: Christian Brauner <christian.brauner@ubuntu.com>
To: Hridya Valsaraju <hridya@google.com>
Cc: devel@driverdev.osuosl.org, kernel-team@android.com,
"Todd Kjos" <tkjos@android.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, "Arve Hjønnevåg" <arve@android.com>,
"Joel Fernandes" <joel@joelfernandes.org>,
"Martijn Coenen" <maco@android.com>
Subject: Re: [PATCH v3 0/4] Add binder state and statistics to binderfs
Date: Wed, 4 Sep 2019 13:19:35 +0200 [thread overview]
Message-ID: <20190904111934.ya37tlzqjqvt7h6a@wittgenstein> (raw)
In-Reply-To: <20190903161655.107408-1-hridya@google.com>
On Tue, Sep 03, 2019 at 09:16:51AM -0700, Hridya Valsaraju wrote:
> Currently, the only way to access binder state and
> statistics is through debugfs. We need a way to
> access the same even when debugfs is not mounted.
> These patches add a mount option to make this
> information available in binderfs without affecting
> its presence in debugfs. The following debugfs nodes
> will be made available in a binderfs instance when
> mounted with the mount option 'stats=global' or 'stats=local'.
>
> /sys/kernel/debug/binder/failed_transaction_log
> /sys/kernel/debug/binder/proc
> /sys/kernel/debug/binder/state
> /sys/kernel/debug/binder/stats
> /sys/kernel/debug/binder/transaction_log
> /sys/kernel/debug/binder/transactions
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
Btw, I think your counting is off-by-one. :) We usually count the
initial send of a series as 0 and the first rework of that series as v1.
I think you counted your initial send as v1 and the first rework as v2. :)
Christian
>
> Hridya Valsaraju (4):
> binder: add a mount option to show global stats
> binder: Add stats, state and transactions files
> binder: Make transaction_log available in binderfs
> binder: Add binder_proc logging to binderfs
>
> drivers/android/binder.c | 95 ++++++-----
> drivers/android/binder_internal.h | 84 ++++++++++
> drivers/android/binderfs.c | 255 ++++++++++++++++++++++++++----
> 3 files changed, 362 insertions(+), 72 deletions(-)
>
> --
> 2.23.0.187.g17f5b7556c-goog
>
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2019-09-04 11:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 16:16 [PATCH v3 0/4] Add binder state and statistics to binderfs Hridya Valsaraju
2019-09-03 16:16 ` [PATCH v3 1/4] binder: add a mount option to show global stats Hridya Valsaraju
2019-09-03 16:16 ` [PATCH v3 2/4] binder: Add stats, state and transactions files Hridya Valsaraju
2019-09-03 16:16 ` [PATCH v3 3/4] binder: Make transaction_log available in binderfs Hridya Valsaraju
2019-09-03 16:16 ` [PATCH v3 4/4] binder: Add binder_proc logging to binderfs Hridya Valsaraju
2019-09-04 11:19 ` Christian Brauner [this message]
2019-09-04 14:20 ` [PATCH v3 0/4] Add binder state and statistics " Joel Fernandes
2019-09-04 14:49 ` Greg Kroah-Hartman
2019-09-04 15:12 ` Christian Brauner
2019-09-04 16:51 ` Hridya Valsaraju
2019-09-04 17:05 ` Hridya Valsaraju
2019-09-27 13:19 ` Christian Brauner
2019-09-27 18:11 ` Hridya Valsaraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904111934.ya37tlzqjqvt7h6a@wittgenstein \
--to=christian.brauner@ubuntu.com \
--cc=arve@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hridya@google.com \
--cc=joel@joelfernandes.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).