From: Johan Hovold <johan@kernel.org>
To: Pedro Chinen <ph.u.chinen@gmail.com>
Cc: devel@driverdev.osuosl.org, Alex Elder <elder@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Johan Hovold <johan@kernel.org>,
linux-kernel@vger.kernel.org, greybus-dev@lists.linaro.org,
lkcamp@lists.libreplanetbr.org
Subject: Re: [PATCH] staging: greybus: loopback_test: remove multiple blank lines
Date: Thu, 5 Sep 2019 09:25:28 +0200 [thread overview]
Message-ID: <20190905072528.GE1701@localhost> (raw)
In-Reply-To: <20190904210547.5288-1-ph.u.chinen@gmail.com>
On Wed, Sep 04, 2019 at 09:05:47PM +0000, Pedro Chinen wrote:
> Fix following checkpath warnings in multiple lines:
> CHECK: Please don't use multiple blank lines
Checkpatch reports five instances of this CHECK, please fix them all in
one go.
> Signed-off-by: Pedro Chinen <ph.u.chinen@gmail.com>
> ---
> drivers/staging/greybus/tools/loopback_test.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/greybus/tools/loopback_test.c b/drivers/staging/greybus/tools/loopback_test.c
> index ba6f905f26fa..1e78c148d7cb 100644
> --- a/drivers/staging/greybus/tools/loopback_test.c
> +++ b/drivers/staging/greybus/tools/loopback_test.c
> @@ -779,7 +779,6 @@ static void prepare_devices(struct loopback_test *t)
> if (t->stop_all || device_enabled(t, i))
> write_sysfs_val(t->devices[i].sysfs_entry, "type", 0);
>
> -
> for (i = 0; i < t->device_count; i++) {
> if (!device_enabled(t, i))
> continue;
> @@ -850,7 +849,6 @@ void loopback_run(struct loopback_test *t)
> if (ret)
> goto err;
>
> -
> get_results(t);
>
> log_results(t);
> @@ -882,7 +880,6 @@ static int sanity_check(struct loopback_test *t)
>
> }
>
> -
> return 0;
> }
Johan
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
prev parent reply other threads:[~2019-09-05 7:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 21:05 [PATCH] staging: greybus: loopback_test: remove multiple blank lines Pedro Chinen
2019-09-05 7:25 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190905072528.GE1701@localhost \
--to=johan@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkcamp@lists.libreplanetbr.org \
--cc=ph.u.chinen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).