From: Dan Carpenter <dan.carpenter@oracle.com>
To: volery <sandro@volery.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, rspringer@google.com,
toddpoynor@google.com
Subject: Re: [PATCH] Fixed parentheses malpractice in apex_driver.c
Date: Sat, 7 Sep 2019 17:38:49 +0300 [thread overview]
Message-ID: <20190907143849.GA30834@kadam> (raw)
In-Reply-To: <20190906183801.GA2456@volery>
You need a subject prefix. It should be something like:
[PATCH] Staging: gasket: Fix parentheses malpractice in apex_driver.c
Generally "Fix" is considered better style than "Fixed". We aren't
going to care about that in staging, but the patch prefix is mandatory
so you will need to redo it anyway and might as well fix that as well.
On Fri, Sep 06, 2019 at 08:38:01PM +0200, volery wrote:
> There were some parentheses at the end of lines, which I took care of.
> This is my first patch.
^^^^^^^^^^^^^^^^^^^^^^
Put this sort of comments after the --- cut off line
>
> Signed-off-by: Sandro Volery <sandro@volery.com>
> ---
^^^
Put it here. It will be removed when we apply the patch so it won't
be recorded in the git log.
> drivers/staging/gasket/apex_driver.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
Joe's comments are, of course, correct as well.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2019-09-07 14:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 18:38 [PATCH] Fixed parentheses malpractice in apex_driver.c volery
2019-09-06 20:55 ` Joe Perches
2019-09-07 14:38 ` Dan Carpenter [this message]
2019-09-07 14:48 ` Sandro Volery
2019-09-07 14:52 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190907143849.GA30834@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rspringer@google.com \
--cc=sandro@volery.com \
--cc=toddpoynor@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).