From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Valentin Vidic <vvidic@valentin-vidic.from.hr>
Cc: devel@driverdev.osuosl.org,
Valdis Kletnieks <valdis.kletnieks@vt.edu>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/4] staging: exfat: drop duplicate date_time_t struct
Date: Sun, 8 Sep 2019 19:50:31 +0100 [thread overview]
Message-ID: <20190908185031.GA10011@kroah.com> (raw)
In-Reply-To: <20190908173539.26963-2-vvidic@valentin-vidic.from.hr>
On Sun, Sep 08, 2019 at 05:35:37PM +0000, Valentin Vidic wrote:
> Use timestamp_t for everything and cleanup duplicate code.
Wait, how are these "duplicate"? The fields are in different order,
don't these refer to things on-disk?
Did you test this?
> -struct date_time_t {
> - u16 Year;
> - u16 Month;
> - u16 Day;
> - u16 Hour;
> - u16 Minute;
> - u16 Second;
> - u16 MilliSecond;
> -};
> -
> struct part_info_t {
> u32 Offset; /* start sector number of the partition */
> u32 Size; /* in sectors */
> @@ -289,6 +279,16 @@ struct file_id_t {
> u32 hint_last_clu;
> };
>
> +struct timestamp_t {
> + u16 millisec; /* 0 ~ 999 */
> + u16 sec; /* 0 ~ 59 */
> + u16 min; /* 0 ~ 59 */
> + u16 hour; /* 0 ~ 23 */
> + u16 day; /* 1 ~ 31 */
> + u16 mon; /* 1 ~ 12 */
> + u16 year; /* 0 ~ 127 (since 1980) */
> +};
They really look "backwards" to me, how are these the same? What am I
missing?
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2019-09-08 18:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-08 17:35 [PATCH v3 1/4] staging: exfat: drop unused function parameter Valentin Vidic
2019-09-08 17:35 ` [PATCH v3 2/4] staging: exfat: drop duplicate date_time_t struct Valentin Vidic
2019-09-08 18:50 ` Greg Kroah-Hartman [this message]
2019-09-08 19:40 ` Valentin Vidić
2019-09-08 18:54 ` Greg Kroah-Hartman
2019-09-08 19:31 ` Valentin Vidić
2019-09-08 17:35 ` [PATCH v3 3/4] staging: exfat: drop unused field access_time_ms Valentin Vidic
2019-09-08 17:35 ` [PATCH v3 4/4] staging: exfat: add millisecond support Valentin Vidic
2019-09-09 0:28 ` [PATCH v3 1/4] staging: exfat: drop unused function parameter Valdis Klētnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190908185031.GA10011@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=valdis.kletnieks@vt.edu \
--cc=vvidic@valentin-vidic.from.hr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).