From: kbuild test robot <lkp@intel.com>
To: Adam Zerella <adam.zerella@gmail.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
kbuild-all@01.org, dan.carpenter@oracle.com,
Adam Zerella <adam.zerella@gmail.com>
Subject: Re: [PATCH v2] staging: android: ion: Replace strncpy() for stracpy()
Date: Thu, 12 Sep 2019 04:39:52 +0800 [thread overview]
Message-ID: <201909120431.VwMRWvTs%lkp@intel.com> (raw)
In-Reply-To: <20190910132312.6729-1-adam.zerella@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2521 bytes --]
Hi Adam,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[cannot apply to v5.3-rc8 next-20190904]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Adam-Zerella/staging-android-ion-Replace-strncpy-for-stracpy/20190912-024431
config: sparc64-allmodconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=sparc64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/staging/android/ion/ion.c: In function 'ion_query_heaps':
>> drivers/staging/android/ion/ion.c:470:3: error: implicit declaration of function 'stracpy'; did you mean 'strscpy'? [-Werror=implicit-function-declaration]
stracpy(hdata.name, heap->name);
^~~~~~~
strscpy
cc1: some warnings being treated as errors
vim +470 drivers/staging/android/ion/ion.c
446
447 static int ion_query_heaps(struct ion_heap_query *query)
448 {
449 struct ion_device *dev = internal_dev;
450 struct ion_heap_data __user *buffer = u64_to_user_ptr(query->heaps);
451 int ret = -EINVAL, cnt = 0, max_cnt;
452 struct ion_heap *heap;
453 struct ion_heap_data hdata;
454
455 memset(&hdata, 0, sizeof(hdata));
456
457 down_read(&dev->lock);
458 if (!buffer) {
459 query->cnt = dev->heap_cnt;
460 ret = 0;
461 goto out;
462 }
463
464 if (query->cnt <= 0)
465 goto out;
466
467 max_cnt = query->cnt;
468
469 plist_for_each_entry(heap, &dev->heaps, node) {
> 470 stracpy(hdata.name, heap->name);
471 hdata.type = heap->type;
472 hdata.heap_id = heap->id;
473
474 if (copy_to_user(&buffer[cnt], &hdata, sizeof(hdata))) {
475 ret = -EFAULT;
476 goto out;
477 }
478
479 cnt++;
480 if (cnt >= max_cnt)
481 break;
482 }
483
484 query->cnt = cnt;
485 ret = 0;
486 out:
487 up_read(&dev->lock);
488 return ret;
489 }
490
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 58680 bytes --]
[-- Attachment #3: Type: text/plain, Size: 169 bytes --]
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
prev parent reply other threads:[~2019-09-11 20:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-08 4:34 [PATCH] staging: android: ion: Replace strncpy() for stracpy() Adam Zerella
2019-09-10 11:55 ` Dan Carpenter
2019-09-10 13:23 ` [PATCH v2] " Adam Zerella
2019-09-11 20:39 ` kbuild test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201909120431.VwMRWvTs%lkp@intel.com \
--to=lkp@intel.com \
--cc=adam.zerella@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).