From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sumera Priyadarsini <sylphrenadin@gmail.com>
Cc: devel@driverdev.osuosl.org, Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [RESEND PATCH] staging: rtl8192u: Fix indentation for cleaner code
Date: Wed, 2 Oct 2019 13:44:31 +0300 [thread overview]
Message-ID: <20191002104431.GN29696@kadam> (raw)
In-Reply-To: <CACAkLuqtNGymScoRXKSkf_F3-qc=89za9S34hEwkT8FwH_8ujQ@mail.gmail.com>
On Wed, Oct 02, 2019 at 03:49:04PM +0530, Sumera Priyadarsini wrote:
> On Tue, Sep 24, 2019 at 8:47 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Fri, Sep 13, 2019 at 11:31:01PM +0530, Sumera Priyadarsini wrote:
> > > Fixes indentation for if condition in the file r8190_rtl8256.c for better readability as suggested by Dan Carpenter.
> >
> > Please wrap your lines at 72 columns.
> >
> >
> I will keep this in mind. I was under the impression that the line
> length must be 80 columns
> but will make the change immediately. To be able to wrap the lines,
> maybe code implementation
> needs to be changed slightly as there is a lot of nesting present in
> the current code?
The 72 character limit is for commit messages, not code. Checkpatch.pl
will complain at 75 characters. It's the same rule as email.
regards,
dan carepnter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2019-10-02 10:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 18:01 [RESEND PATCH] staging: rtl8192u: Fix indentation for cleaner code Sumera Priyadarsini
2019-09-24 15:17 ` Greg KH
2019-10-02 10:19 ` Sumera Priyadarsini
2019-10-02 10:44 ` Dan Carpenter [this message]
2019-10-02 11:08 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191002104431.GN29696@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=sylphrenadin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).