From: Wambui Karuga <wambui.karugax@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, outreachy-kernel@googlegroups.com,
linux-kernel@vger.kernel.org, dan.carpenter@oracle.com
Subject: Re: [Outreachy kernel] Re: [PATCH v3 1/4] staging: rtl8723bs: Remove comparisons to NULL in conditionals
Date: Fri, 11 Oct 2019 20:32:38 +0300 [thread overview]
Message-ID: <20191011173238.GA22411@wambui> (raw)
In-Reply-To: <20191011120847.GB1143018@kroah.com>
On Fri, Oct 11, 2019 at 02:08:47PM +0200, Greg KH wrote:
> On Fri, Oct 11, 2019 at 02:07:17PM +0200, Greg KH wrote:
> > On Fri, Oct 11, 2019 at 01:54:04PM +0300, Dan Carpenter wrote:
> > > On Thu, Oct 10, 2019 at 04:15:29PM +0300, Wambui Karuga wrote:
> > > > psetauthparm = rtw_zmalloc(sizeof(struct setauth_parm));
> > > > - if (psetauthparm == NULL) {
> > > > - kfree(pcmd);
> > > > + if (!psetauthparm) {
> > > > + kfree((unsigned char *)pcmd);
> > >
> > > This new cast is unnecessary and weird.
> >
> > Ah, I missed that, good catch. I'll go drop this patch now.
>
> And that caused the second patch to get dropped as well. I'll just drop
> them all, can you redo the whole series please?
>
> thanks,
>
> greg k-h
>
The cast seems to have been removed earlier by Nachammai Karuppiah and
added to staging-testing, but I added it back when I cherry-picked my changes to the new
file.
Sorry. :(
I can remove the cast and send a new series.
Thanks.
wambui karuga
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2019-10-11 17:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 13:15 [PATCH v3 0/4] staging: rtl8723bs: Style clean-up in rtw_mlme.c Wambui Karuga
2019-10-10 13:15 ` [PATCH v3 1/4] staging: rtl8723bs: Remove comparisons to NULL in conditionals Wambui Karuga
2019-10-11 10:54 ` Dan Carpenter
2019-10-11 12:07 ` Greg KH
2019-10-11 12:08 ` Greg KH
2019-10-11 17:32 ` Wambui Karuga [this message]
2019-10-10 13:15 ` [PATCH v3 2/4] staging: rtl8723bs: Remove unnecessary braces for single statements Wambui Karuga
2019-10-10 13:15 ` [PATCH v3 3/4] staging: rtl8723bs: Remove comparisons to booleans in conditionals Wambui Karuga
2019-10-10 13:15 ` [PATCH v3 4/4] staging: rtl8723bs: Remove unnecessary blank lines Wambui Karuga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191011173238.GA22411@wambui \
--to=wambui.karugax@gmail.com \
--cc=20191011120847.GB1143018@kroah.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).