From: Greg KH <gregkh@linuxfoundation.org>
To: Marcelo Diop-Gonzalez <marcgonzalez@google.com>
Cc: devel@driverdev.osuosl.org, eric@anholt.net,
Stefan Wahren <wahrenst@gmx.net>,
linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] staging: vchiq: Move retrieval of rpi_firmware to vchiq_platform_init()
Date: Wed, 13 Nov 2019 06:32:32 +0100 [thread overview]
Message-ID: <20191113053232.GA2036664@kroah.com> (raw)
In-Reply-To: <CAKvFj6pA9aR5DP6L63252aWUmcAX_1tnwu6-O0dZTWXGYt8YLA@mail.gmail.com>
On Tue, Nov 12, 2019 at 06:29:55PM -0500, Marcelo Diop-Gonzalez wrote:
> On Tue, Nov 12, 2019 at 6:09 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Mon, Nov 11, 2019 at 12:14:23PM -0500, Marcelo Diop-Gonzalez wrote:
> > > This allows the removal of the struct rpi_firmware* member
> > > from struct vchiq_drvdata.
> > >
> > > Signed-off-by: Marcelo Diop-Gonzalez <marcgonzalez@google.com>
> > > ---
> > > .../interface/vchiq_arm/vchiq_2835_arm.c | 14 +++++++++++++-
> > > .../vc04_services/interface/vchiq_arm/vchiq_arm.c | 14 --------------
> > > .../vc04_services/interface/vchiq_arm/vchiq_arm.h | 1 -
> > > 3 files changed, 13 insertions(+), 16 deletions(-)
> >
> > This commit breaks the build:
> >
> > In function ‘free_pagelist’,
> > inlined from ‘vchiq_complete_bulk’ at drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c:258:3:
> > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c:588:4: warning: argument 2 null where non-null expected [-Wnonnull]
> > 588 | memcpy((char *)kmap(pages[0]) +
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > 589 | pagelist->offset,
> > | ~~~~~~~~~~~~~~~~~
> > 590 | fragments,
> > | ~~~~~~~~~~
> > 591 | head_bytes);
> > | ~~~~~~~~~~~
> >
> > Please be more careful and at least test your changes before sending
> > them out :(
>
> Ah sorry :(((. Could you let me know what config you saw that error
> with? I see no warnings/errors with bcm2835_defconfig.
I'm just building on x86-64, try 'allmodconfig' on your desktop and see
what happens.
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2019-11-13 5:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 17:14 [PATCH 0/2] Remove global struct vchiq_drvdata variables Marcelo Diop-Gonzalez
2019-11-11 17:14 ` [PATCH 1/2] staging: vchiq: Move retrieval of rpi_firmware to vchiq_platform_init() Marcelo Diop-Gonzalez
2019-11-12 23:09 ` Greg KH
2019-11-12 23:29 ` Marcelo Diop-Gonzalez
2019-11-13 5:32 ` Greg KH [this message]
2019-11-13 14:08 ` Marcelo Diop-Gonzalez
2019-11-13 20:29 ` Marcelo Diop-Gonzalez
2019-11-13 18:17 ` Dan Carpenter
2019-11-13 19:58 ` Marcelo Diop-Gonzalez
2019-11-11 17:14 ` [PATCH 2/2] staging: vchiq: Remove global bcm*_drvdata Marcelo Diop-Gonzalez
2019-11-13 18:18 ` Dan Carpenter
2019-11-13 18:40 ` Stefan Wahren
2019-11-13 19:56 ` Marcelo Diop-Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191113053232.GA2036664@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=eric@anholt.net \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=marcgonzalez@google.com \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).