From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: devel@driverdev.osuosl.org, Julia Lawall <julia.lawall@lip6.fr>,
linux-kernel@vger.kernel.org,
Wambui Karuga <wambui.karugax@gmail.com>
Subject: Re: [PATCH] staging/octeon: Mark Ethernet driver as BROKEN
Date: Mon, 2 Dec 2019 17:52:31 +0100 [thread overview]
Message-ID: <20191202165231.GA728202@kroah.com> (raw)
In-Reply-To: <20191202141836.9363-1-linux@roeck-us.net>
On Mon, Dec 02, 2019 at 06:18:36AM -0800, Guenter Roeck wrote:
> The code doesn't compile due to incompatible pointer errors such as
>
> drivers/staging/octeon/ethernet-tx.c:649:50: error:
> passing argument 1 of 'cvmx_wqe_get_grp' from incompatible pointer type
>
> This is due to mixing, for example, cvmx_wqe_t with 'struct cvmx_wqe'.
>
> Unfortunately, one can not just revert the primary offending commit, as doing so
> results in secondary errors. This is made worse by the fact that the "removed"
> typedefs still exist and are used widely outside the staging directory,
> making the entire set of "remove typedef" changes pointless and wrong.
Ugh, sorry about that.
> Reflect reality and mark the driver as BROKEN.
Should I just delete this thing? No one seems to be using it and there
is no move to get it out of staging at all.
Will anyone actually miss it? It can always come back of someone
does...
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2019-12-02 16:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 14:18 [PATCH] staging/octeon: Mark Ethernet driver as BROKEN Guenter Roeck
2019-12-02 16:52 ` Greg Kroah-Hartman [this message]
2019-12-02 17:36 ` Guenter Roeck
2019-12-02 18:15 ` Greg Kroah-Hartman
2020-02-04 0:54 ` Chris Packham
2020-02-04 7:36 ` gregkh
2020-02-04 20:03 ` Chris Packham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191202165231.GA728202@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wambui.karugax@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).