From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: most: remove header include path to drivers/staging
Date: Sat, 4 Jan 2020 19:11:17 +0100 [thread overview]
Message-ID: <20200104181117.GA1479922@kroah.com> (raw)
In-Reply-To: <20200104161827.18960-1-masahiroy@kernel.org>
On Sun, Jan 05, 2020 at 01:18:27AM +0900, Masahiro Yamada wrote:
> There is no need to add "ccflags-y += -I $(srctree)/drivers/staging"
> just for including <most/core.h>.
>
> Use the #include "..." directive with the correct relative path.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> drivers/staging/most/Makefile | 1 -
> drivers/staging/most/cdev/Makefile | 1 -
> drivers/staging/most/cdev/cdev.c | 3 ++-
> drivers/staging/most/configfs.c | 3 ++-
> drivers/staging/most/core.c | 3 ++-
> drivers/staging/most/dim2/Makefile | 1 -
> drivers/staging/most/dim2/dim2.c | 2 +-
> drivers/staging/most/i2c/Makefile | 1 -
> drivers/staging/most/i2c/i2c.c | 2 +-
> drivers/staging/most/net/Makefile | 1 -
> drivers/staging/most/net/net.c | 3 ++-
> drivers/staging/most/sound/Makefile | 1 -
> drivers/staging/most/sound/sound.c | 3 ++-
> drivers/staging/most/usb/Makefile | 1 -
> drivers/staging/most/usb/usb.c | 3 ++-
> drivers/staging/most/video/Makefile | 1 -
> drivers/staging/most/video/video.c | 2 +-
> 17 files changed, 15 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/staging/most/Makefile b/drivers/staging/most/Makefile
> index 85ea5a434ced..20a99ecb37c4 100644
> --- a/drivers/staging/most/Makefile
> +++ b/drivers/staging/most/Makefile
> @@ -2,7 +2,6 @@
> obj-$(CONFIG_MOST) += most_core.o
> most_core-y := core.o
> most_core-y += configfs.o
> -ccflags-y += -I $(srctree)/drivers/staging/
>
> obj-$(CONFIG_MOST_CDEV) += cdev/
> obj-$(CONFIG_MOST_NET) += net/
This all was done on purpose to make a follow-on patch much simpler that
I didn't end up taking as it still needed more work.
But I do agree with it, we shouldn't be abusing ccflags here, I'll go
queue this up in a day or so, thanks for this.
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-01-04 18:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-04 16:18 [PATCH] staging: most: remove header include path to drivers/staging Masahiro Yamada
2020-01-04 18:11 ` Greg Kroah-Hartman [this message]
2020-01-14 15:21 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200104181117.GA1479922@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).