From: Dan Carpenter <dan.carpenter@oracle.com>
To: Felipe Cardoso Resende <felipecardoso.fcr@gmail.com>
Cc: devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Geordan Neukum <gneukum1@gmail.com>,
Hao Xu <haoxu.linuxkernel@gmail.com>,
Jamal Shareef <jamal.k.shareef@gmail.com>
Subject: Re: [PATCH] Remove warning: "dubious: x | !y" detected by sparse
Date: Wed, 15 Jan 2020 09:21:56 +0300 [thread overview]
Message-ID: <20200115062156.GF3719@kadam> (raw)
In-Reply-To: <20200115012515.GA16012@felipe-pc>
Add a subsystem prefix to the subject. "Staging: kpc2000:"
On Tue, Jan 14, 2020 at 10:25:15PM -0300, Felipe Cardoso Resende wrote:
> The way I chose to remove the warning was to define a macro to
> make it clear if a flag will be enable or not.
>
> Let me know if you would prefer it to be done in a different way.
>
All this should go under the --- cut off because we don't want it in the
final git history.
> Signed-off-by: Felipe Cardoso Resende <felipecardoso.fcr@gmail.com>
> ---
^^^
The commit message should be something like. "Sparse complains about
"dubious: x | !y". This patch adds some macros to make Sparse happy and
the code more readable.
I like the patch. enable_flag_if() is slightly weird because normally
the condition would come first. It feels sort of like Perl or something
to put the condition afterwards. But this patch is very small and self
contained so it's fine.
Just fix up the subject and the commit message and resend.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-01-15 6:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 1:25 [PATCH] Remove warning: "dubious: x | !y" detected by sparse Felipe Cardoso Resende
2020-01-15 6:21 ` Dan Carpenter [this message]
2020-01-16 3:05 ` Felipe Cardoso Resende
2020-01-16 6:12 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200115062156.GF3719@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=felipecardoso.fcr@gmail.com \
--cc=gneukum1@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=haoxu.linuxkernel@gmail.com \
--cc=jamal.k.shareef@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).