DriverDev-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: Rob Herring <robh@kernel.org>
To: Ajay.Kathat@microchip.com
Cc: devel@driverdev.osuosl.org, devicetree@vger.kernel.org,
	Venkateswara.Kaja@microchip.com, gregkh@linuxfoundation.org,
	linux-wireless@vger.kernel.org, Nicolas.Ferre@microchip.com,
	Adham.Abozaeid@microchip.com, johannes@sipsolutions.net
Subject: Re: [PATCH v5 16/17] dt: bindings: net: add microchip,wilc1000.yaml
Date: Fri, 20 Mar 2020 11:59:20 -0600
Message-ID: <20200320175920.GA31641@bogus> (raw)
In-Reply-To: <20200311121809.5610-17-ajay.kathat@microchip.com>

On Wed, Mar 11, 2020 at 12:18:50PM +0000, Ajay.Kathat@microchip.com wrote:
> From: Ajay Singh <ajay.kathat@microchip.com>
> 
> This file describes the binding details to connect wilc1000 device. It's
> moved from staging to 'Documentation/devicetree/bindings/net/wireless'
> path.
> 
> Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
> ---
>  .../net/wireless/microchip,wilc1000.yaml      | 72 +++++++++++++++++++
>  1 file changed, 72 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml
> 
> diff --git a/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml b/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml
> new file mode 100644
> index 000000000000..bc6cc5d3f347
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.yaml
> @@ -0,0 +1,72 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/wireless/microchip,wilc1000.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Microchip WILC wireless devicetree bindings
> +
> +maintainers:
> +  - Adham Abozaeid <adham.abozaeid@microchip.com>
> +  - Ajay Singh <ajay.kathat@microchip.com>
> +
> +description:
> +  The wilc1000 chips can be connected via SPI or SDIO. This document
> +  describes the binding to connect wilc devices.
> +
> +properties:
> +  compatible:
> +    const: microchip,wilc1000
> +
> +  spi-max-frequency: true
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clocks:
> +    description: phandle to the clock connected on rtc clock line.
> +    maxItems: 1
> +
> +  clock-names:
> +    const: rtc
> +
> +required:
> +  - compatible
> +  - interrupts
> +
> +examples:
> +  - |
> +    spi1: spi@fc018000 {

spi {

> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +      cs-gpios = <&pioB 21 0>;

Drop this. Not relevant to the example.

> +      wifi@0 {
> +        compatible = "microchip,wilc1000";
> +        spi-max-frequency = <48000000>;
> +        reg = <0>;
> +        interrupt-parent = <&pioC>;
> +        interrupts = <27 0>;
> +        clocks = <&pck1>;
> +        clock-names = "rtc";
> +      };
> +    };
> +
> +  - |
> +    mmc1: mmc@fc000000 {

Drop the label. Either drop the unit address or add a 'reg' property to 
match.

> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +      pinctrl-names = "default";
> +      pinctrl-0 = <&pinctrl_mmc1_clk_cmd_dat0 &pinctrl_mmc1_dat1_3>;
> +      non-removable;
> +      vmmc-supply = <&vcc_mmc1_reg>;
> +      vqmmc-supply = <&vcc_3v3_reg>;
> +      bus-width = <4>;
> +      wifi@0 {
> +        compatible = "microchip,wilc1000";
> +        reg = <0>;
> +        interrupt-parent = <&pioC>;
> +        interrupts = <27 0>;
> +        clocks = <&pck1>;
> +        clock-names = "rtc";
> +      };
> +    };
> -- 
> 2.24.0
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply index

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-11 12:18 [PATCH v5 00/17] wilc1000: move out of staging Ajay.Kathat
2020-03-11 12:18 ` [PATCH v5 01/17] wilc1000: add hif.h Ajay.Kathat
2020-03-11 12:18 ` [PATCH v5 02/17] wilc1000: add hif.c Ajay.Kathat
2020-03-11 12:18 ` [PATCH v5 03/17] wilc1000: add wlan_if.h Ajay.Kathat
2020-03-11 12:18 ` [PATCH v5 04/17] wilc1000: add wlan_cfg.h Ajay.Kathat
2020-03-11 12:18 ` [PATCH v5 05/17] wilc1000: add wlan_cfg.c Ajay.Kathat
2020-03-11 12:18 ` [PATCH v5 06/17] wilc1000: add cfg80211.c Ajay.Kathat
2020-03-11 12:18 ` [PATCH v5 07/17] wilc1000: add cfg80211.h Ajay.Kathat
2020-03-11 12:18 ` [PATCH v5 08/17] wilc1000: add netdev.h Ajay.Kathat
2020-03-11 12:18 ` [PATCH v5 09/17] wilc1000: add netdev.c Ajay.Kathat
2020-03-11 12:18 ` [PATCH v5 11/17] wilc1000: add spi.c Ajay.Kathat
2020-03-11 12:18 ` [PATCH v5 10/17] wilc1000: add mon.c Ajay.Kathat
2020-03-11 12:18 ` [PATCH v5 12/17] wilc1000: add wlan.h Ajay.Kathat
2020-03-11 12:18 ` [PATCH v5 14/17] wilc1000: add sdio.c Ajay.Kathat
2020-03-11 12:18 ` [PATCH v5 13/17] wilc1000: add wlan.c Ajay.Kathat
2020-03-11 12:18 ` [PATCH v5 16/17] dt: bindings: net: add microchip,wilc1000.yaml Ajay.Kathat
2020-03-20 17:59   ` Rob Herring [this message]
2020-03-23  5:07     ` Ajay.Kathat
2020-03-11 12:18 ` [PATCH v5 15/17] wilc1000: add fw.h Ajay.Kathat
2020-03-11 12:18 ` [PATCH v5 17/17] wilc1000: add Makefile and Kconfig files for wilc1000 compilation Ajay.Kathat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200320175920.GA31641@bogus \
    --to=robh@kernel.org \
    --cc=Adham.Abozaeid@microchip.com \
    --cc=Ajay.Kathat@microchip.com \
    --cc=Nicolas.Ferre@microchip.com \
    --cc=Venkateswara.Kaja@microchip.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DriverDev-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/driverdev-devel/0 driverdev-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 driverdev-devel driverdev-devel/ https://lore.kernel.org/driverdev-devel \
		driverdev-devel@linuxdriverproject.org devel@driverdev.osuosl.org
	public-inbox-index driverdev-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.linuxdriverproject.driverdev-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git