From: Quentin Deslandes <quentin.deslandes@itdev.co.uk>
To: "John B. Wyatt IV" <jbwyatt4@gmail.com>
Cc: devel@driverdev.osuosl.org, Oscar Carter <oscar.carter@gmx.com>,
Malcolm Priestley <tvboxspy@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Julia Lawall <julia.lawall@inria.fr>,
outreachy-kernel@googlegroups.com,
Forest Bond <forest@alittletooquiet.net>,
Colin Ian King <colin.king@canonical.com>
Subject: Re: [PATCH 1/2] staging: vt6656: remove unneeded variable: ret
Date: Tue, 24 Mar 2020 10:03:23 +0000 [thread overview]
Message-ID: <20200324100323.GB7693@jiffies> (raw)
In-Reply-To: <20200324064545.1832227-2-jbwyatt4@gmail.com>
On 03/23/20 23:45:44, John B. Wyatt IV wrote:
> vnt_mac_reg_bits_off(priv, MAC_REG_GPIOCTL1, GPIO3_INTMD);
This function, and all the functions called in vnt_radio_power_on() returns
a value, why don't you catch it and act accordingly (forward error code
for example) instead of silencing it?
Thanks,
Quentin
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-03-24 10:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 6:45 [PATCH 0/2] staging: vt6656: change function from always returning 0 to void John B. Wyatt IV
2020-03-24 6:45 ` [PATCH 1/2] staging: vt6656: remove unneeded variable: ret John B. Wyatt IV
2020-03-24 10:03 ` Quentin Deslandes [this message]
2020-03-24 6:45 ` [PATCH 2/2] staging: vt6656: change unused int return value to void John B. Wyatt IV
2020-03-24 17:28 ` [PATCH 0/2] staging: vt6656: change function from always returning 0 " Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200324100323.GB7693@jiffies \
--to=quentin.deslandes@itdev.co.uk \
--cc=colin.king@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=jbwyatt4@gmail.com \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=oscar.carter@gmx.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).