From: Greg KH <gregkh@linuxfoundation.org>
To: Anmol karn <anmol.karan123@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: android: ashmem: Fixed a issue related to file_operations
Date: Fri, 15 May 2020 10:04:46 +0200 [thread overview]
Message-ID: <20200515080446.GA1398375@kroah.com> (raw)
In-Reply-To: <CAC+yH-boJnUbnhkLdkZ3Vj8_1D0OMBLKsBYbrcJ2sr29_ekeJQ@mail.gmail.com>
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Fri, May 15, 2020 at 01:16:12PM +0530, Anmol karn wrote:
> Hello sir,
> Thank you for your response,
>
> Did you properly build this change?
>
>
> I have build the *linux_stable* according to the LFD103 course (By Linux
> Foundation) and the kernel they used in their tutorial was *5.2.21 *so, my
> question is can I use this kernel for the patch or do I need to switch to
> the recent mainline kernel release. Because in the recent patch I have used
> *5.2.21.*
Working on a 6 month old kernel is not going to help at all, you need to
work on the latest tree at the least. linux-next is best. Otherwise
you end up making changes that can not be applied, or have already been
done by others, which is just a waste of time.
But what I asked is if you actually test built the change you made. As
the kbuild bot showed you, you obviously did not :(
Please always do that, you can not add new warnings to the kernel, nor
break the build with any change.
Also work on your knowledge of C before doing more kernel work, as the
change is not correct for the obvious reasons that it is not allowed by
the language. checkpatch is just a perl script, sometimes it give
incorrect information, like this time.
> Also, always use your full name for kernel changes, as the Documentation
> > states to.
>
>
> Sir, my legal full name is 'Anmol' only.
That does not match what your email "From:" says :)
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-05-15 8:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 11:41 [PATCH] staging: android: ashmem: Fixed a issue related to file_operations Anmol
2020-05-13 12:02 ` Greg KH
[not found] ` <CAC+yH-boJnUbnhkLdkZ3Vj8_1D0OMBLKsBYbrcJ2sr29_ekeJQ@mail.gmail.com>
2020-05-15 8:04 ` Greg KH [this message]
2020-05-13 16:44 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200515080446.GA1398375@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=anmol.karan123@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).