From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Anant Thazhemadam <anant.thazhemadam@gmail.com>
Cc: devel@driverdev.osuosl.org,
syzbot+009f546aa1370056b1c2@syzkaller.appspotmail.com,
Ian Abbott <abbotti@mev.co.uk>,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: comedi: check validity of wMaxPacketSize of usb endpoints found
Date: Sat, 10 Oct 2020 09:00:08 +0200 [thread overview]
Message-ID: <20201010070007.GB132110@kroah.com> (raw)
In-Reply-To: <20201009162030.293781-1-anant.thazhemadam@gmail.com>
On Fri, Oct 09, 2020 at 09:50:29PM +0530, Anant Thazhemadam wrote:
> While finding usb endpoints in vmk80xx_find_usb_endpoints(), check if
> wMaxPacketSize = 0 for the endpoints found.
>
> Some devices have isochronous endpoints that have wMaxPacketSize = 0
> (as required by the USB-2 spec).
> However, since this doesn't apply here, wMaxPacketSize = 0 can be
> considered to be invalid.
>
> Reported-by: syzbot+009f546aa1370056b1c2@syzkaller.appspotmail.com
> Tested-by: syzbot+009f546aa1370056b1c2@syzkaller.appspotmail.com
> Signed-off-by: Anant Thazhemadam <anant.thazhemadam@gmail.com>
> ---
You sent 2 patches with the same subject, which one is the "latest" one?
Please always version your patches and put below the --- line what
changed from the previous version, so that maintainers have a chance to
know which to accept...
Can you fix this up and send a v3?
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-10-10 7:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 16:20 [PATCH] staging: comedi: check validity of wMaxPacketSize of usb endpoints found Anant Thazhemadam
2020-10-10 7:00 ` Greg Kroah-Hartman [this message]
2020-10-10 1:59 ` Anant Thazhemadam
2020-10-10 8:09 ` Greg Kroah-Hartman
2020-10-10 8:26 ` Anant Thazhemadam
-- strict thread matches above, loose matches on Subject: below --
2020-10-09 16:16 Anant Thazhemadam
2020-10-09 16:24 ` Anant Thazhemadam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201010070007.GB132110@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=abbotti@mev.co.uk \
--cc=anant.thazhemadam@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+009f546aa1370056b1c2@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).