From: Dan Carpenter <dan.carpenter@oracle.com>
To: Greg KH <greg@kroah.com>
Cc: devel@driverdev.osuosl.org, f.fainelli@gmail.com,
sbranden@broadcom.com, rjui@broadcom.com,
speakup@linux-speakup.org, linux-kernel@vger.kernel.org,
rcy@google.com, toddpoynor@google.com, rspringer@google.com,
laurent.pinchart@ideasonboard.com, netdev@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com, mchehab@kernel.org,
"Enrico Weigelt, metux IT consult" <info@metux.net>,
nsaenzjulienne@suse.de, linux-media@vger.kernel.org
Subject: Re: [PATCH 01/11] drivers: staging: speakup: remove unneeded MODULE_VERSION() call
Date: Thu, 3 Dec 2020 16:56:40 +0300 [thread overview]
Message-ID: <20201203135640.GS2767@kadam> (raw)
In-Reply-To: <X8jnO5cPUQGEK9cr@kroah.com>
On Thu, Dec 03, 2020 at 02:25:15PM +0100, Greg KH wrote:
> On Thu, Dec 03, 2020 at 01:47:53PM +0100, Enrico Weigelt, metux IT consult wrote:
> > Remove MODULE_VERSION(), as it doesn't seem to serve any practical
> > purpose. For in-tree drivers, the kernel version matters.
> >
> > The drivers have received lots of changes, without the module version
> > (or the underlying DRV_VERSION macro) ever changed, since the code
> > landed in the kernel tree. So, it doesn't seem to have any practical
> > meaning anymore.
> >
> > Signed-off-by: Enrico Weigelt <info@metux.net>
> > ---
> > drivers/accessibility/speakup/main.c | 1 -
>
> <snip>
>
> Yous subject line is odd, these are not "staging" drivers anymore, so
> why do you say they are there?
Also putting "drivers:" in the subject always seems superfluous.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
prev parent reply other threads:[~2020-12-03 13:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 12:47 [PATCH 01/11] drivers: staging: speakup: remove unneeded MODULE_VERSION() call Enrico Weigelt, metux IT consult
2020-12-03 12:47 ` [PATCH 02/11] drivers: staging: gasket: " Enrico Weigelt, metux IT consult
2020-12-03 12:47 ` [PATCH 03/11] drivers: staging: gdm724x: " Enrico Weigelt, metux IT consult
2020-12-03 12:47 ` [PATCH 04/11] drivers: staging: goldfish: " Enrico Weigelt, metux IT consult
2020-12-04 15:47 ` Greg KH
2020-12-03 12:47 ` [PATCH 05/11] drivers: staging: media: " Enrico Weigelt, metux IT consult
2020-12-03 12:47 ` [PATCH 06/11] drivers: staging: qlge: " Enrico Weigelt, metux IT consult
2020-12-03 12:47 ` [PATCH 07/11] drivers: staging: vc04_services: " Enrico Weigelt, metux IT consult
2020-12-03 12:48 ` [PATCH 08/11] drivers: staging: rtl8188eu: " Enrico Weigelt, metux IT consult
2020-12-03 12:48 ` [PATCH 09/11] drivers: staging: rtl8192e: " Enrico Weigelt, metux IT consult
2020-12-03 12:48 ` [PATCH 10/11] drivers: staging: rtl8723bs: " Enrico Weigelt, metux IT consult
2020-12-03 12:48 ` [PATCH 11/11] " Enrico Weigelt, metux IT consult
2020-12-03 13:25 ` [PATCH 01/11] drivers: staging: speakup: " Greg KH
2020-12-03 13:56 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201203135640.GS2767@kadam \
--to=dan.carpenter@oracle.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devel@driverdev.osuosl.org \
--cc=f.fainelli@gmail.com \
--cc=greg@kroah.com \
--cc=info@metux.net \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nsaenzjulienne@suse.de \
--cc=rcy@google.com \
--cc=rjui@broadcom.com \
--cc=rspringer@google.com \
--cc=sbranden@broadcom.com \
--cc=speakup@linux-speakup.org \
--cc=toddpoynor@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).