From: Philipp Gerlesberger <Philipp.Gerlesberger@fau.de>
To: linux-kernel@vger.kernel.org
Cc: devel@driverdev.osuosl.org, linux-kernel@i4.cs.fau.de,
gregkh@linuxfoundation.org,
ij72uhux@stud.informatik.uni-erlangen.de,
Philipp Gerlesberger <Philipp.Gerlesberger@fau.de>,
sakari.ailus@linux.intel.com, mchehab@kernel.org,
linux-media@vger.kernel.org
Subject: [PATCH 11/12] media: atomisp: Write function decleration in one line
Date: Mon, 7 Dec 2020 20:26:38 +0100 [thread overview]
Message-ID: <20201207192638.15219-12-Philipp.Gerlesberger@fau.de> (raw)
In-Reply-To: <20201207192638.15219-1-Philipp.Gerlesberger@fau.de>
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
WARNING:LEADING_SPACE: please, no spaces at the start of a line
Avoid these errors by writing the function decleration in one line.
Co-developed-by: Andrey Khlopkov <ij72uhux@stud.informatik.uni-erlangen.de>
Signed-off-by: Andrey Khlopkov <ij72uhux@stud.informatik.uni-erlangen.de>
Signed-off-by: Philipp Gerlesberger <Philipp.Gerlesberger@fau.de>
---
.../atomisp/pci/runtime/queue/src/queue.c | 44 +++++--------------
1 file changed, 11 insertions(+), 33 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c
index aea6c66a3cee..2f1c2df59f71 100644
--- a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c
+++ b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c
@@ -22,9 +22,7 @@
/*****************************************************************************
* Queue Public APIs
*****************************************************************************/
-int ia_css_queue_local_init(
- ia_css_queue_t *qhandle,
- ia_css_queue_local_t *desc)
+int ia_css_queue_local_init(ia_css_queue_t *qhandle, ia_css_queue_local_t *desc)
{
if (NULL == qhandle || NULL == desc
|| NULL == desc->cb_elems || NULL == desc->cb_desc) {
@@ -43,9 +41,7 @@ int ia_css_queue_local_init(
return 0;
}
-int ia_css_queue_remote_init(
- ia_css_queue_t *qhandle,
- ia_css_queue_remote_t *desc)
+int ia_css_queue_remote_init(ia_css_queue_t *qhandle, ia_css_queue_remote_t *desc)
{
if (NULL == qhandle || NULL == desc) {
/* Invalid parameters, return error*/
@@ -69,8 +65,7 @@ int ia_css_queue_remote_init(
return 0;
}
-int ia_css_queue_uninit(
- ia_css_queue_t *qhandle)
+int ia_css_queue_uninit(ia_css_queue_t *qhandle)
{
if (!qhandle)
return -EINVAL;
@@ -84,9 +79,7 @@ int ia_css_queue_uninit(
return 0;
}
-int ia_css_queue_enqueue(
- ia_css_queue_t *qhandle,
- uint32_t item)
+int ia_css_queue_enqueue(ia_css_queue_t *qhandle, uint32_t item)
{
int error = 0;
@@ -143,9 +136,7 @@ int ia_css_queue_enqueue(
return 0;
}
-int ia_css_queue_dequeue(
- ia_css_queue_t *qhandle,
- uint32_t *item)
+int ia_css_queue_dequeue(ia_css_queue_t *qhandle, uint32_t *item)
{
int error = 0;
@@ -200,9 +191,7 @@ int ia_css_queue_dequeue(
return 0;
}
-int ia_css_queue_is_full(
- ia_css_queue_t *qhandle,
- bool *is_full)
+int ia_css_queue_is_full(ia_css_queue_t *qhandle, bool *is_full)
{
int error = 0;
@@ -234,9 +223,7 @@ int ia_css_queue_is_full(
return -EINVAL;
}
-int ia_css_queue_get_free_space(
- ia_css_queue_t *qhandle,
- uint32_t *size)
+int ia_css_queue_get_free_space(ia_css_queue_t *qhandle, uint32_t *size)
{
int error = 0;
@@ -268,9 +255,7 @@ int ia_css_queue_get_free_space(
return -EINVAL;
}
-int ia_css_queue_get_used_space(
- ia_css_queue_t *qhandle,
- uint32_t *size)
+int ia_css_queue_get_used_space(ia_css_queue_t *qhandle, uint32_t *size)
{
int error = 0;
@@ -302,10 +287,7 @@ int ia_css_queue_get_used_space(
return -EINVAL;
}
-int ia_css_queue_peek(
- ia_css_queue_t *qhandle,
- u32 offset,
- uint32_t *element)
+int ia_css_queue_peek(ia_css_queue_t *qhandle, u32 offset, uint32_t *element)
{
u32 num_elems = 0;
int error = 0;
@@ -354,9 +336,7 @@ int ia_css_queue_peek(
return -EINVAL;
}
-int ia_css_queue_is_empty(
- ia_css_queue_t *qhandle,
- bool *is_empty)
+int ia_css_queue_is_empty(ia_css_queue_t *qhandle, bool *is_empty)
{
int error = 0;
@@ -388,9 +368,7 @@ int ia_css_queue_is_empty(
return -EINVAL;
}
-int ia_css_queue_get_size(
- ia_css_queue_t *qhandle,
- uint32_t *size)
+int ia_css_queue_get_size(ia_css_queue_t *qhandle, uint32_t *size)
{
int error = 0;
--
2.20.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-12-07 19:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 19:26 [PATCH 00/12] media: atomisp: Codingstyle Philipp Gerlesberger
2020-12-07 19:26 ` [PATCH 01/12] media: atomsip: Convert comments to C99 initializers Philipp Gerlesberger
2020-12-08 10:21 ` Dan Carpenter
2020-12-07 19:26 ` [PATCH 02/12] media: atomisp: Fix Block Comments Philipp Gerlesberger
2020-12-07 19:26 ` [PATCH 03/12] media: atomisp: Fix EMBEDDED_FUNCTION_NAME warning Philipp Gerlesberger
2020-12-07 19:26 ` [PATCH 04/12] media: atomisp: Fix OPEN_ENDED_LINE Philipp Gerlesberger
2020-12-07 19:26 ` [PATCH 05/12] media: atomisp: Fix overlong line Philipp Gerlesberger
2020-12-07 19:26 ` [PATCH 06/12] media: atomisp: Add parentheses Philipp Gerlesberger
2020-12-08 11:30 ` Dan Carpenter
2020-12-07 19:26 ` [PATCH 07/12] media: atomisp: Fix funciton decleration Philipp Gerlesberger
2020-12-07 19:26 ` [PATCH 08/12] media: atomisp: Delete braces Philipp Gerlesberger
2020-12-07 19:26 ` [PATCH 09/12] media: atomisp: Fix PARENTHESIS_ALIGNMENT Philipp Gerlesberger
2020-12-07 19:26 ` [PATCH 10/12] media: atomisp: Fix BLOCK_COMMENT_STYLE Philipp Gerlesberger
2020-12-07 19:26 ` Philipp Gerlesberger [this message]
2020-12-07 19:26 ` [PATCH 12/12] media: atomisp: Fix LOGICAL_CONTINUATIONS Philipp Gerlesberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201207192638.15219-12-Philipp.Gerlesberger@fau.de \
--to=philipp.gerlesberger@fau.de \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=ij72uhux@stud.informatik.uni-erlangen.de \
--cc=linux-kernel@i4.cs.fau.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).