From: Ivan Safonov <insafonov@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sanjana Sanikommu <sanjana99reddy99@gmail.com>,
Colin Ian King <colin.king@canonical.com>,
Vatsala Narang <vatsalanarang@gmail.com>,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH] r8188eu: use skb_put_data instead of skb_put/memcpy pair
Date: Sat, 31 Aug 2019 20:30:16 +0300 [thread overview]
Message-ID: <33548df8-6eb3-0ce6-d37e-1b4b79b0dcfc@gmail.com> (raw)
In-Reply-To: <20190827103134.GC23584@kadam>
On 8/27/19 1:31 PM, Dan Carpenter wrote:
> On Sun, Aug 25, 2019 at 11:48:58PM +0300, Ivan Safonov wrote:
>> skb_put_data is shorter and clear.
>>
>
> Please don't start the commit message in the middle of a sentence. It
> often gets split from the start of the sentence. See how it looks here.
> https://marc.info/?l=linux-driver-devel&m=156676594611401&w=2
>
>
>> Signed-off-by: Ivan Safonov <insafonov@gmail.com>
>> ---
>> drivers/staging/rtl8188eu/core/rtw_recv.c | 6 +-----
>> drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 3 +--
>> 2 files changed, 2 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c
>> b/drivers/staging/rtl8188eu/core/rtw_recv.c
>> index 620da6c003d8..d4278361e002 100644
>> --- a/drivers/staging/rtl8188eu/core/rtw_recv.c
>> +++ b/drivers/staging/rtl8188eu/core/rtw_recv.c
>> @@ -1373,11 +1373,7 @@ static struct recv_frame *recvframe_defrag(struct
>> adapter *adapter,
>> /* append to first fragment frame's tail (if privacy frame,
>> pull the ICV) */
>> skb_trim(prframe->pkt, prframe->pkt->len -
>> prframe->attrib.icv_len);
>
>
> Your email client corrupted the patch so it can't be applied.
Thanks, Dan.
>
> regards,
> dan carpenter
>
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
parent reply other threads:[~2019-08-31 17:27 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20190827103134.GC23584@kadam>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33548df8-6eb3-0ce6-d37e-1b4b79b0dcfc@gmail.com \
--to=insafonov@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=colin.king@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sanjana99reddy99@gmail.com \
--cc=vatsalanarang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).