From: Kalle Valo <kvalo@codeaurora.org>
To: Jerome Pouiller <Jerome.Pouiller@silabs.com>
Cc: devel@driverdev.osuosl.org, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH 00/10] staging: wfx: introduce nl80211 vendor extensions
Date: Wed, 27 May 2020 15:34:37 +0300 [thread overview]
Message-ID: <87imghv9nm.fsf@codeaurora.org> (raw)
In-Reply-To: <20200526171821.934581-1-Jerome.Pouiller@silabs.com> (Jerome Pouiller's message of "Tue, 26 May 2020 19:18:11 +0200")
Jerome Pouiller <Jerome.Pouiller@silabs.com> writes:
> This series introduces some nl80211 vendor extensions to the wfx driver.
>
> This series may lead to some discussions:
>
> 1. Patch 7 allows to change the dynamic PS timeout. I have found
> an API in wext (cfg80211_wext_siwpower()) that do more or less the
> same thing. However, I have not found any equivalent in nl80211. Is it
> expected or this API should be ported to nl80211?
struct wireless_dev::ps_timeout doesn't work for you?
>
> 2. The device The device allows to do Packet Traffic Arbitration (PTA or
> also Coex). This feature allows the device to communicate with another
> RF device in order to share the access to the RF. The patch 9 provides
> a way to configure that. However, I think that this chip is not the
> only one to provide this feature. Maybe a standard way to change
> these parameters should be provided?
>
> 3. For these vendor extensions, I have used the new policy introduced by
> the commit 901bb989185516 ("nl80211: require and validate vendor
> command policy"). However, it seems that my version of 'iw' is not
> able to follow this new policy (it does not pack the netlink
> attributes into a NLA_NESTED). I could develop a tool specifically for
> that API, but it is not very handy. So, in patch 10, I have also
> introduced an API for compatibility with iw. Any comments about this?
If you want the driver out of staging I recommend not adding any vendor
commands until the driver is moved to drivers/net/wireless. Also do note
that we have special rules for nl80211 vendor commands:
https://wireless.wiki.kernel.org/en/developers/documentation/nl80211#vendor-specific_api
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-05-27 12:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 17:18 [PATCH 00/10] staging: wfx: introduce nl80211 vendor extensions Jerome Pouiller
2020-05-26 17:18 ` [PATCH 01/10] staging: wfx: drop unused variable Jerome Pouiller
2020-05-26 17:18 ` [PATCH 02/10] staging: wfx: do not declare variables inside loops Jerome Pouiller
2020-05-26 17:18 ` [PATCH 03/10] staging: wfx: drop unused function wfx_pending_requeue() Jerome Pouiller
2020-05-26 17:18 ` [PATCH 04/10] staging: wfx: add support for tx_power_loop Jerome Pouiller
2020-05-26 17:18 ` [PATCH 05/10] staging: wfx: retrieve the PS status from the vif Jerome Pouiller
2020-05-26 17:18 ` [PATCH 06/10] staging: wfx: split wfx_get_ps_timeout() from wfx_update_pm() Jerome Pouiller
2020-05-26 17:18 ` [PATCH 07/10] staging: wfx: add support for set/get ps_timeout Jerome Pouiller
2020-05-26 17:18 ` [PATCH 08/10] staging: wfx: allow to burn prevent rollback bit Jerome Pouiller
2020-05-26 17:18 ` [PATCH 09/10] staging: wfx: allow to set PTA settings Jerome Pouiller
2020-05-26 17:18 ` [PATCH 10/10] staging: wfx: allow to run nl80211 vendor commands with 'iw' Jerome Pouiller
2020-05-27 8:22 ` [PATCH 00/10] staging: wfx: introduce nl80211 vendor extensions Greg Kroah-Hartman
2020-05-27 12:34 ` Kalle Valo [this message]
2020-05-27 13:05 ` Jérôme Pouiller
2020-05-29 15:13 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imghv9nm.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Jerome.Pouiller@silabs.com \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).