From: Qiujun Huang <anenbupt@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, tranmanphong@gmail.com,
Andrey Konovalov <andreyknvl@google.com>,
linux-usb@vger.kernel.org, syzkaller-bugs@googlegroups.com,
linux-kernel@vger.kernel.org,
syzbot <syzbot+df767d588771697b0433@syzkaller.appspotmail.com>
Subject: Re: WARNING in hwahc_probe
Date: Sun, 22 Mar 2020 16:15:28 +0800 [thread overview]
Message-ID: <CADG63jD5vHoTqfmqeRjcYniBLk8reBRfKy+=ZT2aJfcRDa4S6A@mail.gmail.com> (raw)
In-Reply-To: <20200322075850.GA68214@kroah.com>
On Sun, Mar 22, 2020 at 3:58 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Sun, Mar 22, 2020 at 03:53:44PM +0800, Qiujun Huang wrote:
> > The return value of snprintf is longer than expected if the string is
> > truncated. Bytes need to be checked here.
> >
> > diff --git a/drivers/staging/wusbcore/host/hwa-hc.c
> > b/drivers/staging/wusbcore/host/hwa-hc.c
> > index 8d959e9..1475a48 100644
> > --- a/drivers/staging/wusbcore/host/hwa-hc.c
> > +++ b/drivers/staging/wusbcore/host/hwa-hc.c
>
> This file is no longer in the linux-next tree and will be deleted in the
> next kernel release.
>
> Also, no one has this hardware so there's no real security issue here at
> all.
>
> And finally, you forgot a signed-off-by line on your patch :(
Get that, thanks.
>
> thanks,
>
> greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
prev parent reply other threads:[~2020-03-22 8:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-21 14:29 WARNING in hwahc_probe syzbot
2020-03-22 7:53 ` Qiujun Huang
2020-03-22 7:58 ` Greg KH
2020-03-22 8:15 ` Qiujun Huang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADG63jD5vHoTqfmqeRjcYniBLk8reBRfKy+=ZT2aJfcRDa4S6A@mail.gmail.com' \
--to=anenbupt@gmail.com \
--cc=andreyknvl@google.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=syzbot+df767d588771697b0433@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tranmanphong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).