From: Vaishali Thakkar <vthakkar@vaishalithakkar.in>
To: Elena Afanasova <eafanasova@gmail.com>
Cc: devel@driverdev.osuosl.org, Greg KH <gregkh@linuxfoundation.org>,
Outreachy <outreachy-kernel@googlegroups.com>
Subject: Re: [Outreachy kernel] [PATCH 1/3] staging/rtl8712: remove extra blank lines; fix code alignment
Date: Wed, 21 Oct 2020 09:58:50 +0530 [thread overview]
Message-ID: <CAK-LDbKv0-E9w-LdbwNr8vszm_6cwkwF9ic5eDysC7xETnotNg@mail.gmail.com> (raw)
In-Reply-To: <20201020182439.43314-1-eafanasova@gmail.com>
On Wed, Oct 21, 2020 at 12:01 AM Elena Afanasova <eafanasova@gmail.com> wrote:
>
> Reported by checkpatch.pl
>
> Signed-off-by: Elena Afanasova <eafanasova@gmail.com>
This patch is fixing 2 different checkpatch warnings. They
should be sent as separate patches. One for removing extra
blank lines, another one for fixing the code alignment.
> ---
> drivers/staging/rtl8712/rtl871x_recv.h | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/rtl871x_recv.h b/drivers/staging/rtl8712/rtl871x_recv.h
> index e83c256e1474..57a965b9839b 100644
> --- a/drivers/staging/rtl8712/rtl871x_recv.h
> +++ b/drivers/staging/rtl8712/rtl871x_recv.h
> @@ -29,7 +29,6 @@ struct stainfo_rxcache {
> #define PHY_RSSI_SLID_WIN_MAX 100
> #define PHY_LINKQUALITY_SLID_WIN_MAX 20
>
> -
> struct smooth_rssi_data {
> u32 elements[100]; /* array to store values */
> u32 index; /* index to current array to store */
> @@ -38,7 +37,6 @@ struct smooth_rssi_data {
> };
>
> struct rx_pkt_attrib {
> -
> u8 amsdu;
> u8 order;
> u8 qos;
> @@ -129,7 +127,7 @@ union recv_frame *r8712_alloc_recvframe(struct __queue *pfree_recv_queue);
> void r8712_free_recvframe(union recv_frame *precvframe,
> struct __queue *pfree_recv_queue);
> void r8712_free_recvframe_queue(struct __queue *pframequeue,
> - struct __queue *pfree_recv_queue);
> + struct __queue *pfree_recv_queue);
> int r8712_wlanhdr_to_ethhdr(union recv_frame *precvframe);
> int recv_func(struct _adapter *padapter, void *pcontext);
>
> --
> 2.25.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20201020182439.43314-1-eafanasova%40gmail.com.
--
Vaishali
--
Vaishali
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
prev parent reply other threads:[~2020-10-21 4:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 18:24 [PATCH 1/3] staging/rtl8712: remove extra blank lines; fix code alignment Elena Afanasova
2020-10-20 18:24 ` [PATCH 2/3] staging/rtl8712: fix code style for comparison to NULL Elena Afanasova
2020-10-20 18:24 ` [PATCH 3/3] staging/rtl8712: use BIT macro Elena Afanasova
2020-10-20 18:44 ` [Outreachy kernel] " Matthew Wilcox
2020-10-27 12:44 ` Dan Carpenter
2020-10-21 4:28 ` Vaishali Thakkar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK-LDbKv0-E9w-LdbwNr8vszm_6cwkwF9ic5eDysC7xETnotNg@mail.gmail.com \
--to=vthakkar@vaishalithakkar.in \
--cc=devel@driverdev.osuosl.org \
--cc=eafanasova@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).