From: Sergio Paracuellos <sergio.paracuellos@gmail.com>
To: Selvakumar Elangovan <selvakumar16197@gmail.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Greg KH <gregkh@linuxfoundation.org>,
"open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Staging: mt7621-pci: pci-mt7621: fixed a blank line coding style issue
Date: Wed, 17 Feb 2021 07:58:52 +0100 [thread overview]
Message-ID: <CAMhs-H-FTUxSFAsbNe9Gja4f6WR2259KQpZ3q5ByP7hYnXzwyw@mail.gmail.com> (raw)
In-Reply-To: <20210217065318.6685-1-selvakumar16197@gmail.com>
Hi Selvakumar,
On Wed, Feb 17, 2021 at 7:53 AM Selvakumar Elangovan
<selvakumar16197@gmail.com> wrote:
>
> Removed an unecessary blank line before closing brace reported by
> checkpatch.pl
Typo:
s/unecessary/unnecessary/g
>
> Signed-off-by: Selvakumar Elangovan <selvakumar16197@gmail.com>
> ---
> drivers/staging/mt7621-pci/pci-mt7621.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c b/drivers/staging/mt7621-pci/pci-mt7621.c
> index c3532bc138fb..1781c1dcf5b4 100644
> --- a/drivers/staging/mt7621-pci/pci-mt7621.c
> +++ b/drivers/staging/mt7621-pci/pci-mt7621.c
> @@ -521,7 +521,6 @@ static void mt7621_pcie_init_ports(struct mt7621_pcie *pcie)
>
> if (slot == 1 && tmp && !tmp->enabled)
> phy_power_off(tmp->phy);
> -
> }
> }
> }
> --
> 2.17.1
>
Please, also change commit short message to:
staging: mt7621-pci: fixed a blank line coding style issue
With that changes:
Reviewed-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Best regards,
Sergio Paracuellos
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
prev parent reply other threads:[~2021-02-17 6:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 6:53 [PATCH] Staging: mt7621-pci: pci-mt7621: fixed a blank line coding style issue Selvakumar Elangovan
2021-02-17 6:58 ` Sergio Paracuellos [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMhs-H-FTUxSFAsbNe9Gja4f6WR2259KQpZ3q5ByP7hYnXzwyw@mail.gmail.com \
--to=sergio.paracuellos@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=selvakumar16197@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).