From: Sergio Paracuellos <sergio.paracuellos@gmail.com>
To: Chuanhong Guo <gch981213@gmail.com>
Cc: ryder.lee@mediatek.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
driverdev-devel@linuxdriverproject.org, weijie.gao@mediatek.com,
Greg Ungerer <gerg@kernel.org>, NeilBrown <neil@brown.name>
Subject: Re: [PATCH v4 5/6] staging: mt7621-pci: release gpios after pci initialization
Date: Fri, 20 Mar 2020 16:28:54 +0100 [thread overview]
Message-ID: <CAMhs-H9-F+6QwD_LFihUk31mHn1B72LxR+i=AXgCFP0ESyjxKA@mail.gmail.com> (raw)
In-Reply-To: <CAJsYDVKgx419P9f-Y7DaETejwaHwdbnT8+g-Uk4NoKB0qgqPKA@mail.gmail.com>
Hi Chuanhong,
On Fri, Mar 20, 2020 at 3:59 PM Chuanhong Guo <gch981213@gmail.com> wrote:
>
> Hi!
>
> On Sat, Mar 14, 2020 at 4:10 AM Sergio Paracuellos
> <sergio.paracuellos@gmail.com> wrote:
> >
> > R3G's LEDs fail to initialize because one of them uses GPIO8
>
> A gpio can't be used as pcie reset and led simultaneously.
>
Obviously it can't. That was the reason for the release :)
> > Hence, release the GPIO resources after PCIe initialization
> > and properly release also in driver error path.
>
> This pin conflict comes from incorrectly occupying pins that are not
> used by pcie,
> and should be fixed by not occupying those pins in the first place.
> Releasing all
> gpios isn't the proper way to go.
So, you are saying we just have to get gpio for the pin 19 and forget
about the others?
>
> --
> Regards,
> Chuanhong Guo
Best regards,
Sergio Paracuellos
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-03-20 15:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 20:09 [PATCH v4 0/6] staging: mt7621-pci: re-do reset boot process Sergio Paracuellos
2020-03-13 20:09 ` [PATCH v4 1/6] staging: mt7621-pci: use gpios for properly reset Sergio Paracuellos
2020-03-13 20:09 ` [PATCH v4 2/6] staging: mt7621-pci: change value for 'PERST_DELAY_MS' Sergio Paracuellos
2020-03-13 20:09 ` [PATCH v4 3/6] staging: mt7621-dts: make use of 'reset-gpios' property for pci Sergio Paracuellos
2020-03-13 20:09 ` [PATCH v4 4/6] staging: mt7621-pci: bindings: update doc accordly to last changes Sergio Paracuellos
2020-03-13 20:09 ` [PATCH v4 5/6] staging: mt7621-pci: release gpios after pci initialization Sergio Paracuellos
2020-03-20 14:59 ` Chuanhong Guo
2020-03-20 15:28 ` Sergio Paracuellos [this message]
2020-03-20 15:39 ` Chuanhong Guo
2020-03-20 16:32 ` Sergio Paracuellos
2020-03-20 16:34 ` Sergio Paracuellos
2020-03-21 6:36 ` Chuanhong Guo
2020-03-21 7:28 ` Sergio Paracuellos
2020-03-13 20:09 ` [PATCH v4 6/6] staging: mt7621-pci: delete no more needed 'mt7621_reset_port' Sergio Paracuellos
2020-03-14 10:42 ` [PATCH v4 0/6] staging: mt7621-pci: re-do reset boot process Sergio Paracuellos
2020-03-15 12:35 ` Sergio Paracuellos
2020-03-19 12:42 ` Greg Ungerer
2020-03-19 13:43 ` Sergio Paracuellos
2020-03-19 13:47 ` Sergio Paracuellos
2020-03-19 14:28 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMhs-H9-F+6QwD_LFihUk31mHn1B72LxR+i=AXgCFP0ESyjxKA@mail.gmail.com' \
--to=sergio.paracuellos@gmail.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gch981213@gmail.com \
--cc=gerg@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=neil@brown.name \
--cc=ryder.lee@mediatek.com \
--cc=weijie.gao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).