From: Greg KH <gregkh@linuxfoundation.org>
To: Atul Gopinathan <atulgopinathan@gmail.com>
Cc: devel@driverdev.osuosl.org, abbotti@mev.co.uk,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: comedi: cast to (void __user *)
Date: Thu, 18 Feb 2021 08:10:28 +0100 [thread overview]
Message-ID: <YC4S5Pxw341zw9DL@kroah.com> (raw)
In-Reply-To: <20210218062839.32650-1-atulgopinathan@gmail.com>
On Thu, Feb 18, 2021 at 11:58:40AM +0530, Atul Gopinathan wrote:
> Resolve the following sparse warning:
> drivers/staging//comedi/comedi_fops.c:2983:41: warning: incorrect type in argument 1 (different address spaces)
> drivers/staging//comedi/comedi_fops.c:2983:41: expected void [noderef] <asn:1> *uptr
> drivers/staging//comedi/comedi_fops.c:2983:41: got unsigned int *chanlist
>
> cmd->chanlist is of type (unsigned int *) as defined in
> "struct comedi_cmd" in file drivers/staging/comedi/comedi.h
>
> The function "ptr_to_compat()" expects argument of type
> (void __user *) as defined in include/linux/compat.h
>
> Signed-off-by: Atul Gopinathan <atulgopinathan@gmail.com>
> ---
> drivers/staging/comedi/comedi_fops.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Is this different from your previous patch:
https://lore.kernel.org/r/20210217165907.9777-1-atulgopinathan@gmail.com
if so, you might need a better subject line here, and for that one, as
they look alike at a quick glance.
Which one goes first?
Can you resend both of these as a patch series with better subjects as a
v2 patch set?
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2021-02-18 7:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 6:28 [PATCH] staging: comedi: cast to (void __user *) Atul Gopinathan
2021-02-18 7:10 ` Greg KH [this message]
2021-02-18 8:25 ` Atul Gopinathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YC4S5Pxw341zw9DL@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=abbotti@mev.co.uk \
--cc=atulgopinathan@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).