From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: karthik alapati <mail@karthek.com>
Cc: devel@driverdev.osuosl.org,
Johannes Berg <johannes@sipsolutions.net>,
Lee Jones <lee.jones@linaro.org>,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] staging: wimax/i2400m: fix byte-order type issue
Date: Sun, 21 Feb 2021 12:26:19 +0100 [thread overview]
Message-ID: <YDJDW97X7k+mb/gE@kroah.com> (raw)
In-Reply-To: <YDEGD7pFyTi+CTXy@karthik-strix-linux.karthek.com>
On Sat, Feb 20, 2021 at 06:22:31PM +0530, karthik alapati wrote:
> fix sparse type warning by converting le32 types to
> host byte-order types before comparison
>
> Signed-off-by: karthik alapati <mail@karthek.com>
> ---
> drivers/staging/wimax/i2400m/fw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wimax/i2400m/fw.c b/drivers/staging/wimax/i2400m/fw.c
> index 92ea5c101..f09de1810 100644
> --- a/drivers/staging/wimax/i2400m/fw.c
> +++ b/drivers/staging/wimax/i2400m/fw.c
> @@ -511,7 +511,7 @@ ssize_t __i2400m_bm_ack_verify(struct i2400m *i2400m, int opcode,
> opcode, i2400m_brh_get_response(ack));
> goto error_ack_failed;
> }
> - if (ack_size < ack->data_size + sizeof(*ack)) {
> + if (ack_size < le32_to_cpu(ack->data_size) + sizeof(*ack)) {
> dev_err(dev, "boot-mode cmd %d: SW BUG "
> "driver provided only %zu bytes for %zu bytes "
> "of data\n", opcode, ack_size,
You sent 3 patches that seem to do the same thing, yet are a bit
different?
Please make your patches a patch series and provide proper subject lines
to make them unique. I have now dropped all of your submitted patches
from my review queue.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2021-02-21 11:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-20 12:52 [PATCH] staging: wimax/i2400m: fix byte-order type issue karthik alapati
2021-02-21 11:26 ` Greg Kroah-Hartman [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-02-20 12:50 karthek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDJDW97X7k+mb/gE@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=devel@driverdev.osuosl.org \
--cc=johannes@sipsolutions.net \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@karthek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).