From: Deepak R Varma <drv@mailo.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org
Subject: Re: [PATCH 3/5] staging: media: atomisp: code formatting changes sh_css_params.c
Date: Sat, 22 May 2021 15:54:06 +0530 [thread overview]
Message-ID: <YKjbxhzD/yKQ6B2R@dU2104> (raw)
In-Reply-To: <20210521105222.GJ1955@kadam>
On Fri, May 21, 2021 at 01:52:22PM +0300, Dan Carpenter wrote:
> On Sat, May 01, 2021 at 12:16:07PM +0530, Deepak R Varma wrote:
> > @@ -1562,8 +1544,10 @@ ia_css_isp_3a_statistics_map_allocate(
> > base_ptr = me->data_ptr;
> >
> > me->size = isp_stats->size;
> > - /* GCC complains when we assign a char * to a void *, so these
> > - * casts are necessary unfortunately. */
> > + /*
> > + * GCC complains when we assign a char * to a void *, so these
> > + * casts are necessary unfortunately.
> > + */
>
> Not related to your patch, but assigning a char pointer to a void
> pointer is fine and GCC will not complain. The problem is that
> me->dmem_stats is not a void pointer. Someone should delete that
> nonsense comment.
I agree. Well caught. I will remove these comments and send v2. Waiting for feedback
on other patches of this series.
deepak.
>
> > me->dmem_stats = (void *)base_ptr;
> > me->vmem_stats_hi = (void *)(base_ptr + isp_stats->dmem_size);
> > me->vmem_stats_lo = (void *)(base_ptr + isp_stats->dmem_size +
>
> regards,
> dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2021-05-22 10:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-01 6:43 [PATCH 0/5] staging: media: atomisp: code formatting changes Deepak R Varma
2021-05-01 6:44 ` [PATCH 1/5] staging: media: atomisp: code formatting changes atomisp_csi2.c Deepak R Varma
2021-05-20 19:02 ` [PATCH RESEND " Deepak R Varma
2021-05-01 6:45 ` [PATCH 2/5] staging: media: atomisp: code formatting changes sh_css_mipi.c Deepak R Varma
2021-05-20 19:03 ` [PATCH RESEND " Deepak R Varma
2021-05-01 6:46 ` [PATCH 3/5] staging: media: atomisp: code formatting changes sh_css_params.c Deepak R Varma
2021-05-20 19:04 ` [PATCH RESEND " Deepak R Varma
2021-05-21 10:52 ` [PATCH " Dan Carpenter
2021-05-22 10:24 ` Deepak R Varma [this message]
2021-05-01 6:47 ` [PATCH 4/5] staging: media: atomisp: code formatting changes sh_css_sp.c Deepak R Varma
2021-05-20 19:05 ` [PATCH RESEND " Deepak R Varma
2021-05-01 6:48 ` [PATCH 5/5] staging: media: atomisp: code formatting changes sh_css_version.c Deepak R Varma
2021-05-20 19:06 ` [PATCH RESEND " Deepak R Varma
2021-05-20 19:00 ` [PATCH RESEND 0/5] staging: media: atomisp: code formatting changes Deepak R Varma
2021-06-12 16:43 ` Deepak R Varma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKjbxhzD/yKQ6B2R@dU2104 \
--to=drv@mailo.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).