From: Julia Lawall <julia.lawall@lip6.fr>
To: Gabriela Bittencourt <gabrielabittencourt00@gmail.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com,
lkcamp@lists.libreplanetbr.org, nishkadg.linux@gmail.com,
kim.jamie.bradley@gmail.com
Subject: Re: [Outreachy kernel] [PATCH v3 2/3] staging: rts5208: Eliminate the use of Camel Case in files xd.{h,c}
Date: Thu, 31 Oct 2019 07:39:20 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.1910310738570.2718@hadrien> (raw)
In-Reply-To: <20191030190514.10011-3-gabrielabittencourt00@gmail.com>
On Wed, 30 Oct 2019, Gabriela Bittencourt wrote:
> Cleans up checks of "Avoid CamelCase" in files xd.{h,c}
>
> Signed-off-by: Gabriela Bittencourt <gabrielabittencourt00@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> drivers/staging/rts5208/xd.c | 8 ++++----
> drivers/staging/rts5208/xd.h | 6 +++---
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/rts5208/xd.c b/drivers/staging/rts5208/xd.c
> index f3dc96a4c59d..0f369935fb6c 100644
> --- a/drivers/staging/rts5208/xd.c
> +++ b/drivers/staging/rts5208/xd.c
> @@ -630,13 +630,13 @@ static int reset_xd(struct rtsx_chip *chip)
> xd_card->zone_cnt = 32;
> xd_card->capacity = 1024000;
> break;
> - case xD_1G_X8_512:
> + case XD_1G_X8_512:
> XD_PAGE_512(xd_card);
> xd_card->addr_cycle = 4;
> xd_card->zone_cnt = 64;
> xd_card->capacity = 2048000;
> break;
> - case xD_2G_X8_512:
> + case XD_2G_X8_512:
> XD_PAGE_512(xd_card);
> xd_card->addr_cycle = 4;
> xd_card->zone_cnt = 128;
> @@ -669,10 +669,10 @@ static int reset_xd(struct rtsx_chip *chip)
> return STATUS_FAIL;
> }
>
> - retval = xd_read_id(chip, READ_xD_ID, id_buf, 4);
> + retval = xd_read_id(chip, READ_XD_ID, id_buf, 4);
> if (retval != STATUS_SUCCESS)
> return STATUS_FAIL;
> - dev_dbg(rtsx_dev(chip), "READ_xD_ID: 0x%x 0x%x 0x%x 0x%x\n",
> + dev_dbg(rtsx_dev(chip), "READ_XD_ID: 0x%x 0x%x 0x%x 0x%x\n",
> id_buf[0], id_buf[1], id_buf[2], id_buf[3]);
> if (id_buf[2] != XD_ID_CODE)
> return STATUS_FAIL;
> diff --git a/drivers/staging/rts5208/xd.h b/drivers/staging/rts5208/xd.h
> index 57b94129b26f..98c00f268e56 100644
> --- a/drivers/staging/rts5208/xd.h
> +++ b/drivers/staging/rts5208/xd.h
> @@ -36,7 +36,7 @@
> #define BLK_ERASE_1 0x60
> #define BLK_ERASE_2 0xD0
> #define READ_STS 0x70
> -#define READ_xD_ID 0x9A
> +#define READ_XD_ID 0x9A
> #define COPY_BACK_512 0x8A
> #define COPY_BACK_2K 0x85
> #define READ1_1_2 0x30
> @@ -72,8 +72,8 @@
> #define XD_128M_X16_2048 0xC1
> #define XD_4M_X8_512_1 0xE3
> #define XD_4M_X8_512_2 0xE5
> -#define xD_1G_X8_512 0xD3
> -#define xD_2G_X8_512 0xD5
> +#define XD_1G_X8_512 0xD3
> +#define XD_2G_X8_512 0xD5
>
> #define XD_ID_CODE 0xB5
>
> --
> 2.20.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191030190514.10011-3-gabrielabittencourt00%40gmail.com.
>
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2019-10-31 6:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 19:05 [PATCH v3 0/3] staging: rts5208: Eliminate the use of Camel Case Gabriela Bittencourt
2019-10-30 19:05 ` [PATCH v3 1/3] staging: rts5208: Eliminate the use of Camel Case in files ms.{h, c} Gabriela Bittencourt
2019-10-31 6:40 ` [Outreachy kernel] [PATCH v3 1/3] staging: rts5208: Eliminate the use of Camel Case in files ms.{h,c} Julia Lawall
2019-10-30 19:05 ` [PATCH v3 2/3] staging: rts5208: Eliminate the use of Camel Case in files xd.{h, c} Gabriela Bittencourt
2019-10-31 6:39 ` Julia Lawall [this message]
2019-10-30 19:05 ` [PATCH v3 3/3] staging: rts5208: Eliminate the use of Camel Case in file sd.h Gabriela Bittencourt
2019-10-31 6:35 ` [Outreachy kernel] " Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1910310738570.2718@hadrien \
--to=julia.lawall@lip6.fr \
--cc=devel@driverdev.osuosl.org \
--cc=gabrielabittencourt00@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kim.jamie.bradley@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkcamp@lists.libreplanetbr.org \
--cc=nishkadg.linux@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).