archive mirror
 help / color / mirror / Atom feed
From: "William Durand" <>
To: "Dan Carpenter" <>
	Greg Kroah-Hartman <>,
Subject: Re: [PATCH] staging: rtl8192e: fix typo in a function name
Date: Mon, 15 Feb 2021 19:30:29 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20210215130334.GM2087@kadam>

> On Sat, Feb 13, 2021 at 09:20:14AM +0000, William Durand wrote:
> > Other function names use the verb 'query' so this function should
> > probably use it too and that's what this patch is about. I didn't
> > find any other occurrence and the code compiles.
> > 
> It's really just assumed that the code still compiles afterwards.
> Sometimes, it's hard for me to right commit messages confidently because
> I don't know if static checker bugs affect real life.  But in this case
> I really think the commit message could be written more confidently.
> Please write it like this:
> "There is a typo here where it says "qurey" but "query" was intended."

Thanks Dan, I'll update the commit message shortly and send a new patch.

devel mailing list

      reply	other threads:[~2021-02-15 18:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-13  9:20 William Durand
2021-02-15 13:03 ` Dan Carpenter
2021-02-15 18:30   ` William Durand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \
    --subject='Re: [PATCH] staging: rtl8192e: fix typo in a function name' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).