* [PATCH] test: use a more stable data item
@ 2024-04-26 4:31 Kris Van Hees
2024-04-26 11:39 ` Nick Alcock
0 siblings, 1 reply; 2+ messages in thread
From: Kris Van Hees @ 2024-04-26 4:31 UTC (permalink / raw)
To: dtrace, dtrace-devel
The runtime bounds check exception for dynamically sized arrays in
kernel structures depended on a kernel symbol that is not quite as
stable as expected. Use a member from the mm_struct instead.
Signed-off-by: Kris Van Hees <kris.van.hees@oracle.com>
---
test/unittest/arrays/tst.ctf-dynsized-bounds-runtime.d | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/unittest/arrays/tst.ctf-dynsized-bounds-runtime.d b/test/unittest/arrays/tst.ctf-dynsized-bounds-runtime.d
index 62c2e9a5..4d8dfd0b 100644
--- a/test/unittest/arrays/tst.ctf-dynsized-bounds-runtime.d
+++ b/test/unittest/arrays/tst.ctf-dynsized-bounds-runtime.d
@@ -15,7 +15,7 @@
BEGIN
{
i = pid - pid; /* Non-constant 0 value. */
- trace(`__start_BTF[i]);
+ trace(curthread->mm->cpu_bitmap[i]);
exit(0);
}
--
2.42.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] test: use a more stable data item
2024-04-26 4:31 [PATCH] test: use a more stable data item Kris Van Hees
@ 2024-04-26 11:39 ` Nick Alcock
0 siblings, 0 replies; 2+ messages in thread
From: Nick Alcock @ 2024-04-26 11:39 UTC (permalink / raw)
To: Kris Van Hees; +Cc: dtrace, dtrace-devel
On 26 Apr 2024, Kris Van Hees said:
> The runtime bounds check exception for dynamically sized arrays in
> kernel structures depended on a kernel symbol that is not quite as
> stable as expected. Use a member from the mm_struct instead.
Your assumption that it was analyzed in any way for stability is
touching, but inaccurate :P
Pure gut feeling replaced with something a bit more obviously sorta
stable (at least it needs more work to massively change it upstream,
and massive mm changes are fairly rare):
> Signed-off-by: Kris Van Hees <kris.van.hees@oracle.com>
Reviewed-by: Nick Alcock <nick.alcock@oracle.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-26 11:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-26 4:31 [PATCH] test: use a more stable data item Kris Van Hees
2024-04-26 11:39 ` Nick Alcock
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).