Re: [PATCH 1/1] define memdup() static

Re: [PATCH 1/1] define memdup() static

[Arnaldo Carvalho de Melo]

Applied,

Thanks a lot!

- Arnaldo

Re: [PATCH 1/1] define memdup() static

[Hagen Paul Pfeifer]

* Arnaldo Carvalho de Melo | 2008-02-11 22:11:38 [-0200]:

>Thanks a lot!

NULL problemo! ;-) Arnaldo. By the way: I don't forgot the dwarves structure
modifications (you remember, the lightweight cmake replacement?), but my study
courses eat a lot of time. Furthermore my other projects are also time
consuming. ;-)

You know Arnaldo, a nice hacking session and you will forgot almost everything
around ...

http://libhashish.sourceforge.net/ 

HGN

Re: [PATCH 1/1] define memdup() static

[Arnaldo Carvalho de Melo]

Em Tue, Feb 12, 2008 at 01:37:30AM +0100, Hagen Paul Pfeifer escreveu:
> * Arnaldo Carvalho de Melo | 2008-02-11 22:11:38 [-0200]:
> 
> >Thanks a lot!
> 
> NULL problemo! ;-) Arnaldo. By the way: I don't forgot the dwarves structure
> modifications (you remember, the lightweight cmake replacement?), but my study
> courses eat a lot of time. Furthermore my other projects are also time
> consuming. ;-)

np

> You know Arnaldo, a nice hacking session and you will forgot almost everything
> around ...
> 
> http://libhashish.sourceforge.net/ 

Wow, thanks for the pointer'n'software, will try it at some point!

- Arnaldo

Re: [PATCH 1/1] define memdup() static

[Hagen Paul Pfeifer]

* Arnaldo Carvalho de Melo | 2008-02-11 23:12:42 [-0200]:

>Wow, thanks for the pointer'n'software, will try it at some point!

;-) it's still work in progress. Next time we will extend the rbtree structure
to scale with the number of CPUs via some hash based CPU distribution. Well,
it is an interesting area! ;-) (BTW: the homepage needs some work)

Time to sleep (2:44am CET)

Hagen

[PATCH 1/1] define memdup() static

[Hagen Paul Pfeifer]

memdup() is only referenced from dwarves.c. This patch defines them
static. Further symbol hiding can be accomplished via GCC attributes:

#if __GNUC__ > 3 || (__GNUC__ == 3 && __GNUC_MINOR__ >= 4)
# define DWARVES_NO_EXPORT __attribute__((visibility("hidden")))
#else
# define DWARVES_NO_EXPORT
#endif

Signed-off-by: Hagen Paul Pfeifer <hagen-GvnIQ6b/HdU@public.gmane.org>
---
 dwarves.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/dwarves.c b/dwarves.c
index 813c67b..aa9510e 100644
--- a/dwarves.c
+++ b/dwarves.c
@@ -114,7 +114,7 @@ static void *zalloc(const size_t size)
 	return s;
 }
 
-void *memdup(const void *src, size_t len)
+static void *memdup(const void *src, size_t len)
 {
 	void *s = malloc(len);
 	if (s != NULL)
-- 
1.5.3.8