From: Sekhar Nori <nsekhar@ti.com>
To: David Lechner <david@lechnology.com>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Kevin Hilman <khilman@kernel.org>,
Russell King <linux@armlinux.org.uk>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [v2] ARM: davinci: fix the GPIO lookup for omapl138-hawk
Date: Fri, 16 Mar 2018 20:35:51 +0530 [thread overview]
Message-ID: <e0cad8b8-c2fe-0a66-411f-d478e145ade4@ti.com> (raw)
In-Reply-To: <2641a421-9823-c0bb-93d9-ca0c64060c51@lechnology.com>
On Thursday 15 March 2018 10:05 PM, David Lechner wrote:
> On 03/01/2018 04:34 AM, Bartosz Golaszewski wrote:
>> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>>
>> The GPIO chip is called davinci_gpio.0 in legacy mode. Fix it, so that
>> mmc can correctly lookup the wp and cp gpios.
>>
>> Fixes: c69f43fb4f26 ("ARM: davinci: hawk: use gpio descriptor for mmc
>> pins")
>> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
>> ---
>> v1 -> v2:
>> - added the Fixes: tag
>>
>> arch/arm/mach-davinci/board-omapl138-hawk.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/mach-davinci/board-omapl138-hawk.c
>> b/arch/arm/mach-davinci/board-omapl138-hawk.c
>> index a3e78074be70..62eb7d668890 100644
>> --- a/arch/arm/mach-davinci/board-omapl138-hawk.c
>> +++ b/arch/arm/mach-davinci/board-omapl138-hawk.c
>> @@ -127,8 +127,8 @@ static struct gpiod_lookup_table mmc_gpios_table = {
>> .dev_id = "da830-mmc.0",
>> .table = {
>> /* CD: gpio3_12: gpio60: chip 1 contains gpio range 32-63*/
>> - GPIO_LOOKUP("davinci_gpio.1", 28, "cd", GPIO_ACTIVE_LOW),
>> - GPIO_LOOKUP("davinci_gpio.1", 29, "wp", GPIO_ACTIVE_LOW),
>> + GPIO_LOOKUP("davinci_gpio.0", 28, "cd", GPIO_ACTIVE_LOW),
>> + GPIO_LOOKUP("davinci_gpio.0", 29, "wp", GPIO_ACTIVE_LOW),
>> },
>> };
>>
>
> Does board-da830-evm.c need the same fix? It also uses "davinci_gpio.1".
Yes. looks like fixes are needed here and other places. I will send
patches since I have ability to test them.
Thanks,
Sekhar
WARNING: multiple messages have this Message-ID (diff)
From: nsekhar@ti.com (Sekhar Nori)
To: linux-arm-kernel@lists.infradead.org
Subject: [v2] ARM: davinci: fix the GPIO lookup for omapl138-hawk
Date: Fri, 16 Mar 2018 20:35:51 +0530 [thread overview]
Message-ID: <e0cad8b8-c2fe-0a66-411f-d478e145ade4@ti.com> (raw)
In-Reply-To: <2641a421-9823-c0bb-93d9-ca0c64060c51@lechnology.com>
On Thursday 15 March 2018 10:05 PM, David Lechner wrote:
> On 03/01/2018 04:34 AM, Bartosz Golaszewski wrote:
>> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>>
>> The GPIO chip is called davinci_gpio.0 in legacy mode. Fix it, so that
>> mmc can correctly lookup the wp and cp gpios.
>>
>> Fixes: c69f43fb4f26 ("ARM: davinci: hawk: use gpio descriptor for mmc
>> pins")
>> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
>> ---
>> v1 -> v2:
>> - added the Fixes: tag
>>
>> ? arch/arm/mach-davinci/board-omapl138-hawk.c | 4 ++--
>> ? 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/mach-davinci/board-omapl138-hawk.c
>> b/arch/arm/mach-davinci/board-omapl138-hawk.c
>> index a3e78074be70..62eb7d668890 100644
>> --- a/arch/arm/mach-davinci/board-omapl138-hawk.c
>> +++ b/arch/arm/mach-davinci/board-omapl138-hawk.c
>> @@ -127,8 +127,8 @@ static struct gpiod_lookup_table mmc_gpios_table = {
>> ????? .dev_id = "da830-mmc.0",
>> ????? .table = {
>> ????????? /* CD: gpio3_12: gpio60: chip 1 contains gpio range 32-63*/
>> -??????? GPIO_LOOKUP("davinci_gpio.1", 28, "cd", GPIO_ACTIVE_LOW),
>> -??????? GPIO_LOOKUP("davinci_gpio.1", 29, "wp", GPIO_ACTIVE_LOW),
>> +??????? GPIO_LOOKUP("davinci_gpio.0", 28, "cd", GPIO_ACTIVE_LOW),
>> +??????? GPIO_LOOKUP("davinci_gpio.0", 29, "wp", GPIO_ACTIVE_LOW),
>> ????? },
>> ? };
>> ?
>
> Does board-da830-evm.c need the same fix? It also uses "davinci_gpio.1".
Yes. looks like fixes are needed here and other places. I will send
patches since I have ability to test them.
Thanks,
Sekhar
next prev parent reply other threads:[~2018-03-16 15:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 10:34 [PATCH v2] ARM: davinci: fix the GPIO lookup for omapl138-hawk Bartosz Golaszewski
2018-03-01 10:34 ` Bartosz Golaszewski
2018-03-09 10:18 ` Sekhar Nori
2018-03-09 10:18 ` Sekhar Nori
2018-03-15 16:35 ` [v2] " David Lechner
2018-03-15 16:35 ` David Lechner
2018-03-16 15:05 ` Sekhar Nori [this message]
2018-03-16 15:05 ` Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0cad8b8-c2fe-0a66-411f-d478e145ade4@ti.com \
--to=nsekhar@ti.com \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=david@lechnology.com \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.