All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: kernel test robot <lkp@intel.com>, Jonathan Marek <jonathan@marek.ca>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	Vinod Koul <vkoul@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Bard Liao <yung-chuan.liao@linux.intel.com>,
	moderated for non-subscribers <alsa-devel@alsa-project.org>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: Re: drivers/soundwire/qcom.c:767: undefined reference to `slimbus_bus'
Date: Wed, 4 Nov 2020 19:32:41 -0800	[thread overview]
Message-ID: <e0d74391-18ae-0493-b8a1-cbeb6f00bde8@infradead.org> (raw)
In-Reply-To: <202011030351.iq9CBMO3-lkp@intel.com>

On 11/2/20 11:47 AM, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   3cea11cd5e3b00d91caf0b4730194039b45c5891
> commit: 09309093d5e8f8774e4a3a0d42b73cf47e9421cf soundwire: qcom: fix SLIBMUS/SLIMBUS typo
> date:   8 weeks ago
> config: openrisc-randconfig-r005-20201102 (attached as .config)
> compiler: or1k-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=09309093d5e8f8774e4a3a0d42b73cf47e9421cf
>         git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>         git fetch --no-tags linus master
>         git checkout 09309093d5e8f8774e4a3a0d42b73cf47e9421cf
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=openrisc 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>    or1k-linux-ld: drivers/soundwire/qcom.o: in function `qcom_swrm_probe':
>>> drivers/soundwire/qcom.c:767: undefined reference to `slimbus_bus'
>>> or1k-linux-ld: drivers/soundwire/qcom.c:771: undefined reference to `slimbus_bus'
> 
> vim +767 drivers/soundwire/qcom.c
> 
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13  756  
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13  757  static int qcom_swrm_probe(struct platform_device *pdev)
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13  758  {
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13  759  	struct device *dev = &pdev->dev;
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13  760  	struct sdw_master_prop *prop;
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13  761  	struct sdw_bus_params *params;
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13  762  	struct qcom_swrm_ctrl *ctrl;
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13  763  	int ret;
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13  764  	u32 val;
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13  765  
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13  766  	ctrl = devm_kzalloc(dev, sizeof(*ctrl), GFP_KERNEL);
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13 @767  	if (!ctrl)
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13  768  		return -ENOMEM;
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13  769  
> 09309093d5e8f87 Jonathan Marek       2020-09-08  770  #if IS_ENABLED(CONFIG_SLIMBUS)
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13 @771  	if (dev->parent->bus == &slimbus_bus) {
> 5bd773242f75da3 Jonathan Marek       2020-09-05  772  #else
> 5bd773242f75da3 Jonathan Marek       2020-09-05  773  	if (false) {
> 5bd773242f75da3 Jonathan Marek       2020-09-05  774  #endif

> :::::: The code at line 767 was first introduced by commit
> :::::: 02efb49aa805cee643a643ab61a1118c2fd08b80 soundwire: qcom: add support for SoundWire controller
> 
> :::::: TO: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> :::::: CC: Vinod Koul <vkoul@kernel.org>


config SOUNDWIRE_QCOM
	tristate "Qualcomm SoundWire Master driver"
	imply SLIMBUS
	depends on SND_SOC

The kernel config that was attached has:
CONFIG_SOUNDWIRE_QCOM=y
CONFIG_SLIMBUS=m

I expected that "imply" would make SLIMBUS=y since SOUNDWIRE_QCOM=y,
but I guess that's not the case. :(

Any ideas about what to do here?

-- 
~Randy


WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <rdunlap@infradead.org>
To: kernel test robot <lkp@intel.com>, Jonathan Marek <jonathan@marek.ca>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	moderated for non-subscribers <alsa-devel@alsa-project.org>,
	kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Vinod Koul <vkoul@kernel.org>,
	Bard Liao <yung-chuan.liao@linux.intel.com>
Subject: Re: drivers/soundwire/qcom.c:767: undefined reference to `slimbus_bus'
Date: Wed, 4 Nov 2020 19:32:41 -0800	[thread overview]
Message-ID: <e0d74391-18ae-0493-b8a1-cbeb6f00bde8@infradead.org> (raw)
In-Reply-To: <202011030351.iq9CBMO3-lkp@intel.com>

On 11/2/20 11:47 AM, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   3cea11cd5e3b00d91caf0b4730194039b45c5891
> commit: 09309093d5e8f8774e4a3a0d42b73cf47e9421cf soundwire: qcom: fix SLIBMUS/SLIMBUS typo
> date:   8 weeks ago
> config: openrisc-randconfig-r005-20201102 (attached as .config)
> compiler: or1k-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=09309093d5e8f8774e4a3a0d42b73cf47e9421cf
>         git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>         git fetch --no-tags linus master
>         git checkout 09309093d5e8f8774e4a3a0d42b73cf47e9421cf
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=openrisc 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>    or1k-linux-ld: drivers/soundwire/qcom.o: in function `qcom_swrm_probe':
>>> drivers/soundwire/qcom.c:767: undefined reference to `slimbus_bus'
>>> or1k-linux-ld: drivers/soundwire/qcom.c:771: undefined reference to `slimbus_bus'
> 
> vim +767 drivers/soundwire/qcom.c
> 
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13  756  
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13  757  static int qcom_swrm_probe(struct platform_device *pdev)
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13  758  {
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13  759  	struct device *dev = &pdev->dev;
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13  760  	struct sdw_master_prop *prop;
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13  761  	struct sdw_bus_params *params;
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13  762  	struct qcom_swrm_ctrl *ctrl;
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13  763  	int ret;
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13  764  	u32 val;
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13  765  
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13  766  	ctrl = devm_kzalloc(dev, sizeof(*ctrl), GFP_KERNEL);
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13 @767  	if (!ctrl)
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13  768  		return -ENOMEM;
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13  769  
> 09309093d5e8f87 Jonathan Marek       2020-09-08  770  #if IS_ENABLED(CONFIG_SLIMBUS)
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13 @771  	if (dev->parent->bus == &slimbus_bus) {
> 5bd773242f75da3 Jonathan Marek       2020-09-05  772  #else
> 5bd773242f75da3 Jonathan Marek       2020-09-05  773  	if (false) {
> 5bd773242f75da3 Jonathan Marek       2020-09-05  774  #endif

> :::::: The code at line 767 was first introduced by commit
> :::::: 02efb49aa805cee643a643ab61a1118c2fd08b80 soundwire: qcom: add support for SoundWire controller
> 
> :::::: TO: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> :::::: CC: Vinod Koul <vkoul@kernel.org>


config SOUNDWIRE_QCOM
	tristate "Qualcomm SoundWire Master driver"
	imply SLIMBUS
	depends on SND_SOC

The kernel config that was attached has:
CONFIG_SOUNDWIRE_QCOM=y
CONFIG_SLIMBUS=m

I expected that "imply" would make SLIMBUS=y since SOUNDWIRE_QCOM=y,
but I guess that's not the case. :(

Any ideas about what to do here?

-- 
~Randy


WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <rdunlap@infradead.org>
To: kbuild-all@lists.01.org
Subject: Re: drivers/soundwire/qcom.c:767: undefined reference to `slimbus_bus'
Date: Wed, 04 Nov 2020 19:32:41 -0800	[thread overview]
Message-ID: <e0d74391-18ae-0493-b8a1-cbeb6f00bde8@infradead.org> (raw)
In-Reply-To: <202011030351.iq9CBMO3-lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 3644 bytes --]

On 11/2/20 11:47 AM, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   3cea11cd5e3b00d91caf0b4730194039b45c5891
> commit: 09309093d5e8f8774e4a3a0d42b73cf47e9421cf soundwire: qcom: fix SLIBMUS/SLIMBUS typo
> date:   8 weeks ago
> config: openrisc-randconfig-r005-20201102 (attached as .config)
> compiler: or1k-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=09309093d5e8f8774e4a3a0d42b73cf47e9421cf
>         git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>         git fetch --no-tags linus master
>         git checkout 09309093d5e8f8774e4a3a0d42b73cf47e9421cf
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=openrisc 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>    or1k-linux-ld: drivers/soundwire/qcom.o: in function `qcom_swrm_probe':
>>> drivers/soundwire/qcom.c:767: undefined reference to `slimbus_bus'
>>> or1k-linux-ld: drivers/soundwire/qcom.c:771: undefined reference to `slimbus_bus'
> 
> vim +767 drivers/soundwire/qcom.c
> 
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13  756  
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13  757  static int qcom_swrm_probe(struct platform_device *pdev)
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13  758  {
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13  759  	struct device *dev = &pdev->dev;
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13  760  	struct sdw_master_prop *prop;
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13  761  	struct sdw_bus_params *params;
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13  762  	struct qcom_swrm_ctrl *ctrl;
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13  763  	int ret;
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13  764  	u32 val;
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13  765  
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13  766  	ctrl = devm_kzalloc(dev, sizeof(*ctrl), GFP_KERNEL);
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13 @767  	if (!ctrl)
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13  768  		return -ENOMEM;
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13  769  
> 09309093d5e8f87 Jonathan Marek       2020-09-08  770  #if IS_ENABLED(CONFIG_SLIMBUS)
> 02efb49aa805cee Srinivas Kandagatla  2020-01-13 @771  	if (dev->parent->bus == &slimbus_bus) {
> 5bd773242f75da3 Jonathan Marek       2020-09-05  772  #else
> 5bd773242f75da3 Jonathan Marek       2020-09-05  773  	if (false) {
> 5bd773242f75da3 Jonathan Marek       2020-09-05  774  #endif

> :::::: The code at line 767 was first introduced by commit
> :::::: 02efb49aa805cee643a643ab61a1118c2fd08b80 soundwire: qcom: add support for SoundWire controller
> 
> :::::: TO: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> :::::: CC: Vinod Koul <vkoul@kernel.org>


config SOUNDWIRE_QCOM
	tristate "Qualcomm SoundWire Master driver"
	imply SLIMBUS
	depends on SND_SOC

The kernel config that was attached has:
CONFIG_SOUNDWIRE_QCOM=y
CONFIG_SLIMBUS=m

I expected that "imply" would make SLIMBUS=y since SOUNDWIRE_QCOM=y,
but I guess that's not the case. :(

Any ideas about what to do here?

-- 
~Randy

  reply	other threads:[~2020-11-05  3:33 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-02 19:47 drivers/soundwire/qcom.c:767: undefined reference to `slimbus_bus' kernel test robot
2020-11-02 19:47 ` kernel test robot
2020-11-05  3:32 ` Randy Dunlap [this message]
2020-11-05  3:32   ` Randy Dunlap
2020-11-05  3:32   ` Randy Dunlap
2020-11-25  5:51   ` Vinod Koul
2020-11-25  5:51     ` Vinod Koul
2020-11-25  5:51     ` Vinod Koul
2020-11-25 11:41     ` Srinivas Kandagatla
2020-11-25 11:41       ` Srinivas Kandagatla
2020-11-25 11:41       ` Srinivas Kandagatla
2020-11-25 17:31     ` Randy Dunlap
2020-11-25 17:31       ` Randy Dunlap
2020-11-25 17:31       ` Randy Dunlap
2020-11-26  4:26       ` Vinod Koul
2020-11-26  4:26         ` Vinod Koul
2020-11-26  4:26         ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e0d74391-18ae-0493-b8a1-cbeb6f00bde8@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=jonathan@marek.ca \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=vkoul@kernel.org \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.