From: Yuehaibing <yuehaibing@huawei.com> To: Chen-Yu Tsai <wens@csie.org>, Stefan Mavrodiev <stefan@olimex.com> Cc: Vinod Koul <vkoul@kernel.org>, Dan Williams <dan.j.williams@intel.com>, Maxime Ripard <mripard@kernel.org>, "open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM" <dmaengine@vger.kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, linux-kernel <linux-kernel@vger.kernel.org> Subject: Re: [PATCH -next] dmaengine: sun4i: remove set but unused variable 'linear_mode' Date: Wed, 5 Feb 2020 14:29:04 +0800 [thread overview] Message-ID: <e125193f-b7b2-c3a8-2e09-925ba2116db0@huawei.com> (raw) In-Reply-To: <CAGb2v67gzb+8vR=6jQKX07pcARUqBHeburNWM9tqzqhfTnodGg@mail.gmail.com> On 2020/2/5 12:56, Chen-Yu Tsai wrote: > Hi, > > On Wed, Feb 5, 2020 at 12:43 PM YueHaibing <yuehaibing@huawei.com> wrote: >> >> drivers/dma/sun4i-dma.c: In function sun4i_dma_prep_dma_cyclic: >> drivers/dma/sun4i-dma.c:672:24: warning: >> variable linear_mode set but not used [-Wunused-but-set-variable] >> >> commit ffc079a4accc ("dmaengine: sun4i: Add support for cyclic requests with dedicated DMA") >> involved this unused variable. >> >> Reported-by: Hulk Robot <hulkci@huawei.com> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com> >> --- >> drivers/dma/sun4i-dma.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/dma/sun4i-dma.c b/drivers/dma/sun4i-dma.c >> index bbc2bda..501cd44 100644 >> --- a/drivers/dma/sun4i-dma.c >> +++ b/drivers/dma/sun4i-dma.c >> @@ -669,7 +669,7 @@ sun4i_dma_prep_dma_cyclic(struct dma_chan *chan, dma_addr_t buf, size_t len, >> dma_addr_t src, dest; >> u32 endpoints; >> int nr_periods, offset, plength, i; >> - u8 ram_type, io_mode, linear_mode; >> + u8 ram_type, io_mode; >> >> if (!is_slave_direction(dir)) { >> dev_err(chan2dev(chan), "Invalid DMA direction\n"); >> @@ -684,11 +684,9 @@ sun4i_dma_prep_dma_cyclic(struct dma_chan *chan, dma_addr_t buf, size_t len, >> >> if (vchan->is_dedicated) { >> io_mode = SUN4I_DDMA_ADDR_MODE_IO; >> - linear_mode = SUN4I_DDMA_ADDR_MODE_LINEAR; >> ram_type = SUN4I_DDMA_DRQ_TYPE_SDRAM; >> } else { >> io_mode = SUN4I_NDMA_ADDR_MODE_IO; >> - linear_mode = SUN4I_NDMA_ADDR_MODE_LINEAR; >> ram_type = SUN4I_NDMA_DRQ_TYPE_SDRAM; >> } > > I think it's better to actually use these values later when composing > the value for `endpoints`, as we do in sun4i_dma_prep_slave_sg(). > > The code currently works because SUN4I_DDMA_ADDR_MODE_LINEAR == 0. > However explicitly using the value makes the code more readable, > and doesn't require the reader to have implicit knowledge of default > values for parameters not specified in the composition of `endpoints`. Thanks, will send v2. > > ChenYu > > . >
WARNING: multiple messages have this Message-ID (diff)
From: Yuehaibing <yuehaibing@huawei.com> To: Chen-Yu Tsai <wens@csie.org>, Stefan Mavrodiev <stefan@olimex.com> Cc: linux-kernel <linux-kernel@vger.kernel.org>, Maxime Ripard <mripard@kernel.org>, Vinod Koul <vkoul@kernel.org>, "open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM" <dmaengine@vger.kernel.org>, Dan Williams <dan.j.williams@intel.com>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH -next] dmaengine: sun4i: remove set but unused variable 'linear_mode' Date: Wed, 5 Feb 2020 14:29:04 +0800 [thread overview] Message-ID: <e125193f-b7b2-c3a8-2e09-925ba2116db0@huawei.com> (raw) In-Reply-To: <CAGb2v67gzb+8vR=6jQKX07pcARUqBHeburNWM9tqzqhfTnodGg@mail.gmail.com> On 2020/2/5 12:56, Chen-Yu Tsai wrote: > Hi, > > On Wed, Feb 5, 2020 at 12:43 PM YueHaibing <yuehaibing@huawei.com> wrote: >> >> drivers/dma/sun4i-dma.c: In function sun4i_dma_prep_dma_cyclic: >> drivers/dma/sun4i-dma.c:672:24: warning: >> variable linear_mode set but not used [-Wunused-but-set-variable] >> >> commit ffc079a4accc ("dmaengine: sun4i: Add support for cyclic requests with dedicated DMA") >> involved this unused variable. >> >> Reported-by: Hulk Robot <hulkci@huawei.com> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com> >> --- >> drivers/dma/sun4i-dma.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/dma/sun4i-dma.c b/drivers/dma/sun4i-dma.c >> index bbc2bda..501cd44 100644 >> --- a/drivers/dma/sun4i-dma.c >> +++ b/drivers/dma/sun4i-dma.c >> @@ -669,7 +669,7 @@ sun4i_dma_prep_dma_cyclic(struct dma_chan *chan, dma_addr_t buf, size_t len, >> dma_addr_t src, dest; >> u32 endpoints; >> int nr_periods, offset, plength, i; >> - u8 ram_type, io_mode, linear_mode; >> + u8 ram_type, io_mode; >> >> if (!is_slave_direction(dir)) { >> dev_err(chan2dev(chan), "Invalid DMA direction\n"); >> @@ -684,11 +684,9 @@ sun4i_dma_prep_dma_cyclic(struct dma_chan *chan, dma_addr_t buf, size_t len, >> >> if (vchan->is_dedicated) { >> io_mode = SUN4I_DDMA_ADDR_MODE_IO; >> - linear_mode = SUN4I_DDMA_ADDR_MODE_LINEAR; >> ram_type = SUN4I_DDMA_DRQ_TYPE_SDRAM; >> } else { >> io_mode = SUN4I_NDMA_ADDR_MODE_IO; >> - linear_mode = SUN4I_NDMA_ADDR_MODE_LINEAR; >> ram_type = SUN4I_NDMA_DRQ_TYPE_SDRAM; >> } > > I think it's better to actually use these values later when composing > the value for `endpoints`, as we do in sun4i_dma_prep_slave_sg(). > > The code currently works because SUN4I_DDMA_ADDR_MODE_LINEAR == 0. > However explicitly using the value makes the code more readable, > and doesn't require the reader to have implicit knowledge of default > values for parameters not specified in the composition of `endpoints`. Thanks, will send v2. > > ChenYu > > . > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-05 6:29 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-05 4:42 [PATCH -next] dmaengine: sun4i: remove set but unused variable 'linear_mode' YueHaibing 2020-02-05 4:42 ` YueHaibing 2020-02-05 4:56 ` Chen-Yu Tsai 2020-02-05 4:56 ` Chen-Yu Tsai 2020-02-05 6:29 ` Yuehaibing [this message] 2020-02-05 6:29 ` Yuehaibing 2020-02-07 2:44 ` [PATCH v2 -next] dmaengine: sun4i: use 'linear_mode' in sun4i_dma_prep_dma_cyclic YueHaibing 2020-02-07 2:44 ` YueHaibing
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e125193f-b7b2-c3a8-2e09-925ba2116db0@huawei.com \ --to=yuehaibing@huawei.com \ --cc=dan.j.williams@intel.com \ --cc=dmaengine@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mripard@kernel.org \ --cc=stefan@olimex.com \ --cc=vkoul@kernel.org \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.