From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Viacheslav Bocharov <adeep@lexina.in>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 4/4] firmware: meson_sm: use meson_gx_socinfo for compatibility
Date: Thu, 2 Nov 2023 10:26:40 +0100 [thread overview]
Message-ID: <e1fe390e-e0d4-475a-a83b-31c2d179e009@linaro.org> (raw)
In-Reply-To: <20231102074916.3280809-5-adeep@lexina.in>
On 02/11/2023 08:49, Viacheslav Bocharov wrote:
> Use meson_gx_socinfo variable for chipid compatible call
> from meson-gx-socinfo driver if available.
>
So we are back to something like ARMv7 platform/mach-code with drivers
tightly coupled between subsystems. But it is not 2007 anymore and we
have Devicetree for this. Use it instead.
What's more, your commit msg does not explain at all why do you need to
do it. This is some "show" callback, which does not exist in current
code. Adding code in one patch and then changing it, looks like you add
incomplete or buggy feature.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Viacheslav Bocharov <adeep@lexina.in>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 4/4] firmware: meson_sm: use meson_gx_socinfo for compatibility
Date: Thu, 2 Nov 2023 10:26:40 +0100 [thread overview]
Message-ID: <e1fe390e-e0d4-475a-a83b-31c2d179e009@linaro.org> (raw)
In-Reply-To: <20231102074916.3280809-5-adeep@lexina.in>
On 02/11/2023 08:49, Viacheslav Bocharov wrote:
> Use meson_gx_socinfo variable for chipid compatible call
> from meson-gx-socinfo driver if available.
>
So we are back to something like ARMv7 platform/mach-code with drivers
tightly coupled between subsystems. But it is not 2007 anymore and we
have Devicetree for this. Use it instead.
What's more, your commit msg does not explain at all why do you need to
do it. This is some "show" callback, which does not exist in current
code. Adding code in one patch and then changing it, looks like you add
incomplete or buggy feature.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Viacheslav Bocharov <adeep@lexina.in>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 4/4] firmware: meson_sm: use meson_gx_socinfo for compatibility
Date: Thu, 2 Nov 2023 10:26:40 +0100 [thread overview]
Message-ID: <e1fe390e-e0d4-475a-a83b-31c2d179e009@linaro.org> (raw)
In-Reply-To: <20231102074916.3280809-5-adeep@lexina.in>
On 02/11/2023 08:49, Viacheslav Bocharov wrote:
> Use meson_gx_socinfo variable for chipid compatible call
> from meson-gx-socinfo driver if available.
>
So we are back to something like ARMv7 platform/mach-code with drivers
tightly coupled between subsystems. But it is not 2007 anymore and we
have Devicetree for this. Use it instead.
What's more, your commit msg does not explain at all why do you need to
do it. This is some "show" callback, which does not exist in current
code. Adding code in one patch and then changing it, looks like you add
incomplete or buggy feature.
Best regards,
Krzysztof
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2023-11-02 9:26 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 7:49 [PATCH 0/4] RFC: firmware: meson-sm: add chipid sysfs export Viacheslav Bocharov
2023-11-02 7:49 ` Viacheslav Bocharov
2023-11-02 7:49 ` Viacheslav Bocharov
2023-11-02 7:49 ` [PATCH 1/4] firmware: meson-sm: change sprintf to scnprintf Viacheslav Bocharov
2023-11-02 7:49 ` Viacheslav Bocharov
2023-11-02 7:49 ` Viacheslav Bocharov
2023-11-02 7:49 ` [PATCH 2/4] firmware: meson_sm: Add chipid number sysfs entry Viacheslav Bocharov
2023-11-02 7:49 ` Viacheslav Bocharov
2023-11-02 7:49 ` Viacheslav Bocharov
2023-11-02 22:11 ` kernel test robot
2023-11-02 22:11 ` kernel test robot
2023-11-02 22:11 ` kernel test robot
2023-11-02 7:49 ` [PATCH 3/4] soc: amlogic: meson-gx-socinfo: export socinfo for use in other modules Viacheslav Bocharov
2023-11-02 7:49 ` Viacheslav Bocharov
2023-11-02 7:49 ` Viacheslav Bocharov
2023-11-02 9:23 ` Krzysztof Kozlowski
2023-11-02 9:23 ` Krzysztof Kozlowski
2023-11-02 9:23 ` Krzysztof Kozlowski
2023-11-02 7:49 ` [PATCH 4/4] firmware: meson_sm: use meson_gx_socinfo for compatibility Viacheslav Bocharov
2023-11-02 7:49 ` Viacheslav Bocharov
2023-11-02 7:49 ` Viacheslav Bocharov
2023-11-02 9:26 ` Krzysztof Kozlowski [this message]
2023-11-02 9:26 ` Krzysztof Kozlowski
2023-11-02 9:26 ` Krzysztof Kozlowski
2023-11-02 10:02 ` Viacheslav
2023-11-02 10:02 ` Viacheslav
2023-11-02 10:02 ` Viacheslav
2023-11-03 0:22 ` kernel test robot
2023-11-03 0:22 ` kernel test robot
2023-11-03 0:22 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1fe390e-e0d4-475a-a83b-31c2d179e009@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=adeep@lexina.in \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.