From: Helen Koike <helen.koike@collabora.com>
To: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
linux-media@vger.kernel.org
Cc: laurent.pinchart@ideasonboard.com, ezequiel@collabora.com,
hverkuil@xs4all.nl, kernel@collabora.com, dafna3@gmail.com,
sakari.ailus@linux.intel.com, linux-rockchip@lists.infradead.org,
mchehab@kernel.org, tfiga@chromium.org
Subject: Re: [PATCH 2/4] media: staging: rkisp1: params: remove unnecessary "!!"
Date: Tue, 20 Oct 2020 14:13:15 -0300 [thread overview]
Message-ID: <e228b9ca-58a6-b70d-ff8d-d0e73f09d276@collabora.com> (raw)
In-Reply-To: <20201019205956.6980-3-dafna.hirschfeld@collabora.com>
On 10/19/20 5:59 PM, Dafna Hirschfeld wrote:
> There are several 'if' conditions of the form:
>
> if (!!(module_ens & SOME_FLAG))
>
> Those can be replaced with:
>
> if (module_ens & SOME_FLAG)
>
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
Acked-by: Helen Koike <helen.koike@collabora.com>
Thanks
Helen
> ---
> drivers/staging/media/rkisp1/rkisp1-params.c | 24 ++++++++++----------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/staging/media/rkisp1/rkisp1-params.c b/drivers/staging/media/rkisp1/rkisp1-params.c
> index 986d293201e6..4ac401bc2164 100644
> --- a/drivers/staging/media/rkisp1/rkisp1-params.c
> +++ b/drivers/staging/media/rkisp1/rkisp1-params.c
> @@ -896,7 +896,7 @@ rkisp1_isp_isr_other_config(struct rkisp1_params *params,
> &new_params->others.dpcc_config);
>
> if (module_en_update & RKISP1_CIF_ISP_MODULE_DPCC) {
> - if (!!(module_ens & RKISP1_CIF_ISP_MODULE_DPCC))
> + if (module_ens & RKISP1_CIF_ISP_MODULE_DPCC)
> rkisp1_param_set_bits(params,
> RKISP1_CIF_ISP_DPCC_MODE,
> RKISP1_CIF_ISP_DPCC_ENA);
> @@ -915,7 +915,7 @@ rkisp1_isp_isr_other_config(struct rkisp1_params *params,
> &new_params->others.bls_config);
>
> if (module_en_update & RKISP1_CIF_ISP_MODULE_BLS) {
> - if (!!(module_ens & RKISP1_CIF_ISP_MODULE_BLS))
> + if (module_ens & RKISP1_CIF_ISP_MODULE_BLS)
> rkisp1_param_set_bits(params,
> RKISP1_CIF_ISP_BLS_CTRL,
> RKISP1_CIF_ISP_BLS_ENA);
> @@ -934,7 +934,7 @@ rkisp1_isp_isr_other_config(struct rkisp1_params *params,
> &new_params->others.sdg_config);
>
> if (module_en_update & RKISP1_CIF_ISP_MODULE_SDG) {
> - if (!!(module_ens & RKISP1_CIF_ISP_MODULE_SDG))
> + if (module_ens & RKISP1_CIF_ISP_MODULE_SDG)
> rkisp1_param_set_bits(params,
> RKISP1_CIF_ISP_CTRL,
> RKISP1_CIF_ISP_CTRL_ISP_GAMMA_IN_ENA);
> @@ -953,7 +953,7 @@ rkisp1_isp_isr_other_config(struct rkisp1_params *params,
> &new_params->others.lsc_config);
>
> if (module_en_update & RKISP1_CIF_ISP_MODULE_LSC) {
> - if (!!(module_ens & RKISP1_CIF_ISP_MODULE_LSC))
> + if (module_ens & RKISP1_CIF_ISP_MODULE_LSC)
> rkisp1_param_set_bits(params,
> RKISP1_CIF_ISP_LSC_CTRL,
> RKISP1_CIF_ISP_LSC_CTRL_ENA);
> @@ -972,7 +972,7 @@ rkisp1_isp_isr_other_config(struct rkisp1_params *params,
> &new_params->others.awb_gain_config);
>
> if (module_en_update & RKISP1_CIF_ISP_MODULE_AWB_GAIN) {
> - if (!!(module_ens & RKISP1_CIF_ISP_MODULE_AWB_GAIN))
> + if (module_ens & RKISP1_CIF_ISP_MODULE_AWB_GAIN)
> rkisp1_param_set_bits(params,
> RKISP1_CIF_ISP_CTRL,
> RKISP1_CIF_ISP_CTRL_ISP_AWB_ENA);
> @@ -991,7 +991,7 @@ rkisp1_isp_isr_other_config(struct rkisp1_params *params,
> &new_params->others.bdm_config);
>
> if (module_en_update & RKISP1_CIF_ISP_MODULE_BDM) {
> - if (!!(module_ens & RKISP1_CIF_ISP_MODULE_BDM))
> + if (module_ens & RKISP1_CIF_ISP_MODULE_BDM)
> rkisp1_param_set_bits(params,
> RKISP1_CIF_ISP_DEMOSAIC,
> RKISP1_CIF_ISP_DEMOSAIC_BYPASS);
> @@ -1010,7 +1010,7 @@ rkisp1_isp_isr_other_config(struct rkisp1_params *params,
> &new_params->others.flt_config);
>
> if (module_en_update & RKISP1_CIF_ISP_MODULE_FLT) {
> - if (!!(module_ens & RKISP1_CIF_ISP_MODULE_FLT))
> + if (module_ens & RKISP1_CIF_ISP_MODULE_FLT)
> rkisp1_param_set_bits(params,
> RKISP1_CIF_ISP_FILT_MODE,
> RKISP1_CIF_ISP_FLT_ENA);
> @@ -1041,7 +1041,7 @@ rkisp1_isp_isr_other_config(struct rkisp1_params *params,
> &new_params->others.goc_config);
>
> if (module_en_update & RKISP1_CIF_ISP_MODULE_GOC) {
> - if (!!(module_ens & RKISP1_CIF_ISP_MODULE_GOC))
> + if (module_ens & RKISP1_CIF_ISP_MODULE_GOC)
> rkisp1_param_set_bits(params,
> RKISP1_CIF_ISP_CTRL,
> RKISP1_CIF_ISP_CTRL_ISP_GAMMA_OUT_ENA);
> @@ -1061,7 +1061,7 @@ rkisp1_isp_isr_other_config(struct rkisp1_params *params,
> }
>
> if (module_en_update & RKISP1_CIF_ISP_MODULE_CPROC) {
> - if (!!(module_ens & RKISP1_CIF_ISP_MODULE_CPROC))
> + if (module_ens & RKISP1_CIF_ISP_MODULE_CPROC)
> rkisp1_param_set_bits(params,
> RKISP1_CIF_C_PROC_CTRL,
> RKISP1_CIF_C_PROC_CTR_ENABLE);
> @@ -1092,7 +1092,7 @@ rkisp1_isp_isr_other_config(struct rkisp1_params *params,
> &new_params->others.dpf_config);
>
> if (module_en_update & RKISP1_CIF_ISP_MODULE_DPF) {
> - if (!!(module_ens & RKISP1_CIF_ISP_MODULE_DPF))
> + if (module_ens & RKISP1_CIF_ISP_MODULE_DPF)
> rkisp1_param_set_bits(params,
> RKISP1_CIF_ISP_DPF_MODE,
> RKISP1_CIF_ISP_DPF_MODE_EN);
> @@ -1141,7 +1141,7 @@ static void rkisp1_isp_isr_meas_config(struct rkisp1_params *params,
> &new_params->meas.afc_config);
>
> if (module_en_update & RKISP1_CIF_ISP_MODULE_AFC) {
> - if (!!(module_ens & RKISP1_CIF_ISP_MODULE_AFC))
> + if (module_ens & RKISP1_CIF_ISP_MODULE_AFC)
> rkisp1_param_set_bits(params,
> RKISP1_CIF_ISP_AFM_CTRL,
> RKISP1_CIF_ISP_AFM_ENA);
> @@ -1173,7 +1173,7 @@ static void rkisp1_isp_isr_meas_config(struct rkisp1_params *params,
> &new_params->meas.aec_config);
>
> if (module_en_update & RKISP1_CIF_ISP_MODULE_AEC) {
> - if (!!(module_ens & RKISP1_CIF_ISP_MODULE_AEC))
> + if (module_ens & RKISP1_CIF_ISP_MODULE_AEC)
> rkisp1_param_set_bits(params,
> RKISP1_CIF_ISP_EXP_CTRL,
> RKISP1_CIF_ISP_EXP_ENA);
>
WARNING: multiple messages have this Message-ID (diff)
From: Helen Koike <helen.koike@collabora.com>
To: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
linux-media@vger.kernel.org
Cc: mchehab@kernel.org, dafna3@gmail.com, tfiga@chromium.org,
hverkuil@xs4all.nl, linux-rockchip@lists.infradead.org,
laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com,
kernel@collabora.com, ezequiel@collabora.com
Subject: Re: [PATCH 2/4] media: staging: rkisp1: params: remove unnecessary "!!"
Date: Tue, 20 Oct 2020 14:13:15 -0300 [thread overview]
Message-ID: <e228b9ca-58a6-b70d-ff8d-d0e73f09d276@collabora.com> (raw)
In-Reply-To: <20201019205956.6980-3-dafna.hirschfeld@collabora.com>
On 10/19/20 5:59 PM, Dafna Hirschfeld wrote:
> There are several 'if' conditions of the form:
>
> if (!!(module_ens & SOME_FLAG))
>
> Those can be replaced with:
>
> if (module_ens & SOME_FLAG)
>
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
Acked-by: Helen Koike <helen.koike@collabora.com>
Thanks
Helen
> ---
> drivers/staging/media/rkisp1/rkisp1-params.c | 24 ++++++++++----------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/staging/media/rkisp1/rkisp1-params.c b/drivers/staging/media/rkisp1/rkisp1-params.c
> index 986d293201e6..4ac401bc2164 100644
> --- a/drivers/staging/media/rkisp1/rkisp1-params.c
> +++ b/drivers/staging/media/rkisp1/rkisp1-params.c
> @@ -896,7 +896,7 @@ rkisp1_isp_isr_other_config(struct rkisp1_params *params,
> &new_params->others.dpcc_config);
>
> if (module_en_update & RKISP1_CIF_ISP_MODULE_DPCC) {
> - if (!!(module_ens & RKISP1_CIF_ISP_MODULE_DPCC))
> + if (module_ens & RKISP1_CIF_ISP_MODULE_DPCC)
> rkisp1_param_set_bits(params,
> RKISP1_CIF_ISP_DPCC_MODE,
> RKISP1_CIF_ISP_DPCC_ENA);
> @@ -915,7 +915,7 @@ rkisp1_isp_isr_other_config(struct rkisp1_params *params,
> &new_params->others.bls_config);
>
> if (module_en_update & RKISP1_CIF_ISP_MODULE_BLS) {
> - if (!!(module_ens & RKISP1_CIF_ISP_MODULE_BLS))
> + if (module_ens & RKISP1_CIF_ISP_MODULE_BLS)
> rkisp1_param_set_bits(params,
> RKISP1_CIF_ISP_BLS_CTRL,
> RKISP1_CIF_ISP_BLS_ENA);
> @@ -934,7 +934,7 @@ rkisp1_isp_isr_other_config(struct rkisp1_params *params,
> &new_params->others.sdg_config);
>
> if (module_en_update & RKISP1_CIF_ISP_MODULE_SDG) {
> - if (!!(module_ens & RKISP1_CIF_ISP_MODULE_SDG))
> + if (module_ens & RKISP1_CIF_ISP_MODULE_SDG)
> rkisp1_param_set_bits(params,
> RKISP1_CIF_ISP_CTRL,
> RKISP1_CIF_ISP_CTRL_ISP_GAMMA_IN_ENA);
> @@ -953,7 +953,7 @@ rkisp1_isp_isr_other_config(struct rkisp1_params *params,
> &new_params->others.lsc_config);
>
> if (module_en_update & RKISP1_CIF_ISP_MODULE_LSC) {
> - if (!!(module_ens & RKISP1_CIF_ISP_MODULE_LSC))
> + if (module_ens & RKISP1_CIF_ISP_MODULE_LSC)
> rkisp1_param_set_bits(params,
> RKISP1_CIF_ISP_LSC_CTRL,
> RKISP1_CIF_ISP_LSC_CTRL_ENA);
> @@ -972,7 +972,7 @@ rkisp1_isp_isr_other_config(struct rkisp1_params *params,
> &new_params->others.awb_gain_config);
>
> if (module_en_update & RKISP1_CIF_ISP_MODULE_AWB_GAIN) {
> - if (!!(module_ens & RKISP1_CIF_ISP_MODULE_AWB_GAIN))
> + if (module_ens & RKISP1_CIF_ISP_MODULE_AWB_GAIN)
> rkisp1_param_set_bits(params,
> RKISP1_CIF_ISP_CTRL,
> RKISP1_CIF_ISP_CTRL_ISP_AWB_ENA);
> @@ -991,7 +991,7 @@ rkisp1_isp_isr_other_config(struct rkisp1_params *params,
> &new_params->others.bdm_config);
>
> if (module_en_update & RKISP1_CIF_ISP_MODULE_BDM) {
> - if (!!(module_ens & RKISP1_CIF_ISP_MODULE_BDM))
> + if (module_ens & RKISP1_CIF_ISP_MODULE_BDM)
> rkisp1_param_set_bits(params,
> RKISP1_CIF_ISP_DEMOSAIC,
> RKISP1_CIF_ISP_DEMOSAIC_BYPASS);
> @@ -1010,7 +1010,7 @@ rkisp1_isp_isr_other_config(struct rkisp1_params *params,
> &new_params->others.flt_config);
>
> if (module_en_update & RKISP1_CIF_ISP_MODULE_FLT) {
> - if (!!(module_ens & RKISP1_CIF_ISP_MODULE_FLT))
> + if (module_ens & RKISP1_CIF_ISP_MODULE_FLT)
> rkisp1_param_set_bits(params,
> RKISP1_CIF_ISP_FILT_MODE,
> RKISP1_CIF_ISP_FLT_ENA);
> @@ -1041,7 +1041,7 @@ rkisp1_isp_isr_other_config(struct rkisp1_params *params,
> &new_params->others.goc_config);
>
> if (module_en_update & RKISP1_CIF_ISP_MODULE_GOC) {
> - if (!!(module_ens & RKISP1_CIF_ISP_MODULE_GOC))
> + if (module_ens & RKISP1_CIF_ISP_MODULE_GOC)
> rkisp1_param_set_bits(params,
> RKISP1_CIF_ISP_CTRL,
> RKISP1_CIF_ISP_CTRL_ISP_GAMMA_OUT_ENA);
> @@ -1061,7 +1061,7 @@ rkisp1_isp_isr_other_config(struct rkisp1_params *params,
> }
>
> if (module_en_update & RKISP1_CIF_ISP_MODULE_CPROC) {
> - if (!!(module_ens & RKISP1_CIF_ISP_MODULE_CPROC))
> + if (module_ens & RKISP1_CIF_ISP_MODULE_CPROC)
> rkisp1_param_set_bits(params,
> RKISP1_CIF_C_PROC_CTRL,
> RKISP1_CIF_C_PROC_CTR_ENABLE);
> @@ -1092,7 +1092,7 @@ rkisp1_isp_isr_other_config(struct rkisp1_params *params,
> &new_params->others.dpf_config);
>
> if (module_en_update & RKISP1_CIF_ISP_MODULE_DPF) {
> - if (!!(module_ens & RKISP1_CIF_ISP_MODULE_DPF))
> + if (module_ens & RKISP1_CIF_ISP_MODULE_DPF)
> rkisp1_param_set_bits(params,
> RKISP1_CIF_ISP_DPF_MODE,
> RKISP1_CIF_ISP_DPF_MODE_EN);
> @@ -1141,7 +1141,7 @@ static void rkisp1_isp_isr_meas_config(struct rkisp1_params *params,
> &new_params->meas.afc_config);
>
> if (module_en_update & RKISP1_CIF_ISP_MODULE_AFC) {
> - if (!!(module_ens & RKISP1_CIF_ISP_MODULE_AFC))
> + if (module_ens & RKISP1_CIF_ISP_MODULE_AFC)
> rkisp1_param_set_bits(params,
> RKISP1_CIF_ISP_AFM_CTRL,
> RKISP1_CIF_ISP_AFM_ENA);
> @@ -1173,7 +1173,7 @@ static void rkisp1_isp_isr_meas_config(struct rkisp1_params *params,
> &new_params->meas.aec_config);
>
> if (module_en_update & RKISP1_CIF_ISP_MODULE_AEC) {
> - if (!!(module_ens & RKISP1_CIF_ISP_MODULE_AEC))
> + if (module_ens & RKISP1_CIF_ISP_MODULE_AEC)
> rkisp1_param_set_bits(params,
> RKISP1_CIF_ISP_EXP_CTRL,
> RKISP1_CIF_ISP_EXP_ENA);
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2020-10-20 17:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 20:59 [PATCH 0/4] media: staging: rkisp1: send cleanups and checkpatch fixes Dafna Hirschfeld
2020-10-19 20:59 ` Dafna Hirschfeld
2020-10-19 20:59 ` [PATCH 1/4] media: staging: rkisp1: fix coding style issues Dafna Hirschfeld
2020-10-19 20:59 ` Dafna Hirschfeld
2020-10-20 17:13 ` Helen Koike
2020-10-20 17:13 ` Helen Koike
2020-10-19 20:59 ` [PATCH 2/4] media: staging: rkisp1: params: remove unnecessary "!!" Dafna Hirschfeld
2020-10-19 20:59 ` Dafna Hirschfeld
2020-10-20 17:13 ` Helen Koike [this message]
2020-10-20 17:13 ` Helen Koike
2020-10-19 20:59 ` [PATCH 3/4] media: staging: rkisp1: params: remove unnecessary parentheses Dafna Hirschfeld
2020-10-19 20:59 ` Dafna Hirschfeld
2020-10-20 17:13 ` Helen Koike
2020-10-20 17:13 ` Helen Koike
2020-10-19 20:59 ` [PATCH 4/4] media: staging: rkisp1: params: remove extra 'if' conditions Dafna Hirschfeld
2020-10-19 20:59 ` Dafna Hirschfeld
2020-10-20 17:13 ` Helen Koike
2020-10-20 17:13 ` Helen Koike
2020-10-20 17:21 ` Dafna Hirschfeld
2020-10-20 17:21 ` Dafna Hirschfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e228b9ca-58a6-b70d-ff8d-d0e73f09d276@collabora.com \
--to=helen.koike@collabora.com \
--cc=dafna.hirschfeld@collabora.com \
--cc=dafna3@gmail.com \
--cc=ezequiel@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=kernel@collabora.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.