From: <allen.chen@ite.com.tw> To: <robh@kernel.org>, <laurent.pinchart@ideasonboard.com> Cc: <treapking@chromium.org>, <Jau-Chih.Tseng@ite.com.tw>, <Kenneth.Hung@ite.com.tw>, <Hermes.Wu@ite.com.tw>, <andrzej.hajda@intel.com>, <narmstrong@baylibre.com>, <robert.foss@linaro.org>, <jonas@kwiboo.se>, <jernej.skrabec@gmail.com>, <airlied@linux.ie>, <daniel@ffwll.ch>, <krzysztof.kozlowski+dt@linaro.org>, <dri-devel@lists.freedesktop.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org> Subject: RE: [PATCH v4 1/2] dt-bindings: it6505: add properties to restrict output bandwidth Date: Fri, 14 Oct 2022 03:28:31 +0000 [thread overview] Message-ID: <e24a52c109444452a9027d53a21d6ef0@ite.com.tw> (raw) In-Reply-To: <20221013192016.GA95717-robh@kernel.org> Hi -----Original Message----- From: Rob Herring <robh@kernel.org> Sent: Friday, October 14, 2022 3:20 AM To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>; Allen Chen (陳柏宇) <allen.chen@ite.com.tw> Cc: Pin-yen Lin <treapking@chromium.org>; Jau-Chih Tseng (曾昭智) <Jau-Chih.Tseng@ite.com.tw>; Kenneth Hung (洪家倫) <Kenneth.Hung@ite.com.tw>; Hermes Wu (吳佳宏) <Hermes.Wu@ite.com.tw>; Andrzej Hajda <andrzej.hajda@intel.com>; Neil Armstrong <narmstrong@baylibre.com>; Robert Foss <robert.foss@linaro.org>; Jonas Karlman <jonas@kwiboo.se>; Jernej Skrabec <jernej.skrabec@gmail.com>; David Airlie <airlied@linux.ie>; Daniel Vetter <daniel@ffwll.ch>; Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; open list:DRM DRIVERS <dri-devel@lists.freedesktop.org>; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS <devicetree@vger.kernel.org>; open list <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v4 1/2] dt-bindings: it6505: add properties to restrict output bandwidth On Thu, Oct 13, 2022 at 02:05:45PM +0300, Laurent Pinchart wrote: > Hi Allen, > > Thank you for the patch. > > On Thu, Oct 13, 2022 at 06:51:13PM +0800, allen wrote: > > From: allen chen <allen.chen@ite.com.tw> > > > > Add properties to restrict dp output data-lanes and clock. > > > > Signed-off-by: Pin-Yen Lin <treapking@chromium.org> > > Signed-off-by: Allen Chen <allen.chen@ite.com.tw> > > --- > > .../bindings/display/bridge/ite,it6505.yaml | 43 +++++++++++++++++++ > > 1 file changed, 43 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml > > b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml > > index 833d11b2303a7..f2c3d1d10359e 100644 > > --- > > a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml > > +++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.ya > > +++ ml > > @@ -52,10 +52,51 @@ properties: > > maxItems: 1 > > description: extcon specifier for the Power Delivery > > > > + data-lanes: > > + oneOf: > > + - minItems: 1 > > + maxItems: 1 > > + uniqueItems: true > > + items: > > + enum: > > + - 0 > > + - 1 > > + description: For one lane operation. > > + > > + - minItems: 2 > > + maxItems: 2 > > + uniqueItems: true > > + items: > > + enum: > > + - 0 > > + - 1 > > + description: For two lanes operation. > > + > > + - minItems: 4 > > + maxItems: 4 > > + uniqueItems: true > > + items: > > + enum: > > + - 0 > > + - 1 > > + - 2 > > + - 3 > > + description: For four lanes operation. > > The data lanes should be in the output endpoint. If there's no output > port, one should be added. > ==> In this dt-binding, our output point is "extcon" so doesn't have output endpoint. I don't know how to add the endpoint. If need to add the endpoint to this dt-binding, what is your recommend about adding the endpoint? By the way, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> said we could put "data-lanes" here. > > + > > port: > > $ref: /schemas/graph.yaml#/properties/port To fix the error, this must be: $ref: /schemas/graph.yaml#/$defs/port-base unevaluatedProperties: false > > description: A port node pointing to DPI host port node > > > > + properties: > > + endpoint: > > + $ref: /schemas/graph.yaml#/$defs/endpoint-base > > + > > + properties: > > + link-frequencies: > > + minItems: 1 > > + maxItems: 1 > > + description: Allowed max link frequencies in Hz. > > + > > required: > > - compatible > > - ovdd-supply > > @@ -84,10 +125,12 @@ examples: > > pwr18-supply = <&it6505_pp18_reg>; > > reset-gpios = <&pio 179 1>; > > extcon = <&usbc_extcon>; > > + data-lanes = <0 1>; > > > > port { > > it6505_in: endpoint { > > remote-endpoint = <&dpi_out>; > > + link-frequencies = /bits/ 64 <150000000>; > > }; > > }; > > }; > > -- > Regards, > > Laurent Pinchart >
WARNING: multiple messages have this Message-ID (diff)
From: <allen.chen@ite.com.tw> To: <robh@kernel.org>, <laurent.pinchart@ideasonboard.com> Cc: devicetree@vger.kernel.org, Kenneth.Hung@ite.com.tw, krzysztof.kozlowski+dt@linaro.org, narmstrong@baylibre.com, airlied@linux.ie, dri-devel@lists.freedesktop.org, Jau-Chih.Tseng@ite.com.tw, linux-kernel@vger.kernel.org, robert.foss@linaro.org, treapking@chromium.org, Hermes.Wu@ite.com.tw, jernej.skrabec@gmail.com, andrzej.hajda@intel.com, jonas@kwiboo.se Subject: RE: [PATCH v4 1/2] dt-bindings: it6505: add properties to restrict output bandwidth Date: Fri, 14 Oct 2022 03:28:31 +0000 [thread overview] Message-ID: <e24a52c109444452a9027d53a21d6ef0@ite.com.tw> (raw) In-Reply-To: <20221013192016.GA95717-robh@kernel.org> Hi -----Original Message----- From: Rob Herring <robh@kernel.org> Sent: Friday, October 14, 2022 3:20 AM To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>; Allen Chen (陳柏宇) <allen.chen@ite.com.tw> Cc: Pin-yen Lin <treapking@chromium.org>; Jau-Chih Tseng (曾昭智) <Jau-Chih.Tseng@ite.com.tw>; Kenneth Hung (洪家倫) <Kenneth.Hung@ite.com.tw>; Hermes Wu (吳佳宏) <Hermes.Wu@ite.com.tw>; Andrzej Hajda <andrzej.hajda@intel.com>; Neil Armstrong <narmstrong@baylibre.com>; Robert Foss <robert.foss@linaro.org>; Jonas Karlman <jonas@kwiboo.se>; Jernej Skrabec <jernej.skrabec@gmail.com>; David Airlie <airlied@linux.ie>; Daniel Vetter <daniel@ffwll.ch>; Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; open list:DRM DRIVERS <dri-devel@lists.freedesktop.org>; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS <devicetree@vger.kernel.org>; open list <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v4 1/2] dt-bindings: it6505: add properties to restrict output bandwidth On Thu, Oct 13, 2022 at 02:05:45PM +0300, Laurent Pinchart wrote: > Hi Allen, > > Thank you for the patch. > > On Thu, Oct 13, 2022 at 06:51:13PM +0800, allen wrote: > > From: allen chen <allen.chen@ite.com.tw> > > > > Add properties to restrict dp output data-lanes and clock. > > > > Signed-off-by: Pin-Yen Lin <treapking@chromium.org> > > Signed-off-by: Allen Chen <allen.chen@ite.com.tw> > > --- > > .../bindings/display/bridge/ite,it6505.yaml | 43 +++++++++++++++++++ > > 1 file changed, 43 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml > > b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml > > index 833d11b2303a7..f2c3d1d10359e 100644 > > --- > > a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml > > +++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.ya > > +++ ml > > @@ -52,10 +52,51 @@ properties: > > maxItems: 1 > > description: extcon specifier for the Power Delivery > > > > + data-lanes: > > + oneOf: > > + - minItems: 1 > > + maxItems: 1 > > + uniqueItems: true > > + items: > > + enum: > > + - 0 > > + - 1 > > + description: For one lane operation. > > + > > + - minItems: 2 > > + maxItems: 2 > > + uniqueItems: true > > + items: > > + enum: > > + - 0 > > + - 1 > > + description: For two lanes operation. > > + > > + - minItems: 4 > > + maxItems: 4 > > + uniqueItems: true > > + items: > > + enum: > > + - 0 > > + - 1 > > + - 2 > > + - 3 > > + description: For four lanes operation. > > The data lanes should be in the output endpoint. If there's no output > port, one should be added. > ==> In this dt-binding, our output point is "extcon" so doesn't have output endpoint. I don't know how to add the endpoint. If need to add the endpoint to this dt-binding, what is your recommend about adding the endpoint? By the way, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> said we could put "data-lanes" here. > > + > > port: > > $ref: /schemas/graph.yaml#/properties/port To fix the error, this must be: $ref: /schemas/graph.yaml#/$defs/port-base unevaluatedProperties: false > > description: A port node pointing to DPI host port node > > > > + properties: > > + endpoint: > > + $ref: /schemas/graph.yaml#/$defs/endpoint-base > > + > > + properties: > > + link-frequencies: > > + minItems: 1 > > + maxItems: 1 > > + description: Allowed max link frequencies in Hz. > > + > > required: > > - compatible > > - ovdd-supply > > @@ -84,10 +125,12 @@ examples: > > pwr18-supply = <&it6505_pp18_reg>; > > reset-gpios = <&pio 179 1>; > > extcon = <&usbc_extcon>; > > + data-lanes = <0 1>; > > > > port { > > it6505_in: endpoint { > > remote-endpoint = <&dpi_out>; > > + link-frequencies = /bits/ 64 <150000000>; > > }; > > }; > > }; > > -- > Regards, > > Laurent Pinchart >
next prev parent reply other threads:[~2022-10-14 3:28 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-10-13 10:51 [PATCH v4 0/2] *** IT6505 driver read dt properties *** allen 2022-10-13 10:51 ` allen 2022-10-13 10:51 ` [PATCH v4 1/2] dt-bindings: it6505: add properties to restrict output bandwidth allen 2022-10-13 10:51 ` allen 2022-10-13 11:05 ` Laurent Pinchart 2022-10-13 11:05 ` Laurent Pinchart 2022-10-13 19:20 ` Rob Herring 2022-10-13 19:20 ` Rob Herring 2022-10-14 3:28 ` allen.chen [this message] 2022-10-14 3:28 ` allen.chen 2022-10-15 18:28 ` Laurent Pinchart 2022-10-15 18:28 ` Laurent Pinchart 2022-10-13 15:55 ` Rob Herring 2022-10-13 15:55 ` Rob Herring 2022-10-13 10:51 ` [PATCH v4 2/2] drm/bridge: add it6505 driver to read data-lanes and link-frequencies from dt allen 2022-10-13 10:51 ` allen 2022-10-13 18:42 ` kernel test robot 2022-10-13 18:42 ` kernel test robot 2022-10-13 19:52 ` kernel test robot 2022-10-13 19:52 ` kernel test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e24a52c109444452a9027d53a21d6ef0@ite.com.tw \ --to=allen.chen@ite.com.tw \ --cc=Hermes.Wu@ite.com.tw \ --cc=Jau-Chih.Tseng@ite.com.tw \ --cc=Kenneth.Hung@ite.com.tw \ --cc=airlied@linux.ie \ --cc=andrzej.hajda@intel.com \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=jernej.skrabec@gmail.com \ --cc=jonas@kwiboo.se \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=narmstrong@baylibre.com \ --cc=robert.foss@linaro.org \ --cc=robh@kernel.org \ --cc=treapking@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.