From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Christophe ROULLIER <christophe.roullier@foss.st.com>, "David S . Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Alexandre Torgue <alexandre.torgue@foss.st.com>, Richard Cochran <richardcochran@gmail.com>, Jose Abreu <joabreu@synopsys.com>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org> Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] dt-bindings: net: add new property st,ext-phyclk in documentation for stm32 Date: Wed, 13 Mar 2024 14:06:20 +0100 [thread overview] Message-ID: <e2a98098-8ccd-4b8f-9a4b-1cbc0776a9c2@linaro.org> (raw) In-Reply-To: <50ee6122-b160-48ea-8c44-1046b5907d7c@foss.st.com> On 13/03/2024 11:39, Christophe ROULLIER wrote: > > On 3/8/24 09:28, Krzysztof Kozlowski wrote: >> On 07/03/2024 14:59, Christophe Roullier wrote: >>> Add property st,ext-phyclk to manage cases when PHY have no cristal/quartz >>> This property can be used with RMII phy without cristal 50Mhz and when we >>> want to select RCC clock instead of ETH_REF_CLK >>> Can be used also with RGMII phy with no cristal and we select RCC clock >>> instead of ETH_CLK125 >>> >> Nothing improved here. You say you add new property (wrote it explicitly >> in the subject), but where is it? Where is the user? >> >> I think we talked about this. Rob also asked quite clear: >> >>> That is obvious from the diff. What is not obvious is why we need a new >>> property and what is the problem with the existing ones. >> How did you solve it? > > Hi, > > I do not understand your questions. OK, I will clarify some questions, but are you sure that this question: "How did you solve it?" needs clarification? If so, then let me clarify: Rob pointed issue. How did you resolve Rob's comment? How did you address it? What changed in your patch, that Rob's comment should be considered as addressed/resolved/done? Now about my other question: "but where is it? Where is the user?" Your subject and commit message claim you add new property. This means such property was not existing so far in the Linux kernel. If you add new property in the binding, then I expect adding the user of that binding, thus my question: where is the user of that binding? > > That I would like to do, it is property "st,ext-phyclk" was introduced > in driver > > "drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c" in 2020, and YAML > was not updated at the time. Are you saying you document existing property or add a new one? > > Goal of this patch it is to update YAML to avoid dtbs check issue if > someone use this property : > > dtbs check issue : views/kernel/upstream/net-next/arch/arm/boot/dts/st/stm32mp157c-dk2.dtb: > ethernet@5800a000: Unevaluated properties are not allowed > ('st,ext-phyclk' was unexpected) So DTS uses it? Are my questions now clear? BTW, I asked some of them before and you just sent the same patch, so looks like ignored my questions. Best regards, Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Christophe ROULLIER <christophe.roullier@foss.st.com>, "David S . Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Alexandre Torgue <alexandre.torgue@foss.st.com>, Richard Cochran <richardcochran@gmail.com>, Jose Abreu <joabreu@synopsys.com>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org> Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] dt-bindings: net: add new property st,ext-phyclk in documentation for stm32 Date: Wed, 13 Mar 2024 14:06:20 +0100 [thread overview] Message-ID: <e2a98098-8ccd-4b8f-9a4b-1cbc0776a9c2@linaro.org> (raw) In-Reply-To: <50ee6122-b160-48ea-8c44-1046b5907d7c@foss.st.com> On 13/03/2024 11:39, Christophe ROULLIER wrote: > > On 3/8/24 09:28, Krzysztof Kozlowski wrote: >> On 07/03/2024 14:59, Christophe Roullier wrote: >>> Add property st,ext-phyclk to manage cases when PHY have no cristal/quartz >>> This property can be used with RMII phy without cristal 50Mhz and when we >>> want to select RCC clock instead of ETH_REF_CLK >>> Can be used also with RGMII phy with no cristal and we select RCC clock >>> instead of ETH_CLK125 >>> >> Nothing improved here. You say you add new property (wrote it explicitly >> in the subject), but where is it? Where is the user? >> >> I think we talked about this. Rob also asked quite clear: >> >>> That is obvious from the diff. What is not obvious is why we need a new >>> property and what is the problem with the existing ones. >> How did you solve it? > > Hi, > > I do not understand your questions. OK, I will clarify some questions, but are you sure that this question: "How did you solve it?" needs clarification? If so, then let me clarify: Rob pointed issue. How did you resolve Rob's comment? How did you address it? What changed in your patch, that Rob's comment should be considered as addressed/resolved/done? Now about my other question: "but where is it? Where is the user?" Your subject and commit message claim you add new property. This means such property was not existing so far in the Linux kernel. If you add new property in the binding, then I expect adding the user of that binding, thus my question: where is the user of that binding? > > That I would like to do, it is property "st,ext-phyclk" was introduced > in driver > > "drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c" in 2020, and YAML > was not updated at the time. Are you saying you document existing property or add a new one? > > Goal of this patch it is to update YAML to avoid dtbs check issue if > someone use this property : > > dtbs check issue : views/kernel/upstream/net-next/arch/arm/boot/dts/st/stm32mp157c-dk2.dtb: > ethernet@5800a000: Unevaluated properties are not allowed > ('st,ext-phyclk' was unexpected) So DTS uses it? Are my questions now clear? BTW, I asked some of them before and you just sent the same patch, so looks like ignored my questions. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-03-13 13:06 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-03-07 13:59 [PATCH v2 0/2] Add properties in dwmac-stm32 documentation Christophe Roullier 2024-03-07 13:59 ` Christophe Roullier 2024-03-07 13:59 ` [PATCH v2 1/2] dt-bindings: net: add phy-supply property for stm32 Christophe Roullier 2024-03-07 13:59 ` Christophe Roullier 2024-03-07 13:59 ` [PATCH v2 2/2] dt-bindings: net: add new property st,ext-phyclk in documentation " Christophe Roullier 2024-03-07 13:59 ` Christophe Roullier 2024-03-08 8:28 ` Krzysztof Kozlowski 2024-03-08 8:28 ` Krzysztof Kozlowski [not found] ` <50ee6122-b160-48ea-8c44-1046b5907d7c@foss.st.com> 2024-03-13 13:06 ` Krzysztof Kozlowski [this message] 2024-03-13 13:06 ` Krzysztof Kozlowski 2024-03-14 15:10 ` Christophe ROULLIER 2024-03-14 15:10 ` Christophe ROULLIER 2024-03-14 15:25 ` Krzysztof Kozlowski 2024-03-14 15:25 ` Krzysztof Kozlowski 2024-03-15 15:14 ` Christophe ROULLIER 2024-03-15 15:14 ` Christophe ROULLIER
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e2a98098-8ccd-4b8f-9a4b-1cbc0776a9c2@linaro.org \ --to=krzysztof.kozlowski@linaro.org \ --cc=alexandre.torgue@foss.st.com \ --cc=broonie@kernel.org \ --cc=christophe.roullier@foss.st.com \ --cc=conor+dt@kernel.org \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=edumazet@google.com \ --cc=joabreu@synopsys.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=kuba@kernel.org \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=mcoquelin.stm32@gmail.com \ --cc=netdev@vger.kernel.org \ --cc=pabeni@redhat.com \ --cc=richardcochran@gmail.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.