From: Randy Dunlap <rdunlap@infradead.org> To: Masahiro Yamada <yamada.masahiro@socionext.com>, Christoph Hellwig <hch@lst.de> Cc: Richard Weinberger <richard@nod.at>, Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>, linux-um@lists.infradead.org, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 4/9] kconfig: include common Kconfig files from top-level Kconfig Date: Mon, 16 Jul 2018 23:33:38 -0700 [thread overview] Message-ID: <e36e6b2c-0984-199e-8c19-3ec54b31c12e@infradead.org> (raw) In-Reply-To: <CAK7LNAT5dzU-SOvqwnDs=bn3WA1_fmDj2abETmoHUdUExVF+WA@mail.gmail.com> On 07/11/2018 05:21 AM, Masahiro Yamada wrote: > 2018-07-09 0:19 GMT+09:00 Christoph Hellwig <hch@lst.de>: >> Instead of duplicating the source statements in every architecture just >> do it once in the toplevel Kconfig file. >> >> Note that with this the inclusion of arch/$(SRCARCH/Kconfig moves out of >> the top-level Kconfig into arch/Kconfig so that don't violate ordering >> constraits while keeping a sensible menu structure. >> >> Signed-off-by: Christoph Hellwig <hch@lst.de> > > >> diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig >> index dd4f3d3e644f..7ab7b148181b 100644 >> --- a/arch/sh/Kconfig >> +++ b/arch/sh/Kconfig >> @@ -168,10 +168,6 @@ config PGTABLE_LEVELS >> default 3 if X2TLB >> default 2 >> >> -source "init/Kconfig" >> - >> -source "kernel/Kconfig.freezer" >> - >> menu "System type" >> >> # >> @@ -553,8 +549,6 @@ endchoice >> >> endif >> >> -source "arch/sh/mm/Kconfig" > > > I noticed at least sh is broken > because "arch/sh/mm/Kconfig" is no longer included by anyone. > > I am not doing further tests. > Hi, Thanks for noticing that. I have tested all $ARCH (except um) with "allmodconfig" and so far, arch/sh/ is the only one that has a problem. > > Please test *ALL* architectures. > > If possible, matrix tests (arch, config-target), where > arch = arm, arm64, ... > config-target = allyesconfig, allnoconfig, alldefconfig, ... > > > Note: > scripts/diffconf is helpful. > -- ~Randy
WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <rdunlap@infradead.org> To: Masahiro Yamada <yamada.masahiro@socionext.com>, Christoph Hellwig <hch@lst.de> Cc: Richard Weinberger <richard@nod.at>, linux-um@lists.infradead.org, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Linux Kbuild mailing list <linux-kbuild@vger.kernel.org> Subject: Re: [PATCH 4/9] kconfig: include common Kconfig files from top-level Kconfig Date: Mon, 16 Jul 2018 23:33:38 -0700 [thread overview] Message-ID: <e36e6b2c-0984-199e-8c19-3ec54b31c12e@infradead.org> (raw) In-Reply-To: <CAK7LNAT5dzU-SOvqwnDs=bn3WA1_fmDj2abETmoHUdUExVF+WA@mail.gmail.com> On 07/11/2018 05:21 AM, Masahiro Yamada wrote: > 2018-07-09 0:19 GMT+09:00 Christoph Hellwig <hch@lst.de>: >> Instead of duplicating the source statements in every architecture just >> do it once in the toplevel Kconfig file. >> >> Note that with this the inclusion of arch/$(SRCARCH/Kconfig moves out of >> the top-level Kconfig into arch/Kconfig so that don't violate ordering >> constraits while keeping a sensible menu structure. >> >> Signed-off-by: Christoph Hellwig <hch@lst.de> > > >> diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig >> index dd4f3d3e644f..7ab7b148181b 100644 >> --- a/arch/sh/Kconfig >> +++ b/arch/sh/Kconfig >> @@ -168,10 +168,6 @@ config PGTABLE_LEVELS >> default 3 if X2TLB >> default 2 >> >> -source "init/Kconfig" >> - >> -source "kernel/Kconfig.freezer" >> - >> menu "System type" >> >> # >> @@ -553,8 +549,6 @@ endchoice >> >> endif >> >> -source "arch/sh/mm/Kconfig" > > > I noticed at least sh is broken > because "arch/sh/mm/Kconfig" is no longer included by anyone. > > I am not doing further tests. > Hi, Thanks for noticing that. I have tested all $ARCH (except um) with "allmodconfig" and so far, arch/sh/ is the only one that has a problem. > > Please test *ALL* architectures. > > If possible, matrix tests (arch, config-target), where > arch = arm, arm64, ... > config-target = allyesconfig, allnoconfig, alldefconfig, ... > > > Note: > scripts/diffconf is helpful. > -- ~Randy _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um
next prev parent reply other threads:[~2018-07-17 6:33 UTC|newest] Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-07-08 15:19 include architecture Kconfig files from top-level Kconfig v2 Christoph Hellwig 2018-07-08 15:19 ` Christoph Hellwig 2018-07-08 15:19 ` [PATCH 1/9] um: stop abusing KBUILD_KCONFIG Christoph Hellwig 2018-07-08 15:19 ` Christoph Hellwig 2018-07-08 15:19 ` [PATCH 2/9] um: cleanup Kconfig files Christoph Hellwig 2018-07-08 15:19 ` [PATCH 3/9] um: create a proper drivers Kconfig Christoph Hellwig 2018-07-08 15:19 ` Christoph Hellwig 2018-07-08 15:19 ` [PATCH 4/9] kconfig: include common Kconfig files from top-level Kconfig Christoph Hellwig 2018-07-08 15:19 ` Christoph Hellwig 2018-07-11 12:21 ` Masahiro Yamada 2018-07-11 12:21 ` Masahiro Yamada 2018-07-17 6:33 ` Randy Dunlap [this message] 2018-07-17 6:33 ` Randy Dunlap 2018-07-17 6:42 ` Randy Dunlap 2018-07-17 6:42 ` Randy Dunlap 2018-07-17 6:44 ` Randy Dunlap 2018-07-17 6:44 ` Randy Dunlap 2018-07-17 6:55 ` Randy Dunlap 2018-07-17 6:55 ` Randy Dunlap 2018-07-17 13:00 ` Christoph Hellwig 2018-07-17 13:00 ` Christoph Hellwig 2018-07-17 12:59 ` Christoph Hellwig 2018-07-17 12:59 ` Christoph Hellwig 2018-07-18 7:06 ` Randy Dunlap 2018-07-18 7:06 ` Randy Dunlap 2018-07-19 13:11 ` Christoph Hellwig 2018-07-19 13:11 ` Christoph Hellwig 2018-07-20 19:57 ` Dirk Gouders 2018-07-20 19:57 ` Dirk Gouders 2018-07-08 15:20 ` [PATCH 5/9] Kconfig: consolidate the "Kernel hacking" menu Christoph Hellwig 2018-07-08 15:20 ` Christoph Hellwig 2018-07-08 16:34 ` Randy Dunlap 2018-07-08 16:34 ` Randy Dunlap 2018-07-08 15:20 ` [PATCH 6/9] kconfig: include kernel/Kconfig.preempt from init/Kconfig Christoph Hellwig 2018-07-08 15:20 ` Christoph Hellwig 2018-07-08 16:30 ` Randy Dunlap 2018-07-08 16:30 ` Randy Dunlap 2018-07-08 15:20 ` [PATCH 7/9] arch/Kconfig: use a menu to reduce clutter Christoph Hellwig 2018-07-08 15:20 ` Christoph Hellwig 2018-07-08 15:20 ` [PATCH 8/9] kconfig: move the "Executable file formats" menu to fs/Kconfig.binfmt Christoph Hellwig 2018-07-08 15:20 ` Christoph Hellwig 2018-07-08 15:20 ` [PATCH 9/9] kconfig: add a Memory Management options" menu Christoph Hellwig 2018-07-08 15:20 ` Christoph Hellwig 2018-07-23 10:46 ` include architecture Kconfig files from top-level Kconfig v2 Richard Weinberger 2018-07-23 10:46 ` Richard Weinberger
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e36e6b2c-0984-199e-8c19-3ec54b31c12e@infradead.org \ --to=rdunlap@infradead.org \ --cc=hch@lst.de \ --cc=linux-kbuild@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-um@lists.infradead.org \ --cc=richard@nod.at \ --cc=yamada.masahiro@socionext.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.