Re: [RFC RESEND PATCH 0/4] hw/arm/virt-acpi-build: Introduce iommu option for pci root bus

From: Auger Eric <eric.auger@redhat.com>
To: Wang Xingang <wangxingang5@huawei.com>, qemu-devel@nongnu.org
Cc: xieyingtai@huawei.com, peter.maydell@linaro.org,
	cenjiahui@huawei.com, mst@redhat.com, shannon.zhaosl@gmail.com,
	qemu-arm@nongnu.org, imammedo@redhat.com
Subject: Re: [RFC RESEND PATCH 0/4] hw/arm/virt-acpi-build: Introduce iommu option for pci root bus
Date: Tue, 9 Mar 2021 15:36:02 +0100	[thread overview]
Message-ID: <e37590d0-d65f-e4e4-ec59-92eb3166d9d9@redhat.com> (raw)
In-Reply-To: <1614414831-39712-1-git-send-email-wangxingang5@huawei.com>

Hi,
On 2/27/21 9:33 AM, Wang Xingang wrote:
> From: Xingang Wang <wangxingang5@huawei.com>
> 
> These patches add support for configure iommu on/off for pci root bus,
> including primary bus and pxb root bus. At present, All root bus will go
> through iommu when iommu is configured, which is not flexible.
> 
> So this add option to enable/disable iommu for primary bus and pxb root bus.
> When iommu is enabled for the root bus, devices attached to it will go
> through iommu. When iommu is disabled for the root bus, devices will not
> go through iommu accordingly.

Please could you give an example of the qemu command line for which the
new option is useful for you. This would help me to understand your
pcie/pci topology and also make sure I test it with the smmu.

Thank you in advance

Best Regards

Eric
> 
> Xingang Wang (4):
>   pci: Add PCI_BUS_IOMMU property
>   hw/pci: Add iommu option for pci root bus
>   hw/pci: Add pci_root_bus_max_bus
>   hw/arm/virt-acpi-build: Add explicit idmap info in IORT table
> 
>  hw/arm/virt-acpi-build.c            | 92 +++++++++++++++++++++--------
>  hw/arm/virt.c                       | 29 +++++++++
>  hw/pci-bridge/pci_expander_bridge.c |  6 ++
>  hw/pci/pci.c                        | 35 ++++++++++-
>  include/hw/arm/virt.h               |  1 +
>  include/hw/pci/pci.h                |  1 +
>  include/hw/pci/pci_bus.h            | 13 ++++
>  7 files changed, 153 insertions(+), 24 deletions(-)
> 