From: Markus Elfring <Markus.Elfring@web.de>
To: Namjae Jeon <namjae.jeon@samsung.com>, linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
"Christoph Hellwig" <hch@lst.de>,
"Daniel Wagner" <dwagner@suse.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Sungjong Seo" <sj1557.seo@samsung.com>,
"Valdis Klētnieks" <valdis.kletnieks@vt.edu>,
linkinjeon@gmail.com
Subject: Re: [PATCH v3 06/13] exfat: add exfat entry operations
Date: Tue, 19 Nov 2019 15:19:01 +0100 [thread overview]
Message-ID: <e427d4ad-aaa0-1d96-3aab-01be7703dd77@web.de> (raw)
In-Reply-To: <20191119093718.3501-7-namjae.jeon@samsung.com>
…
> +++ b/fs/exfat/fatent.c
…
> +int exfat_zeroed_cluster(struct inode *dir, unsigned int clu)
> +{
…
> +error:
> + exfat_msg(sb, KERN_ERR, "failed zeroed sect %llu\n",
> + (unsigned long long)blknr);
…
Can the label “report_failure” be more helpful?
…
> +int exfat_alloc_cluster(struct inode *inode, unsigned int num_alloc,
> + struct exfat_chain *p_chain)
> +{
…
> +error:
> + if (num_clusters)
> + exfat_free_cluster(inode, p_chain);
Can a label like “check_num_clusters” be nicer?
Regards,
Markus
WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: Namjae Jeon <namjae.jeon@samsung.com>, linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
"Christoph Hellwig" <hch@lst.de>,
"Daniel Wagner" <dwagner@suse.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Sungjong Seo" <sj1557.seo@samsung.com>,
"Valdis Klētnieks" <valdis.kletnieks@vt.edu>,
linkinjeon@gmail.com
Subject: Re: [PATCH v3 06/13] exfat: add exfat entry operations
Date: Tue, 19 Nov 2019 14:19:01 +0000 [thread overview]
Message-ID: <e427d4ad-aaa0-1d96-3aab-01be7703dd77@web.de> (raw)
In-Reply-To: <20191119093718.3501-7-namjae.jeon@samsung.com>
…
> +++ b/fs/exfat/fatent.c
…
> +int exfat_zeroed_cluster(struct inode *dir, unsigned int clu)
> +{
…
> +error:
> + exfat_msg(sb, KERN_ERR, "failed zeroed sect %llu\n",
> + (unsigned long long)blknr);
…
Can the label “report_failure” be more helpful?
…
> +int exfat_alloc_cluster(struct inode *inode, unsigned int num_alloc,
> + struct exfat_chain *p_chain)
> +{
…
> +error:
> + if (num_clusters)
> + exfat_free_cluster(inode, p_chain);
Can a label like “check_num_clusters” be nicer?
Regards,
Markus
next prev parent reply other threads:[~2019-11-19 14:19 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20191119094019epcas1p298d14fcf6e7a24bee431238279961c5b@epcas1p2.samsung.com>
2019-11-19 9:37 ` [PATCH v3 00/13] add the latest exfat driver Namjae Jeon
[not found] ` <CGME20191119094020epcas1p26de9d7e4e2ab8ad5d6ecaf23e2dfdca8@epcas1p2.samsung.com>
2019-11-19 9:37 ` [PATCH v3 01/13] exfat: add in-memory and on-disk structures and headers Namjae Jeon
2019-11-20 20:21 ` Markus Elfring
2019-11-20 20:21 ` Markus Elfring
2019-11-20 20:31 ` Greg Kroah-Hartman
2019-11-20 20:31 ` Greg Kroah-Hartman
[not found] ` <CGME20191119094021epcas1p1ef79711e2ea59c4e909a30a9ac2daa3d@epcas1p1.samsung.com>
2019-11-19 9:37 ` [PATCH v3 02/13] exfat: add super block operations Namjae Jeon
2019-11-19 13:32 ` Markus Elfring
2019-11-19 13:32 ` Markus Elfring
[not found] ` <CGME20191119094021epcas1p16e9ebb9fd8a1b25c64b09899a31988b9@epcas1p1.samsung.com>
2019-11-19 9:37 ` [PATCH v3 03/13] exfat: add inode operations Namjae Jeon
2019-11-22 17:02 ` Al Viro
2019-11-23 1:56 ` Namjae Jeon
[not found] ` <CGME20191119094022epcas1p28a2fbdc256ad6b0590d0765194ccb6a8@epcas1p2.samsung.com>
2019-11-19 9:37 ` [PATCH v3 04/13] exfat: add directory operations Namjae Jeon
[not found] ` <CGME20191119094023epcas1p157ea65111e4564d5da2f64f168440e2a@epcas1p1.samsung.com>
2019-11-19 9:37 ` [PATCH v3 05/13] exfat: add file operations Namjae Jeon
[not found] ` <CGME20191119094023epcas1p4976d19f4b9a859ba4bd5b3068cafa88a@epcas1p4.samsung.com>
2019-11-19 9:37 ` [PATCH v3 06/13] exfat: add exfat entry operations Namjae Jeon
2019-11-19 14:19 ` Markus Elfring [this message]
2019-11-19 14:19 ` Markus Elfring
[not found] ` <CGME20191119094024epcas1p3991c5d94c2cf40388d64c0bd9c30092d@epcas1p3.samsung.com>
2019-11-19 9:37 ` [PATCH v3 07/13] exfat: add bitmap operations Namjae Jeon
2019-11-20 20:38 ` Markus Elfring
2019-11-20 20:38 ` Markus Elfring
[not found] ` <CGME20191119094024epcas1p1be385d521ef64ae0e62da3f6f9bf3401@epcas1p1.samsung.com>
2019-11-19 9:37 ` [PATCH v3 08/13] exfat: add exfat cache Namjae Jeon
2019-11-19 14:40 ` Markus Elfring
2019-11-19 14:40 ` Markus Elfring
[not found] ` <CGME20191119094025epcas1p2bbb3121ac9f1d427f09f6548b8d35dbb@epcas1p2.samsung.com>
2019-11-19 9:37 ` [PATCH v3 09/13] exfat: add misc operations Namjae Jeon
[not found] ` <CGME20191119094026epcas1p3eea5c655f3b89383e02c0097c491f0bc@epcas1p3.samsung.com>
2019-11-19 9:37 ` [PATCH v3 10/13] exfat: add nls operations Namjae Jeon
2019-11-19 15:06 ` Markus Elfring
2019-11-19 15:06 ` Markus Elfring
2019-11-20 9:02 ` Namjae Jeon
2019-11-20 9:02 ` Namjae Jeon
2019-11-20 12:36 ` Markus Elfring
2019-11-20 12:36 ` Markus Elfring
[not found] ` <CGME20191119094026epcas1p4bee051f56352505eab919011ec740c5d@epcas1p4.samsung.com>
2019-11-19 9:37 ` [PATCH v3 11/13] exfat: add Kconfig and Makefile Namjae Jeon
[not found] ` <CGME20191119094027epcas1p416eca98bc8ccefbcada87ae6b475d4c4@epcas1p4.samsung.com>
2019-11-19 9:37 ` [PATCH v3 12/13] exfat: add exfat in fs/Kconfig and fs/Makefile Namjae Jeon
[not found] ` <CGME20191119094028epcas1p1b69cd151e3e574859a34e3a931d48cf2@epcas1p1.samsung.com>
2019-11-19 9:37 ` [PATCH v3 13/13] MAINTAINERS: add exfat filesystem Namjae Jeon
2019-11-19 12:15 ` [PATCH v3 00/13] add the latest exfat driver Markus Elfring
2019-11-19 12:15 ` Markus Elfring
2019-11-19 12:43 ` Namjae Jeon
2019-11-19 12:43 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e427d4ad-aaa0-1d96-3aab-01be7703dd77@web.de \
--to=markus.elfring@web.de \
--cc=dwagner@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linkinjeon@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
--cc=sj1557.seo@samsung.com \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.