From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Andi Shyti <andi@etezian.org>
Cc: jonathanh@nvidia.com, alexandre.belloni@bootlin.com,
s.hauer@pengutronix.de, linux-arm-msm@vger.kernel.org,
radu_nicolae.pirea@upb.ro, broonie@kernel.org,
linux-kernel@vger.kernel.org, krzk@kernel.org,
linux-spi@vger.kernel.org, vkoul@kernel.org, kgene@kernel.org,
ldewangan@nvidia.com, agross@kernel.org,
linux-tegra@vger.kernel.org, thierry.reding@gmail.com,
bjorn.andersson@linaro.org, shawnguo@kernel.org,
linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 7/9] spi: s3c64xx: Use dma_request_chan() directly for channel request
Date: Thu, 14 Nov 2019 10:09:33 +0200 [thread overview]
Message-ID: <e453c716-7658-a9fd-324d-4d95ff1aa29c@ti.com> (raw)
In-Reply-To: <20191113234049.GA1249@jack.zhora.eu>
On 14/11/2019 1.40, Andi Shyti wrote:
> Hi Peter,
>
>> if (!is_polling(sdd)) {
>> /* Acquire DMA channels */
>> - sdd->rx_dma.ch = dma_request_slave_channel_reason(&pdev->dev,
>> - "rx");
>> + sdd->rx_dma.ch = dma_request_chan(&pdev->dev, "rx");
>
> I have a little concern here. We have two funcions
> 'dma_request_chan' and 'dma_request_channel' don't we end up
> making some confusion here?
>
> Wouldn't it make more sense renaming 'dma_request_chan' to
> 'dma_request_slave_channel_reason'?
The dma_request_channel() should go away. It was the old API before we
got the dma_slave_map for non DT (and non ACPI) platforms so we can get
rid of the filter function exports from DMA drivers to clients all over
the place.
I know there are users where they provide dummy filter function.
At the end the main API to request slave DMA channel should be
dma_request_chan()
For non slave channels (not HW triggered) we have dma_request_chan_by_mask()
Imoh the dma_request_slave_channel_compat() should also go away with time.
>
> Thanks,
> Andi
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Andi Shyti <andi@etezian.org>
Cc: <linus.walleij@linaro.org>, <kgene@kernel.org>,
<alexandre.belloni@bootlin.com>, <linux-arm-msm@vger.kernel.org>,
<radu_nicolae.pirea@upb.ro>, <linux-spi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <krzk@kernel.org>,
<bjorn.andersson@linaro.org>, <vkoul@kernel.org>,
<agross@kernel.org>, <ldewangan@nvidia.com>, <broonie@kernel.org>,
<linux-tegra@vger.kernel.org>, <thierry.reding@gmail.com>,
<jonathanh@nvidia.com>, <shawnguo@kernel.org>,
<s.hauer@pengutronix.de>, <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 7/9] spi: s3c64xx: Use dma_request_chan() directly for channel request
Date: Thu, 14 Nov 2019 10:09:33 +0200 [thread overview]
Message-ID: <e453c716-7658-a9fd-324d-4d95ff1aa29c@ti.com> (raw)
In-Reply-To: <20191113234049.GA1249@jack.zhora.eu>
On 14/11/2019 1.40, Andi Shyti wrote:
> Hi Peter,
>
>> if (!is_polling(sdd)) {
>> /* Acquire DMA channels */
>> - sdd->rx_dma.ch = dma_request_slave_channel_reason(&pdev->dev,
>> - "rx");
>> + sdd->rx_dma.ch = dma_request_chan(&pdev->dev, "rx");
>
> I have a little concern here. We have two funcions
> 'dma_request_chan' and 'dma_request_channel' don't we end up
> making some confusion here?
>
> Wouldn't it make more sense renaming 'dma_request_chan' to
> 'dma_request_slave_channel_reason'?
The dma_request_channel() should go away. It was the old API before we
got the dma_slave_map for non DT (and non ACPI) platforms so we can get
rid of the filter function exports from DMA drivers to clients all over
the place.
I know there are users where they provide dummy filter function.
At the end the main API to request slave DMA channel should be
dma_request_chan()
For non slave channels (not HW triggered) we have dma_request_chan_by_mask()
Imoh the dma_request_slave_channel_compat() should also go away with time.
>
> Thanks,
> Andi
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2019-11-14 8:09 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 9:42 [PATCH 0/9] spi: Use dma_request_chan() directly for channel request Peter Ujfalusi
2019-11-13 9:42 ` Peter Ujfalusi
2019-11-13 9:42 ` Peter Ujfalusi
2019-11-13 9:42 ` Peter Ujfalusi
2019-11-13 9:42 ` [PATCH 1/9] spi: at91-usart: " Peter Ujfalusi
2019-11-13 9:42 ` Peter Ujfalusi
2019-11-13 9:42 ` Peter Ujfalusi
2019-11-13 9:42 ` Peter Ujfalusi
2019-11-13 14:18 ` Nicolas.Ferre
2019-11-13 14:18 ` Nicolas.Ferre
2019-11-13 14:18 ` Nicolas.Ferre
2019-11-15 12:25 ` Applied "spi: at91-usart: Use dma_request_chan() directly for channel request" to the spi tree Mark Brown
2019-11-15 12:25 ` Mark Brown
2019-11-15 12:25 ` Mark Brown
2019-11-15 12:25 ` Mark Brown
2019-11-13 9:42 ` [PATCH 2/9] spi: atmel: Use dma_request_chan() directly for channel request Peter Ujfalusi
2019-11-13 9:42 ` Peter Ujfalusi
2019-11-13 9:42 ` Peter Ujfalusi
2019-11-13 14:18 ` Nicolas.Ferre
2019-11-13 14:18 ` Nicolas.Ferre
2019-11-13 14:18 ` Nicolas.Ferre
2019-11-15 12:25 ` Applied "spi: atmel: Use dma_request_chan() directly for channel request" to the spi tree Mark Brown
2019-11-15 12:25 ` Mark Brown
2019-11-15 12:25 ` Mark Brown
2019-11-15 12:25 ` Mark Brown
2019-11-13 9:42 ` [PATCH 3/9] spi: fsl-lpspi: Use dma_request_chan() directly for channel request Peter Ujfalusi
2019-11-13 9:42 ` Peter Ujfalusi
2019-11-13 9:42 ` Peter Ujfalusi
2019-11-15 12:25 ` Applied "spi: fsl-lpspi: Use dma_request_chan() directly for channel request" to the spi tree Mark Brown
2019-11-15 12:25 ` Mark Brown
2019-11-15 12:25 ` Mark Brown
2019-11-15 12:25 ` Mark Brown
2019-11-13 9:42 ` [PATCH 4/9] spi: imx: Use dma_request_chan() directly for channel request Peter Ujfalusi
2019-11-13 9:42 ` Peter Ujfalusi
2019-11-13 9:42 ` Peter Ujfalusi
2019-11-15 12:25 ` Applied "spi: imx: Use dma_request_chan() directly for channel request" to the spi tree Mark Brown
2019-11-15 12:25 ` Mark Brown
2019-11-15 12:25 ` Mark Brown
2019-11-15 12:25 ` Mark Brown
2019-11-13 9:42 ` [PATCH 5/9] spi: pl022: Use dma_request_chan() directly for channel request Peter Ujfalusi
2019-11-13 9:42 ` Peter Ujfalusi
2019-11-13 9:42 ` Peter Ujfalusi
2019-11-13 17:16 ` Linus Walleij
2019-11-13 17:16 ` Linus Walleij
2019-11-15 12:25 ` Applied "spi: pl022: Use dma_request_chan() directly for channel request" to the spi tree Mark Brown
2019-11-15 12:25 ` Mark Brown
2019-11-15 12:25 ` Mark Brown
2019-11-15 12:25 ` Mark Brown
2019-11-13 9:42 ` [PATCH 6/9] spi: qup: Use dma_request_chan() directly for channel request Peter Ujfalusi
2019-11-13 9:42 ` Peter Ujfalusi
2019-11-13 9:42 ` Peter Ujfalusi
2019-11-15 12:25 ` Applied "spi: qup: Use dma_request_chan() directly for channel request" to the spi tree Mark Brown
2019-11-15 12:25 ` Mark Brown
2019-11-15 12:25 ` Mark Brown
2019-11-15 12:25 ` Mark Brown
2019-11-13 9:42 ` [PATCH 7/9] spi: s3c64xx: Use dma_request_chan() directly for channel request Peter Ujfalusi
2019-11-13 9:42 ` Peter Ujfalusi
2019-11-13 9:42 ` Peter Ujfalusi
2019-11-13 23:40 ` Andi Shyti
2019-11-13 23:40 ` Andi Shyti
2019-11-14 8:09 ` Peter Ujfalusi [this message]
2019-11-14 8:09 ` Peter Ujfalusi
2019-11-14 9:12 ` Andi Shyti
2019-11-14 9:12 ` Andi Shyti
2019-11-14 9:12 ` Andi Shyti
2019-11-14 6:27 ` Krzysztof Kozlowski
2019-11-14 6:27 ` Krzysztof Kozlowski
2019-11-14 6:27 ` Krzysztof Kozlowski
2019-11-15 12:25 ` Applied "spi: s3c64xx: Use dma_request_chan() directly for channel request" to the spi tree Mark Brown
2019-11-15 12:25 ` Mark Brown
2019-11-15 12:25 ` Mark Brown
2019-11-15 12:25 ` Mark Brown
2019-11-13 9:42 ` [PATCH 8/9] spi: tegra114: Use dma_request_chan() directly for channel request Peter Ujfalusi
2019-11-13 9:42 ` Peter Ujfalusi
2019-11-13 9:42 ` Peter Ujfalusi
2019-11-14 7:06 ` Jon Hunter
2019-11-14 7:06 ` Jon Hunter
2019-11-14 7:06 ` Jon Hunter
2019-11-15 12:25 ` Applied "spi: tegra114: Use dma_request_chan() directly for channel request" to the spi tree Mark Brown
2019-11-15 12:25 ` Mark Brown
2019-11-15 12:25 ` Mark Brown
2019-11-15 12:25 ` Mark Brown
2019-11-13 9:42 ` [PATCH 9/9] spi: tegra20-slink: Use dma_request_chan() directly for channel request Peter Ujfalusi
2019-11-13 9:42 ` Peter Ujfalusi
2019-11-13 9:42 ` Peter Ujfalusi
2019-11-14 7:06 ` Jon Hunter
2019-11-14 7:06 ` Jon Hunter
2019-11-14 7:06 ` Jon Hunter
2019-11-15 12:25 ` Applied "spi: tegra20-slink: Use dma_request_chan() directly for channel request" to the spi tree Mark Brown
2019-11-15 12:25 ` Mark Brown
2019-11-15 12:25 ` Mark Brown
2019-11-15 12:25 ` Mark Brown
2019-11-14 4:35 ` [PATCH 0/9] spi: Use dma_request_chan() directly for channel request Vinod Koul
2019-11-14 4:35 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e453c716-7658-a9fd-324d-4d95ff1aa29c@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=agross@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=andi@etezian.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=ldewangan@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=radu_nicolae.pirea@upb.ro \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.