From: Asahi Lina <lina@asahilina.net>
To: Thomas Zimmermann <tzimmermann@suse.de>,
Dmitry Osipenko <dmitry.osipenko@collabora.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: "Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
"Noralf Trønnes" <noralf@tronnes.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
asahi@lists.linux.dev
Subject: Re: [PATCH] drm/shmem-helper: Fix locking for drm_gem_shmem_get_pages_sgt()
Date: Mon, 27 Feb 2023 16:55:53 +0900 [thread overview]
Message-ID: <e49127fb-abb9-16fc-42bd-2f380d1bd29d@asahilina.net> (raw)
In-Reply-To: <cc1c34c6-18d1-a8c5-bf70-078e7b7205f8@suse.de>
On 27/02/2023 16.45, Thomas Zimmermann wrote:
> Hi
>
> Am 25.02.23 um 22:51 schrieb Dmitry Osipenko:
>> On 2/5/23 15:51, Asahi Lina wrote:
>>> -EXPORT_SYMBOL_GPL(drm_gem_shmem_get_pages_sgt);
>>> +EXPORT_SYMBOL(drm_gem_shmem_get_pages_sgt);
>>
>> Note it was a GPL symbol. I expect that all drm-shmem exports should be GPL.
>
> Right. I didn't notice that change, but it's probably not allowed. This
> needs to be reverted to a GPL export
I'm sorry, this was not intentional! I think I removed and re-added the
export as part of making the wrapper and didn't notice it used to be _GPL...
Do you want me to send a patch to add it back?
~~ Lina
WARNING: multiple messages have this Message-ID (diff)
From: Asahi Lina <lina@asahilina.net>
To: Thomas Zimmermann <tzimmermann@suse.de>,
Dmitry Osipenko <dmitry.osipenko@collabora.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org,
"Noralf Trønnes" <noralf@tronnes.org>,
linux-kernel@vger.kernel.org,
"Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
asahi@lists.linux.dev
Subject: Re: [PATCH] drm/shmem-helper: Fix locking for drm_gem_shmem_get_pages_sgt()
Date: Mon, 27 Feb 2023 16:55:53 +0900 [thread overview]
Message-ID: <e49127fb-abb9-16fc-42bd-2f380d1bd29d@asahilina.net> (raw)
In-Reply-To: <cc1c34c6-18d1-a8c5-bf70-078e7b7205f8@suse.de>
On 27/02/2023 16.45, Thomas Zimmermann wrote:
> Hi
>
> Am 25.02.23 um 22:51 schrieb Dmitry Osipenko:
>> On 2/5/23 15:51, Asahi Lina wrote:
>>> -EXPORT_SYMBOL_GPL(drm_gem_shmem_get_pages_sgt);
>>> +EXPORT_SYMBOL(drm_gem_shmem_get_pages_sgt);
>>
>> Note it was a GPL symbol. I expect that all drm-shmem exports should be GPL.
>
> Right. I didn't notice that change, but it's probably not allowed. This
> needs to be reverted to a GPL export
I'm sorry, this was not intentional! I think I removed and re-added the
export as part of making the wrapper and didn't notice it used to be _GPL...
Do you want me to send a patch to add it back?
~~ Lina
next prev parent reply other threads:[~2023-02-27 7:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-05 12:51 [PATCH] drm/shmem-helper: Fix locking for drm_gem_shmem_get_pages_sgt() Asahi Lina
2023-02-05 12:51 ` Asahi Lina
2023-02-06 18:47 ` Javier Martinez Canillas
2023-02-06 18:47 ` Javier Martinez Canillas
2023-02-07 10:33 ` Asahi Lina
2023-02-07 10:33 ` Asahi Lina
2023-02-07 10:43 ` Javier Martinez Canillas
2023-02-07 10:43 ` Javier Martinez Canillas
2023-02-10 12:38 ` Javier Martinez Canillas
2023-02-10 12:38 ` Javier Martinez Canillas
2023-02-07 11:29 ` Thomas Zimmermann
2023-02-07 11:29 ` Thomas Zimmermann
2023-02-07 23:34 ` Asahi Lina
2023-02-07 23:34 ` Asahi Lina
2023-02-25 21:51 ` Dmitry Osipenko
2023-02-25 21:51 ` Dmitry Osipenko
2023-02-27 7:45 ` Thomas Zimmermann
2023-02-27 7:45 ` Thomas Zimmermann
2023-02-27 7:55 ` Asahi Lina [this message]
2023-02-27 7:55 ` Asahi Lina
2023-02-27 8:04 ` Thomas Zimmermann
2023-02-27 8:04 ` Thomas Zimmermann
2023-02-27 9:07 ` Asahi Lina
2023-02-27 9:07 ` Asahi Lina
2023-02-27 9:20 ` Thomas Zimmermann
2023-02-27 9:20 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e49127fb-abb9-16fc-42bd-2f380d1bd29d@asahilina.net \
--to=lina@asahilina.net \
--cc=airlied@gmail.com \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=daniel@ffwll.ch \
--cc=dmitry.osipenko@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=noralf@tronnes.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.