From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Cc: kernel@pengutronix.de, Florian Fainelli <florian.fainelli@broadcom.com>, Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 02/15] memory: brcmstb_memc: Convert to platform remove callback returning void Date: Sun, 17 Dec 2023 15:29:28 +0100 [thread overview] Message-ID: <e4f3c86270161ce231cd0e4f3be9c632578e17a2.1702822744.git.u.kleine-koenig@pengutronix.de> (raw) In-Reply-To: <cover.1702822744.git.u.kleine-koenig@pengutronix.de> The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/memory/brcmstb_memc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/memory/brcmstb_memc.c b/drivers/memory/brcmstb_memc.c index a6ea51996522..ea9213f7152e 100644 --- a/drivers/memory/brcmstb_memc.c +++ b/drivers/memory/brcmstb_memc.c @@ -152,13 +152,11 @@ static int brcmstb_memc_probe(struct platform_device *pdev) return 0; } -static int brcmstb_memc_remove(struct platform_device *pdev) +static void brcmstb_memc_remove(struct platform_device *pdev) { struct device *dev = &pdev->dev; sysfs_remove_group(&dev->kobj, &dev_attr_group); - - return 0; } enum brcmstb_memc_hwtype { @@ -284,7 +282,7 @@ static DEFINE_SIMPLE_DEV_PM_OPS(brcmstb_memc_pm_ops, brcmstb_memc_suspend, static struct platform_driver brcmstb_memc_driver = { .probe = brcmstb_memc_probe, - .remove = brcmstb_memc_remove, + .remove_new = brcmstb_memc_remove, .driver = { .name = "brcmstb_memc", .of_match_table = brcmstb_memc_of_match, -- 2.42.0
WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Cc: kernel@pengutronix.de, Florian Fainelli <florian.fainelli@broadcom.com>, Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 02/15] memory: brcmstb_memc: Convert to platform remove callback returning void Date: Sun, 17 Dec 2023 15:29:28 +0100 [thread overview] Message-ID: <e4f3c86270161ce231cd0e4f3be9c632578e17a2.1702822744.git.u.kleine-koenig@pengutronix.de> (raw) In-Reply-To: <cover.1702822744.git.u.kleine-koenig@pengutronix.de> The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/memory/brcmstb_memc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/memory/brcmstb_memc.c b/drivers/memory/brcmstb_memc.c index a6ea51996522..ea9213f7152e 100644 --- a/drivers/memory/brcmstb_memc.c +++ b/drivers/memory/brcmstb_memc.c @@ -152,13 +152,11 @@ static int brcmstb_memc_probe(struct platform_device *pdev) return 0; } -static int brcmstb_memc_remove(struct platform_device *pdev) +static void brcmstb_memc_remove(struct platform_device *pdev) { struct device *dev = &pdev->dev; sysfs_remove_group(&dev->kobj, &dev_attr_group); - - return 0; } enum brcmstb_memc_hwtype { @@ -284,7 +282,7 @@ static DEFINE_SIMPLE_DEV_PM_OPS(brcmstb_memc_pm_ops, brcmstb_memc_suspend, static struct platform_driver brcmstb_memc_driver = { .probe = brcmstb_memc_probe, - .remove = brcmstb_memc_remove, + .remove_new = brcmstb_memc_remove, .driver = { .name = "brcmstb_memc", .of_match_table = brcmstb_memc_of_match, -- 2.42.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-12-17 14:30 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-12-17 14:29 [PATCH 00/15] memory: Convert to platform remove callback returning void Uwe Kleine-König 2023-12-17 14:29 ` Uwe Kleine-König 2023-12-17 14:29 ` [PATCH 01/15] memory: brcmstb_dpfe: " Uwe Kleine-König 2023-12-17 14:29 ` Uwe Kleine-König 2023-12-18 6:56 ` Markus Mayer 2023-12-18 6:56 ` Markus Mayer 2023-12-17 14:29 ` Uwe Kleine-König [this message] 2023-12-17 14:29 ` [PATCH 02/15] memory: brcmstb_memc: " Uwe Kleine-König 2023-12-17 14:29 ` [PATCH 03/15] memory: emif: " Uwe Kleine-König 2023-12-17 14:29 ` [PATCH 04/15] memory: fsl-corenet-cf: " Uwe Kleine-König 2023-12-17 14:29 ` [PATCH 05/15] memory: fsl_ifc: " Uwe Kleine-König 2023-12-17 14:29 ` [PATCH 06/15] memory: jz4780-nemc: " Uwe Kleine-König 2023-12-17 14:40 ` Paul Cercueil 2023-12-17 14:29 ` [PATCH 07/15] memory: mtk-smi: " Uwe Kleine-König 2023-12-17 14:29 ` Uwe Kleine-König 2023-12-17 14:29 ` [PATCH 08/15] memory: omap-gpmc: " Uwe Kleine-König 2023-12-18 8:37 ` Tony Lindgren 2023-12-17 14:29 ` [PATCH 09/15] memory: renesas-rpc-if: " Uwe Kleine-König 2023-12-17 14:29 ` [PATCH 10/15] memory: exynos5422-dmc: " Uwe Kleine-König 2023-12-17 14:29 ` Uwe Kleine-König 2023-12-17 14:29 ` [PATCH 11/15] memory: stm32-fmc2-ebi: " Uwe Kleine-König 2023-12-17 14:29 ` Uwe Kleine-König 2023-12-17 14:29 ` [PATCH 12/15] memory: tegra186-emc: " Uwe Kleine-König 2023-12-17 14:29 ` [PATCH 13/15] memory: tegra210-emc: " Uwe Kleine-König 2023-12-17 14:29 ` [PATCH 14/15] memory: ti-aemif: " Uwe Kleine-König 2023-12-17 14:29 ` [PATCH 15/15] memory: ti-emif-pm: " Uwe Kleine-König 2023-12-19 8:06 ` [PATCH 00/15] memory: " Krzysztof Kozlowski 2023-12-19 8:06 ` Krzysztof Kozlowski 2023-12-19 8:06 ` Krzysztof Kozlowski 2023-12-19 8:06 ` Krzysztof Kozlowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e4f3c86270161ce231cd0e4f3be9c632578e17a2.1702822744.git.u.kleine-koenig@pengutronix.de \ --to=u.kleine-koenig@pengutronix.de \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=florian.fainelli@broadcom.com \ --cc=kernel@pengutronix.de \ --cc=krzysztof.kozlowski@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.