From: Robert Foss <robert.foss-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
To: "Ville Syrjälä" <ville.syrjala-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: airlied-cv59FeDIM0c@public.gmane.org,
nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
liviu.dudau-5wv7dgnIgG8@public.gmane.org,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
daniel.vetter-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
thellstrom-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org,
syeh-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org,
linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org,
tomi.valkeinen-l0cyMroinI0@public.gmane.org,
linux-graphics-maintainer-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org,
bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
"Daniel Vetter" <daniel.vetter-/w4YWyX8dFk@public.gmane.org>,
malidp-VeJGdqYn5oNWk0Htik3J/w@public.gmane.org,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
"Kristian Høgsberg"
<hoegsberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
architt-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
jani.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
"Tomeu Vizoso"
<tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>,
"Emil Velikov"
<emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
brian.starkey-5wv7dgnIgG8@public.gmane.org
Subject: Re: [PATCH v3] drm: Add DRM_MODE_ROTATE_ and DRM_MODE_REFLECT_ to UAPI
Date: Fri, 19 May 2017 16:40:46 -0400 [thread overview]
Message-ID: <e62bab71-34c5-c106-a6bb-aafd05c3a203@collabora.com> (raw)
In-Reply-To: <20170518094956.GY12629-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
On 2017-05-18 05:49 AM, Ville Syrjälä wrote:
> On Wed, May 17, 2017 at 09:39:11PM -0400, Robert Foss wrote:
>> +/*
>> + * DRM_MODE_REFLECT_<axis>
>> + *
>> + * Signals that the contents of a drm plane has been reflected in
>> + * the <axis> axis.
>
> Still vague.
Ack, I'll add some verbiage.
>
> Also you didn't respond to my comment about the use of past tense.
Fixed in v4.
Rob.
>
>> + *
>> + * This define is provided as a convenience, looking up the property id
>> + * using the name->prop id lookup is the preferred method.
>> + */
>> +#define DRM_MODE_REFLECT_X (1<<4)
>> +#define DRM_MODE_REFLECT_Y (1<<5)
>> +
>> +/*
>> + * DRM_MODE_REFLECT_MASK
>> + *
>> + * Bitmask used to look for drm plane reflections.
>> + */
>> +#define DRM_MODE_REFLECT_MASK (\
>> + DRM_MODE_REFLECT_X | \
>> + DRM_MODE_REFLECT_Y)
>> +
>> +
>> struct drm_mode_modeinfo {
>> __u32 clock;
>> __u16 hdisplay;
>> --
>> 2.11.0.453.g787f75f05
>
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
WARNING: multiple messages have this Message-ID (diff)
From: Robert Foss <robert.foss@collabora.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: liviu.dudau@arm.com, brian.starkey@arm.com, malidp@foss.arm.com,
airlied@linux.ie, linux@armlinux.org.uk,
boris.brezillon@free-electrons.com, daniel.vetter@intel.com,
jani.nikula@linux.intel.com, seanpaul@chromium.org,
p.zabel@pengutronix.de, robdclark@gmail.com, bskeggs@redhat.com,
tomi.valkeinen@ti.com, linux-graphics-maintainer@vmware.com,
syeh@vmware.com, thellstrom@vmware.com, architt@codeaurora.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
intel-gfx@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org,
"Tomeu Vizoso" <tomeu.vizoso@collabora.com>,
"Emil Velikov" <emil.l.velikov@gmail.com>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Kristian Høgsberg" <hoegsberg@gmail.com>
Subject: Re: [PATCH v3] drm: Add DRM_MODE_ROTATE_ and DRM_MODE_REFLECT_ to UAPI
Date: Fri, 19 May 2017 16:40:46 -0400 [thread overview]
Message-ID: <e62bab71-34c5-c106-a6bb-aafd05c3a203@collabora.com> (raw)
In-Reply-To: <20170518094956.GY12629@intel.com>
On 2017-05-18 05:49 AM, Ville Syrjälä wrote:
> On Wed, May 17, 2017 at 09:39:11PM -0400, Robert Foss wrote:
>> +/*
>> + * DRM_MODE_REFLECT_<axis>
>> + *
>> + * Signals that the contents of a drm plane has been reflected in
>> + * the <axis> axis.
>
> Still vague.
Ack, I'll add some verbiage.
>
> Also you didn't respond to my comment about the use of past tense.
Fixed in v4.
Rob.
>
>> + *
>> + * This define is provided as a convenience, looking up the property id
>> + * using the name->prop id lookup is the preferred method.
>> + */
>> +#define DRM_MODE_REFLECT_X (1<<4)
>> +#define DRM_MODE_REFLECT_Y (1<<5)
>> +
>> +/*
>> + * DRM_MODE_REFLECT_MASK
>> + *
>> + * Bitmask used to look for drm plane reflections.
>> + */
>> +#define DRM_MODE_REFLECT_MASK (\
>> + DRM_MODE_REFLECT_X | \
>> + DRM_MODE_REFLECT_Y)
>> +
>> +
>> struct drm_mode_modeinfo {
>> __u32 clock;
>> __u16 hdisplay;
>> --
>> 2.11.0.453.g787f75f05
>
next prev parent reply other threads:[~2017-05-19 20:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 1:39 [PATCH v3] drm: Add DRM_MODE_ROTATE_ and DRM_MODE_REFLECT_ to UAPI Robert Foss
2017-05-18 1:39 ` Robert Foss
[not found] ` <20170518013911.29626-1-robert.foss-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2017-05-18 9:42 ` Emil Velikov
2017-05-18 9:42 ` Emil Velikov
2017-05-18 9:49 ` Ville Syrjälä
[not found] ` <20170518094956.GY12629-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-05-19 20:40 ` Robert Foss [this message]
2017-05-19 20:40 ` Robert Foss
2017-05-18 10:05 ` Liviu Dudau
2017-05-18 10:05 ` Liviu Dudau
2017-05-18 16:24 ` Sinclair Yeh
2017-05-18 16:24 ` Sinclair Yeh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e62bab71-34c5-c106-a6bb-aafd05c3a203@collabora.com \
--to=robert.foss-zgy8ohtn/8qb+jhodadfcq@public.gmane.org \
--cc=airlied-cv59FeDIM0c@public.gmane.org \
--cc=architt-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=brian.starkey-5wv7dgnIgG8@public.gmane.org \
--cc=bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=daniel.vetter-/w4YWyX8dFk@public.gmane.org \
--cc=daniel.vetter-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=hoegsberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=jani.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org \
--cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-graphics-maintainer-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=liviu.dudau-5wv7dgnIgG8@public.gmane.org \
--cc=malidp-VeJGdqYn5oNWk0Htik3J/w@public.gmane.org \
--cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=syeh-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org \
--cc=thellstrom-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org \
--cc=tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org \
--cc=tomi.valkeinen-l0cyMroinI0@public.gmane.org \
--cc=ville.syrjala-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.